From 12eccc8fe4ed043698970de42921757eb0448c84 Mon Sep 17 00:00:00 2001 From: Jeremy Allison Date: Tue, 28 Feb 2006 15:58:09 +0000 Subject: [PATCH] r13759: As pointed out by Volker, it isn't much good creating a new empty acl in remove_posix_acl if you don't bother to set it on the file in question :-). Jeremy. --- source/smbd/posix_acls.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/source/smbd/posix_acls.c b/source/smbd/posix_acls.c index d4801d1743b..9e513580c3e 100644 --- a/source/smbd/posix_acls.c +++ b/source/smbd/posix_acls.c @@ -3834,6 +3834,21 @@ static BOOL remove_posix_acl(connection_struct *conn, files_struct *fsp, const c } } + /* Set the new empty file ACL. */ + if (fsp && fsp->fh->fd != -1) { + if (SMB_VFS_SYS_ACL_SET_FD(fsp, fsp->fh->fd, new_file_acl) == -1) { + DEBUG(5,("remove_posix_acl: acl_set_file failed on %s (%s)\n", + fname, strerror(errno) )); + goto done; + } + } else { + if (SMB_VFS_SYS_ACL_SET_FILE(conn, fname, SMB_ACL_TYPE_ACCESS, new_file_acl) == -1) { + DEBUG(5,("remove_posix_acl: acl_set_file failed on %s (%s)\n", + fname, strerror(errno) )); + goto done; + } + } + ret = True; done: -- 2.34.1