From 1719f8b9cd98cf54a297ef59c68db68945bf6f0f Mon Sep 17 00:00:00 2001 From: Andrew Bartlett Date: Thu, 15 Nov 2018 13:44:29 +1300 Subject: [PATCH] s4-samr: Use GUID_buf_string() in dcesrv_samr_EnumDomainUsers() This avoids memory allocation. Signed-off-by: Andrew Bartlett Reviewed-by: Gary Lockyer --- source4/rpc_server/samr/dcesrv_samr.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/source4/rpc_server/samr/dcesrv_samr.c b/source4/rpc_server/samr/dcesrv_samr.c index 53e2347fef6..8e464b1bf7e 100644 --- a/source4/rpc_server/samr/dcesrv_samr.c +++ b/source4/rpc_server/samr/dcesrv_samr.c @@ -1651,8 +1651,10 @@ static NTSTATUS dcesrv_samr_EnumDomainUsers(struct dcesrv_call_state *dce_call, attrs, 0); if (ret == LDB_ERR_NO_SUCH_OBJECT) { + struct GUID_txt_buf guid_buf; char *guid_str = - GUID_string(mem_ctx, &cache->entries[idx]); + GUID_buf_string(&cache->entries[idx], + &guid_buf); DBG_WARNING("GUID [%s] not found\n", guid_str); continue; } else if (ret != LDB_SUCCESS) { @@ -1663,8 +1665,10 @@ static NTSTATUS dcesrv_samr_EnumDomainUsers(struct dcesrv_call_state *dce_call, rec->msgs[0], "objectSID"); if (objectsid == NULL) { + struct GUID_txt_buf guid_buf; char *guid_str = - GUID_string(mem_ctx, &cache->entries[idx]); + GUID_buf_string(&cache->entries[idx], + &guid_buf); DBG_WARNING("objectSID for GUID [%s] not found\n", guid_str); continue; -- 2.34.1