From 31ca7b2dbbbfbb3a55670b58c08ebda68888af7e Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Sat, 16 Aug 2008 11:17:09 +0200 Subject: [PATCH] Attempt to fix Coverity ID 595 is_ipaddress already dereferences "name", so the NULL check is pointless after calling it. --- source/libcli/nbt/nbtname.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/libcli/nbt/nbtname.c b/source/libcli/nbt/nbtname.c index 2025ef70e73..fbb9550655a 100644 --- a/source/libcli/nbt/nbtname.c +++ b/source/libcli/nbt/nbtname.c @@ -420,7 +420,7 @@ _PUBLIC_ void nbt_choose_called_name(TALLOC_CTX *mem_ctx, n->scope = NULL; n->type = type; - if (is_ipaddress(name) || name == NULL) { + if ((name == NULL) || is_ipaddress(name)) { n->name = "*SMBSERVER"; return; } -- 2.34.1