From 38f09f326fc727c1a23b8c768b5c02cde7f3eceb Mon Sep 17 00:00:00 2001 From: Jelmer Vernooij Date: Thu, 14 Aug 2003 19:57:23 +0000 Subject: [PATCH] Fix overflow in vfs_recycle module (and hopefully also bug #291) (This used to be commit 8625f0e015481a79b0a7dedb77c60ce7b2cb7b84) --- source3/modules/vfs_recycle.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/source3/modules/vfs_recycle.c b/source3/modules/vfs_recycle.c index e725daedba4..c0b331b8621 100644 --- a/source3/modules/vfs_recycle.c +++ b/source3/modules/vfs_recycle.c @@ -455,7 +455,8 @@ static int recycle_unlink(vfs_handle_struct *handle, connection_struct *conn, co /* rename file we move to recycle bin */ i = 1; while (recycle_file_exist(handle, final_name)) { - snprintf(final_name, PATH_MAX -1, "%s/Copy #%d of %s", temp_name, i++, base); + SAFE_FREE(final_name); + asprintf(&final_name, "%s/Copy #%d of %s", temp_name, i++, base); } DEBUG(10, ("recycle: Moving %s to %s\n", file_name, final_name)); -- 2.34.1