From 444ecac2d28e02c6cc6da8ed97010fc475e834e5 Mon Sep 17 00:00:00 2001 From: Michael Adam Date: Tue, 12 Jan 2010 12:25:32 +0100 Subject: [PATCH] s3:auth: add comment to nulling out stolen sampass Adding this comment makes me think, I could also have changed make_server_info_sam() talloc_move instead of talloc_steal, but that would have changed the signature... Well the comment is a first step. :-) Michael --- source3/auth/auth_sam.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/source3/auth/auth_sam.c b/source3/auth/auth_sam.c index 834ca977dac..1dd8fc950ea 100644 --- a/source3/auth/auth_sam.c +++ b/source3/auth/auth_sam.c @@ -486,6 +486,10 @@ static NTSTATUS check_sam_security(const struct auth_context *auth_context, become_root(); nt_status = make_server_info_sam(server_info, sampass); unbecome_root(); + /* + * sampass has been stolen to server_info. + * So NULL it out to prevent segfaults. + */ sampass = NULL; if (!NT_STATUS_IS_OK(nt_status)) { -- 2.34.1