From abcb98343020d771ce1ae99f034b137fbce0d2b3 Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Tue, 15 Aug 2017 06:02:13 +0200 Subject: [PATCH] nfs4acls: Slightly simplify smb_add_ace4 The comment was a bit confusing to me, it took a few seconds too many to figure out *why* setting NULL is not required. Remove it :-) Signed-off-by: Volker Lendecke Reviewed-by: Ralph Boehme --- source3/modules/nfs4_acls.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/source3/modules/nfs4_acls.c b/source3/modules/nfs4_acls.c index 538517f4a3c..19f0fefdb98 100644 --- a/source3/modules/nfs4_acls.c +++ b/source3/modules/nfs4_acls.c @@ -184,8 +184,7 @@ struct SMB4ACE_T *smb_add_ace4(struct SMB4ACL_T *acl, SMB_ACE4PROP_T *prop) errno = ENOMEM; return NULL; } - /* ace->next = NULL not needed */ - memcpy(&ace->prop, prop, sizeof(SMB_ACE4PROP_T)); + ace->prop = *prop; if (acl->first==NULL) { -- 2.34.1