From b26a9eae1648ecfa9912aa8ce81e0f0ea674ca53 Mon Sep 17 00:00:00 2001 From: Andreas Schneider Date: Mon, 17 Dec 2012 14:40:17 +0100 Subject: [PATCH] s3-rpc_server: Fix useless check if we still have a valid string. MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Found by Coverity. Signed-off-by: Andreas Schneider Reviewed-by: Günther Deschner --- source3/rpc_server/svcctl/srv_svcctl_reg.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/source3/rpc_server/svcctl/srv_svcctl_reg.c b/source3/rpc_server/svcctl/srv_svcctl_reg.c index 930c327622f2..07b7ce6d4bed 100644 --- a/source3/rpc_server/svcctl/srv_svcctl_reg.c +++ b/source3/rpc_server/svcctl/srv_svcctl_reg.c @@ -224,13 +224,13 @@ static bool read_init_file(TALLOC_CTX *mem_ctx, p = strstr(str, "Description:"); if (p != NULL) { char *desc; + size_t len = strlen(p); - p += strlen( "Description:" ) + 1; - if (p == NULL) { + if (len <= 12) { break; } - desc = svcctl_cleanup_string(mem_ctx, p); + desc = svcctl_cleanup_string(mem_ctx, p + 12); if (desc != NULL) { info->description = talloc_strdup(info, desc); } -- 2.34.1