From c46fd168fc1c0021e97f849088ac634c1b077f27 Mon Sep 17 00:00:00 2001 From: Noel Power Date: Thu, 17 May 2018 15:25:29 +0100 Subject: [PATCH] python/samba/netcmd: Protect variable that can be None In py3 None variable cannot be compared with '>' '<' etc operators Signed-off-by: Noel Power Reviewed-by: Andreas Schneider Reviewed-by: Douglas Bagnall --- python/samba/netcmd/domain.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python/samba/netcmd/domain.py b/python/samba/netcmd/domain.py index d50cf3f526c..3b133645bea 100644 --- a/python/samba/netcmd/domain.py +++ b/python/samba/netcmd/domain.py @@ -1524,7 +1524,7 @@ class cmd_domain_passwordsettings_set(Command): ldb.FLAG_MOD_REPLACE, "lockOutObservationWindow") msgs.append("Duration to reset account lockout after changed!") - if max_pwd_age > 0 and min_pwd_age >= max_pwd_age: + if max_pwd_age and max_pwd_age > 0 and min_pwd_age >= max_pwd_age: raise CommandError("Maximum password age (%d) must be greater than minimum password age (%d)!" % (max_pwd_age, min_pwd_age)) if len(m) == 0: -- 2.34.1