From e56626e864492831a3dbbca2d4fb8f3281547a90 Mon Sep 17 00:00:00 2001 From: Andreas Schneider Date: Wed, 25 Oct 2017 19:25:20 +0200 Subject: [PATCH] s4:pyparam: Fix resource leaks on error BUG: https://bugzilla.samba.org/show_bug.cgi?id=13101 Signed-off-by: Andreas Schneider Reviewed-by: Jeremy Allison --- source4/param/pyparam.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/source4/param/pyparam.c b/source4/param/pyparam.c index 713e608cf1b..f16c2c0b227 100644 --- a/source4/param/pyparam.c +++ b/source4/param/pyparam.c @@ -331,6 +331,9 @@ static PyObject *py_lp_dump_a_parameter(PyObject *self, PyObject *args) if (!ret) { PyErr_Format(PyExc_RuntimeError, "Parameter %s unknown for section %s", param_name, section_name); + if (f != stdout) { + fclose(f); + } return NULL; } @@ -479,6 +482,9 @@ static PyObject *py_lp_service_dump(PyObject *self, PyObject *args) if (!PyObject_TypeCheck(py_default_service, &PyLoadparmService)) { PyErr_SetNone(PyExc_TypeError); + if (f != stdout) { + fclose(f); + } return NULL; } -- 2.34.1