From efa66c9ebf519dfaf194220652b3e5e01c303fb6 Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Wed, 28 Mar 2018 07:27:08 -0500 Subject: [PATCH] libads: Fix CID 1349423 Resource leak get_sorted_dc_list should already take care, but this way it's safer Signed-off-by: Volker Lendecke Reviewed-by: Jeremy Allison Autobuild-User(master): Jeremy Allison Autobuild-Date(master): Thu Mar 29 03:45:00 CEST 2018 on sn-devel-144 --- source3/libads/ldap.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/source3/libads/ldap.c b/source3/libads/ldap.c index 70166f2f5941..f9463043cc8f 100644 --- a/source3/libads/ldap.c +++ b/source3/libads/ldap.c @@ -412,7 +412,7 @@ static NTSTATUS resolve_and_ping_dns(ADS_STRUCT *ads, const char *sitename, const char *realm) { int count; - struct ip_service *ip_list; + struct ip_service *ip_list = NULL; NTSTATUS status = NT_STATUS_UNSUCCESSFUL; DEBUG(6, ("resolve_and_ping_dns: (cldap) looking for realm '%s'\n", @@ -421,6 +421,7 @@ static NTSTATUS resolve_and_ping_dns(ADS_STRUCT *ads, const char *sitename, status = get_sorted_dc_list(realm, sitename, &ip_list, &count, true); if (!NT_STATUS_IS_OK(status)) { + SAFE_FREE(ip_list); return status; } -- 2.34.1