From f715414afa7cb06af07bfd362bf340f6b13f7acb Mon Sep 17 00:00:00 2001 From: Stefan Metzmacher Date: Wed, 13 Jan 2010 12:00:27 +0100 Subject: [PATCH] s4:dsdb/schema_load: add a TODO about schema reloading metze --- source4/dsdb/samdb/ldb_modules/schema_load.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/source4/dsdb/samdb/ldb_modules/schema_load.c b/source4/dsdb/samdb/ldb_modules/schema_load.c index 6c11df21ce5..3442e821ce2 100644 --- a/source4/dsdb/samdb/ldb_modules/schema_load.c +++ b/source4/dsdb/samdb/ldb_modules/schema_load.c @@ -204,7 +204,17 @@ static int schema_load_extended(struct ldb_module *module, struct ldb_request *r if (strcmp(req->op.extended.oid, DSDB_EXTENDED_SCHEMA_UPDATE_NOW_OID) != 0) { return ldb_next_request(module, req); } - + + /* + * TODO: + * + * We should check "schemaInfo" if we really need to reload the schema! + * + * We should also for a new schema version at the start of each + * "write" (add/modify/rename/delete) operation. And have tests + * to prove that windows does the same. + */ + schema_dn = samdb_schema_dn(ldb); if (!schema_dn) { ldb_reset_err_string(ldb); -- 2.34.1