Stefan Metzmacher [Mon, 6 Apr 2009 14:35:56 +0000 (16:35 +0200)]
tsocket: reduce size of dummy variable
metze
Andrew Bartlett [Wed, 18 Mar 2009 06:35:03 +0000 (17:35 +1100)]
s3:libads Make ads_get_dn() take a talloc context
Also remove ads_memfree(), which was only ever a wrapper around
SAFE_FREE, used only to free the DN from ads_get_ds().
This actually makes libgpo more consistant, as it mixed a talloc and a
malloc based string on the same element.
Andrew Bartlett
Signed-off-by: Günther Deschner <gd@samba.org>
Stefan Metzmacher [Fri, 3 Apr 2009 12:29:51 +0000 (14:29 +0200)]
tsocket: use the correct 'ret' variable for tdgram_disconnect_send/recv()
metze
Andrew Bartlett [Wed, 18 Mar 2009 05:31:51 +0000 (16:31 +1100)]
s3:printing Convert nt_printer_publish_ads() to use talloc better
In particular, this removes one more user of pull_utf8_allocate()
Andrew Bartlett
Signed-off-by: Günther Deschner <gd@samba.org>
Andrew Bartlett [Wed, 18 Mar 2009 04:29:02 +0000 (15:29 +1100)]
s3:smbldap Remove smbldap_get_dn
This removes one more caller to pull_utf8_allocate()
Signed-off-by: Günther Deschner <gd@samba.org>
Volker Lendecke [Sun, 5 Apr 2009 05:32:03 +0000 (07:32 +0200)]
Make some functions static to vfs_gpfs.c
Volker Lendecke [Sun, 5 Apr 2009 05:31:47 +0000 (07:31 +0200)]
Add prototype for smbd_gpfs_get_realfilename_path
Volker Lendecke [Sun, 5 Apr 2009 05:31:30 +0000 (07:31 +0200)]
Fix two c++ warnings in vfs_gpfs.c
Günther Deschner [Mon, 6 Apr 2009 10:45:46 +0000 (12:45 +0200)]
s3-examples: Fix Bug #6205. Correct sample smb.conf share configuration.
Thanks to Jeffrey Riaboy <dakusan@castledragmire.com>.
Guenther
Jelmer Vernooij [Sun, 5 Apr 2009 21:03:13 +0000 (23:03 +0200)]
Improve formatting in Python file.
Jelmer Vernooij [Sun, 5 Apr 2009 21:17:43 +0000 (23:17 +0200)]
Make valid_netbios_name() check a bit stricter.
Volker Lendecke [Sun, 5 Apr 2009 15:13:02 +0000 (17:13 +0200)]
Use the server config file for smbpasswd -a user in make test
Without this, smbpasswd generated a SID for the netbios name TORTURE_6. This SID
somehow ended up in the user's token for quite a number of tests, leading to
NT_STATUS_ACCESS_DENIED. I haven't fully understood what is going on here, but
with this patch I could not reproduce the ACCESS_DENIED anymore. It might be
coincidence and this patch does not fix anything, but for me it does not really
hurt either.
Metze, please check!
Volker
Volker Lendecke [Sun, 5 Apr 2009 15:01:57 +0000 (17:01 +0200)]
Remove a silly check
This does not increase security, and if later error messages suck, we have to
fix those.
Volker Lendecke [Sat, 28 Mar 2009 13:57:57 +0000 (14:57 +0100)]
Remove async_req dependency from cli_pull_trans
Volker Lendecke [Sat, 28 Mar 2009 18:58:45 +0000 (19:58 +0100)]
Fix smbd crash for close_on_completion
handle_trans() can talloc_free "conn" if the client requests
close_on_completion. "state" is a talloc_child of conn, so it will be gone when
we later free state->data et al.
Volker Lendecke [Thu, 12 Feb 2009 11:12:04 +0000 (12:12 +0100)]
Keep the forked-smbd stdout reader around longer
Volker Lendecke [Thu, 12 Feb 2009 11:11:16 +0000 (12:11 +0100)]
Ensure 0-termination for the forked-smbd debug output
Volker Lendecke [Thu, 12 Feb 2009 19:41:49 +0000 (20:41 +0100)]
Pass the current debuglevel down to the forked smbd
Volker Lendecke [Sun, 5 Apr 2009 11:26:42 +0000 (13:26 +0200)]
Use recv instead of read in read_packet_handler
This way the socket wrapper pcap file also sees the replies :-)
Günther Deschner [Tue, 9 Dec 2008 12:25:59 +0000 (13:25 +0100)]
s3-samr: add support for setting password hashes via samr_SetUserInfo level 21.
Guenther
Günther Deschner [Fri, 3 Apr 2009 10:50:50 +0000 (12:50 +0200)]
s3-nsswitch: Fix Bug #6238 2nd part. zero blob pointer in wbcLogoffUserParams.
Patch from Rashid N. Achilov <citycat4@ngs.ru>.
Guenther
Volker Lendecke [Fri, 3 Apr 2009 08:43:13 +0000 (10:43 +0200)]
Use cluster-aware procid_is_me instead of comparing pid's
Volker Lendecke [Fri, 3 Apr 2009 08:42:43 +0000 (10:42 +0200)]
Use procid_str in debug messages for better cluster-debuggability
Günther Deschner [Fri, 3 Apr 2009 07:57:53 +0000 (09:57 +0200)]
s3-nsswitch: Fix Bug #6238. Make sure logoff is bla bla.
Fix inspired by patch from Rashid N. Achilov <citycat4@ngs.ru>.
Guenther
Günther Deschner [Thu, 2 Apr 2009 22:30:13 +0000 (00:30 +0200)]
s3-build: fix the build after tsocket changes.
Metze, please check.
Guenther
Günther Deschner [Thu, 2 Apr 2009 16:48:15 +0000 (18:48 +0200)]
s3-lsa: use LSA_ROLE definitions in _lsa_QueryInfoPolicy().
Guenther
Günther Deschner [Thu, 2 Apr 2009 16:47:51 +0000 (18:47 +0200)]
s3-lsa: don't SAFE_FREE talloced structs.
Guenther
Stefan Metzmacher [Thu, 2 Apr 2009 19:06:27 +0000 (21:06 +0200)]
tsocket: remove DGRAM support from tsocket_context
metze
Stefan Metzmacher [Sat, 28 Mar 2009 22:31:01 +0000 (23:31 +0100)]
libcli/cldap: convert to tsocket_* function to tdgram_*
metze
Stefan Metzmacher [Thu, 2 Apr 2009 08:36:03 +0000 (10:36 +0200)]
tsocket: optimize tdgram_bsd a lot
The desire is to do as less syscalls during the
tdgram_sendto_send/recv() and tdgram_recvfrom_send/recv()
operations.
1. we first try the sendto()/recvfrom() syscall and
only use a fd event if we got EAGAIN.
2. we cache the fd event and only change it's flags
if really needed.
For the highload case we do almost no epoll_ctl() and epoll_wait()/select()
syscalls anymore. This speeds up the LDAP-BENCH-CLDAP test
by more than 20%. (With a modified version of this test
which let the server skip any ldb calls and just return success
I'm getting about 8000 requests per second, while I'm getting
just about 6000 requests per second without optimization)
metze
Stefan Metzmacher [Sat, 28 Mar 2009 22:25:28 +0000 (23:25 +0100)]
tsocket: add tdgram_sendto_queue_send/recv()
metze
Stefan Metzmacher [Thu, 26 Mar 2009 13:27:45 +0000 (14:27 +0100)]
tsocket: split out a smaller tdgram_context abstraction
The idea is to have a tdgram and a tstream abstraction
which only provide tevent_req based io functions.
metze
Günther Deschner [Thu, 19 Mar 2009 11:30:26 +0000 (12:30 +0100)]
s3-spoolss: implement _spoolss_GetPrinterDriver2 level 101 (Bug #5140).
Guenther
Zack Kirsch [Thu, 2 Apr 2009 00:46:40 +0000 (17:46 -0700)]
s4 torture: Addition to RAW-BENCH-LOCK to take a configurable number of locks before starting the test
This can be useful for benchmarking as well as stress testing.
Zach Loafman [Wed, 1 Apr 2009 18:06:51 +0000 (11:06 -0700)]
s/NT_STATUS_WIN7_INVALID_RANGE/NT_STATUS_INVALID_LOCK_RANGE/g
Jeremy Allison [Thu, 2 Apr 2009 03:20:19 +0000 (20:20 -0700)]
Allow pdbedit to change a user rid/sid. Based on a fix from Alexander Zagrebin <alexz@visp.ru>.
Jeremy.
Jeremy Allison [Thu, 2 Apr 2009 03:20:44 +0000 (20:20 -0700)]
Merge branch 'master' of ssh://jra@git.samba.org/data/git/samba
Tim Prouty [Thu, 2 Apr 2009 03:01:34 +0000 (03:01 +0000)]
s3 onefs: Quiet a log message about oplocks being requested on streams
Tim Prouty [Thu, 2 Apr 2009 01:55:52 +0000 (18:55 -0700)]
s4 torture: Remove unused parameter
Tim Prouty [Thu, 2 Apr 2009 01:44:15 +0000 (18:44 -0700)]
s4 torture: Add new streams oplock test
Michael Adam [Wed, 1 Apr 2009 22:23:31 +0000 (00:23 +0200)]
s3:net conf: don't store share names as lower case, but as given.
Michael
Jeremy Allison [Wed, 1 Apr 2009 21:03:17 +0000 (14:03 -0700)]
Merge branch 'master' of ssh://jra@git.samba.org/data/git/samba
Günther Deschner [Wed, 1 Apr 2009 19:42:47 +0000 (21:42 +0200)]
s3-auth: rename static smb_create_user(). Sorry...
Guenther
Günther Deschner [Wed, 1 Apr 2009 17:03:18 +0000 (19:03 +0200)]
s3-libnet-samsync: return appropriate error code in fetch_sam_entry().
Guenther
Günther Deschner [Wed, 1 Apr 2009 16:52:28 +0000 (18:52 +0200)]
s3-libnet-samsync: use smb_create_user().
Guenther
Günther Deschner [Wed, 1 Apr 2009 16:52:13 +0000 (18:52 +0200)]
s3-passdb: add smb_create_user().
Guenther
Günther Deschner [Wed, 1 Apr 2009 15:56:45 +0000 (17:56 +0200)]
s3-libnet-samsync: some pure cosmetics.
Guenther
Günther Deschner [Wed, 1 Apr 2009 15:54:52 +0000 (17:54 +0200)]
s3-libnet-samsync: use parent talloc context for libnet_samsync_passdb.
Guenther
Jeremy Allison [Wed, 1 Apr 2009 16:16:41 +0000 (09:16 -0700)]
Merge branch 'master' of ssh://jra@git.samba.org/data/git/samba
Zach Loafman [Mon, 30 Mar 2009 22:59:06 +0000 (15:59 -0700)]
s4:torture/smb2: Add torture tests for lease breaks, durable opens.
Zach Loafman [Mon, 30 Mar 2009 22:57:57 +0000 (15:57 -0700)]
s4:smb2: Add lease break support for SMB2.1
Add the structures and marshalling for the lease break variants of the
oplock break / oplock break ack messages.
Günther Deschner [Wed, 1 Apr 2009 14:55:53 +0000 (16:55 +0200)]
s3-libnet: only call libnet_dssync_process() startup and shutdown callbacks when filled in.
Guenther
Stefan Metzmacher [Sat, 28 Mar 2009 22:29:23 +0000 (23:29 +0100)]
lib/util: fallback to any id in idr_get_new_random()
metze
Stefan Metzmacher [Sat, 28 Mar 2009 22:27:47 +0000 (23:27 +0100)]
libcli/cldap: fix memory/resource leak
We need to remove the message id, when a search request is finished
metze
Volker Lendecke [Wed, 1 Apr 2009 13:29:25 +0000 (15:29 +0200)]
Print an error if trying a merged build without a system kerberos lib
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Michael Adam [Wed, 1 Apr 2009 10:23:07 +0000 (12:23 +0200)]
s3: fix the fix for bug #6195 - dont let smbd child processes panic
This patch makes sure the original and temporary TDBs are closed
_before_ the rename. Originally, the open TDB was renamed, and so
the name passdb.tdb.tmp stayed around in the db context. Hence
upon client connect, the smbd children died because reinit_after_fork()
calling tdb_reopen_all() would try to reopen passdb.tdb.tmp which
existed no longer...
Michael
Michael Adam [Wed, 1 Apr 2009 00:02:10 +0000 (02:02 +0200)]
s3:build: add targets to show how libraries will be built / linked
showlibtalloc, showlibtdb, ... and one overall showlibs target.
Michael
Michael Adam [Tue, 31 Mar 2009 23:58:22 +0000 (01:58 +0200)]
s3:build: don't build the static libs unconditionally
Michael
Michael Adam [Tue, 31 Mar 2009 23:56:02 +0000 (01:56 +0200)]
s3:build: add LIBSMBCLIENT_LIBS and LIBSMBSHAREMODES_LIBS to Makefile
for completeness
Michael
Michael Adam [Tue, 31 Mar 2009 23:46:57 +0000 (01:46 +0200)]
s3:build: no need to set LIBFOO_STATIC to the object collection any more
now that the @LIBFOO_STATIC@ entries have vanished from the object lists.
Just use the static library.
Michael
Michael Adam [Tue, 31 Mar 2009 23:37:07 +0000 (01:37 +0200)]
s3:build: rename WINBIND_LIBS -> LIBWBCLIENT_LIBS for unification
Michael
Michael Adam [Tue, 31 Mar 2009 23:34:01 +0000 (01:34 +0200)]
s3:build: unify linking of libwbclient with a @LIBWBCLIENT_TARGET@
just like for the libs configured with SMB_LIBRARY().
This makes @LIBWBCLIENT_STATIC@ vanish from the object collections.
Michael
Michael Adam [Tue, 31 Mar 2009 22:37:47 +0000 (00:37 +0200)]
s3:build: first cut at fixing linking of shared/static libs internally
This is based on a patch from the debian packages
by Steve Langasek <vorlon@debian.org>.
It removes the static libs from the object collections.
For those libs that are set up with SMB_LIBRARY().
Michael
Jeremy Allison [Wed, 1 Apr 2009 01:28:49 +0000 (18:28 -0700)]
Tidy up some convert_string_internal error cases, found by Andrew Bartlett.
Jeremy.
Tim Prouty [Wed, 1 Apr 2009 00:25:57 +0000 (00:25 +0000)]
s3 onefs: Add missing newlines to debug statements in the onefs module
Zack Kirsch [Wed, 1 Apr 2009 00:00:40 +0000 (00:00 +0000)]
s3 onefs: Async failures are resulting in SMB_ASSERT->smb_panic while running many of the LOCK torture tests.
Return true from the onefs cancel function if we've errored, which can happen
when the CBRL domain is configured to only give out 1 lock. :)
Tim Prouty [Tue, 31 Mar 2009 23:24:07 +0000 (16:24 -0700)]
tdb: Remove unused variable
Volker Lendecke [Sun, 29 Mar 2009 19:35:57 +0000 (21:35 +0200)]
Fix an uninitialized variable valgrind error
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Tue, 31 Mar 2009 18:33:33 +0000 (20:33 +0200)]
tsocket: try to fix the build on solaris FIONREAD was missing
metze
Michael Adam [Tue, 31 Mar 2009 14:45:07 +0000 (16:45 +0200)]
s3:build: fix build of pam_winbind.so with static linking
Static talloc libs were missing since conversion to talloc.
Michael
Michael Adam [Tue, 31 Mar 2009 06:50:57 +0000 (08:50 +0200)]
s3:build: add a SHOWCFLAGS target for debugging how CFLAGS are assebled
Michael
Michael Adam [Tue, 31 Mar 2009 06:50:16 +0000 (08:50 +0200)]
s3:build: line-wrap assignment of FLAGS for readability
Michael
Andrew Tridgell [Tue, 31 Mar 2009 04:14:09 +0000 (15:14 +1100)]
change ldb version number (as ldb_module structure has changed)
Andrew Tridgell [Tue, 31 Mar 2009 04:08:36 +0000 (15:08 +1100)]
use the prepare_commit op in the partition code
This makes multi-partition ldb's much safer
Andrew Tridgell [Tue, 31 Mar 2009 04:07:54 +0000 (15:07 +1100)]
added support for a prepare_commit() op in ldb modules
This op will be used by the partition module to give us good
transaction semantics across the 4 partitions that sam.ldb uses.
Andrew Tridgell [Tue, 31 Mar 2009 04:06:23 +0000 (15:06 +1100)]
up the version to 1.1.4 with the addition of
tdb_transaction_prepare_commit()
Andrew Tridgell [Tue, 31 Mar 2009 02:59:56 +0000 (13:59 +1100)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba
Andrew Tridgell [Tue, 31 Mar 2009 02:59:03 +0000 (13:59 +1100)]
added basic testing of tdb_transaction_prepare_commit() in tdbtorture
Howard Chu [Tue, 31 Mar 2009 02:15:54 +0000 (13:15 +1100)]
Add tdb_transaction_prepare_commit()
Using tdb_transaction_prepare_commit() gives us 2-phase commits. This
allows us to safely commit across multiple tdb databases at once, with
reasonable transaction semantics
Signed-off-by: tridge@samba.org
Jeremy Allison [Mon, 30 Mar 2009 22:05:39 +0000 (15:05 -0700)]
Ensure files starting with multiple dots are hidden
if "hide dot files" is set. Thanks to Barry Kelly <bkelly.ie@gmail.com>
for pointing this one out.
Jeremy.
Björn Jacke [Fri, 27 Mar 2009 12:05:49 +0000 (13:05 +0100)]
s3/cups: add documentation for new cups encrypt parameter
Björn Jacke [Fri, 27 Mar 2009 12:05:00 +0000 (13:05 +0100)]
s3/cups: add encryption support
Volker Lendecke [Sat, 28 Mar 2009 23:52:22 +0000 (00:52 +0100)]
Fix a debug msg typo
Stefan Metzmacher [Sat, 28 Mar 2009 22:48:45 +0000 (23:48 +0100)]
tsocket: more s/sun/un to make the build on solaris happy
metze
Zach Loafman [Sat, 28 Mar 2009 02:14:01 +0000 (19:14 -0700)]
s4:torture/smb2: Add torture tests for leases.
Zach Loafman [Sat, 28 Mar 2009 02:12:43 +0000 (19:12 -0700)]
s4:smb2: Add rudimentary SMB2.1 lease support to libcli
Add the structures, constants, and marshalling for SMB2.1 leases.
Jeremy Allison [Sat, 28 Mar 2009 04:29:37 +0000 (21:29 -0700)]
Fix the problem of 3.0.x passdb databases being version
3 but using a different hash calculation than 3.2.x passwd
databases (also version 3). Introduces a minor version
number.
Jeremy.
Scott Urban [Sat, 28 Mar 2009 00:33:26 +0000 (17:33 -0700)]
s3: added per-client statistics to onefs perfcount module
* we now track, uid, remote ip, and local ip per CIFS operation
* removed perfcount_set_client() from perfcount interface as it's
unecessary
Derrell Lipman [Fri, 27 Mar 2009 22:03:00 +0000 (18:03 -0400)]
Ensure parameter types match format string
Derrell Lipman [Fri, 27 Mar 2009 22:02:46 +0000 (18:02 -0400)]
[Bug 6228] SMBC_open_ctx failure due to path resolve failure doesn't set errno
Fixed.
It turns out there were a number of places where cli_resolve_path() was called
and the error path upon that function failing did not set errno. There were a
couple of places the failure handling code did set errno to ENOENT, so I made
them all consistent, although I think better errno choices for this condition
exist, e.g. EHOSTUNREACH.
Derrell
Volker Lendecke [Fri, 27 Mar 2009 20:11:10 +0000 (21:11 +0100)]
Fix external np read after conversion to tevent_req
Jeremy Allison [Fri, 27 Mar 2009 19:12:30 +0000 (12:12 -0700)]
Fix bug #6195 - Migrating from 3.0.x to 3.3.x can fail to update passdb.tdb correctly. For the clustering case.
Clustered setups should have only ever used
the unsigned version of TDB_DATA in the
first place so they can't be in this mess :-).
Just do the normal upgrade in the clustered case.
Jeremy.
Björn Jacke [Fri, 27 Mar 2009 09:24:18 +0000 (10:24 +0100)]
s3: ifdef sendfile code that's only used in other ifdef'ed sendfile code
This fixes a "defined but not used" compile warning.
Stefan Metzmacher [Fri, 27 Mar 2009 12:25:26 +0000 (13:25 +0100)]
s4:torture/smb2: fix compiler warnings and bugs
metze
Stefan Metzmacher [Fri, 27 Mar 2009 12:21:25 +0000 (13:21 +0100)]
s4:torture/smb2: fix the build
We move prototypes of _PUBLIC_ functions into /dev/null,
as we want public function to have handwritten prototypes.
see proto_header_template in build/make/templates.mk...
metze
Stefan Metzmacher [Fri, 27 Mar 2009 11:20:09 +0000 (12:20 +0100)]
s4:build: make it possible to pass down CTAGS_OPTIONS or ETAGS_OPTIONS
metze
Stefan Metzmacher [Fri, 27 Mar 2009 11:19:10 +0000 (12:19 +0100)]
s3:build: make it possible to pass down CTAGS_OPTIONS or ETAGS_OPTIONS
metze
Stefan Metzmacher [Fri, 27 Mar 2009 10:34:13 +0000 (11:34 +0100)]
tsocket: try to fix the build on solaris systems
It seems that 'sun' is somewhere defined and we can
use it as name for variables or struct/union members.
metze
Volker Lendecke [Fri, 20 Mar 2009 15:09:17 +0000 (16:09 +0100)]
Fix the build of nfsv4_acls.c
.. after adding smb_iconv_convenience to ndr_size_security_descriptor()
Zach Loafman [Thu, 26 Mar 2009 20:35:39 +0000 (13:35 -0700)]
Add durable open / oplock interaction test. Rather than give it a chance to disconnect, Win7 will break a batch oplock immediately on contention.