From: Jelmer Vernooij <jelmer@samba.org>
Date: Sat, 7 Jun 2014 16:32:33 +0000 (+0200)
Subject: Simplify handling of old build limit showing.
X-Git-Url: http://git.samba.org/?p=build-farm.git;a=commitdiff_plain;h=b55c89d354e616f00ebcf5d6a31f86688a2a8765

Simplify handling of old build limit showing.
---

diff --git a/buildfarm/web/__init__.py b/buildfarm/web/__init__.py
index 08d577a1..8f15f54b 100755
--- a/buildfarm/web/__init__.py
+++ b/buildfarm/web/__init__.py
@@ -404,7 +404,7 @@ class BuildFarmPage(object):
 
 class ViewBuildPage(BuildFarmPage):
 
-    def show_oldrevs(self, myself, build, host, compiler, limit):
+    def show_oldrevs(self, myself, build, host, compiler, limit=None):
         """show the available old revisions, if any"""
 
         tree = build.tree
@@ -419,11 +419,7 @@ class ViewBuildPage(BuildFarmPage):
         yield "<thead><tr><th>Revision</th><th>Status</th><th>Age</th></tr></thead>\n"
         yield "<tbody>\n"
 
-        nb = 0
-        for old_build in old_builds:
-            if limit >= 0 and nb >= limit:
-                break
-            nb = nb + 1
+        for old_build in old_builds[:limit]:
             yield "<tr><td>%s</td><td>%s</td><td>%s</td></tr>\n" % (
                 revision_link(myself, old_build.revision, tree),
                 build_link(myself, old_build),