From a5112ec54a329d996a9772cdfad5f5357296bfc2 Mon Sep 17 00:00:00 2001 From: Jelmer Vernooij Date: Sat, 10 Mar 2012 18:53:43 +0100 Subject: [PATCH] Print 404 page if build is not found. --- buildfarm/web/__init__.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/buildfarm/web/__init__.py b/buildfarm/web/__init__.py index c4972dc5..f6444dcc 100755 --- a/buildfarm/web/__init__.py +++ b/buildfarm/web/__init__.py @@ -1030,7 +1030,13 @@ class BuildFarmApp(object): yield "".join(self.html_page(form, page.render_html(myself, wsgiref.util.shift_path_info(environ)))) elif fn == "build": build_checksum = wsgiref.util.shift_path_info(environ) - build = self.buildfarm.builds.get_by_checksum(build_checksum) + try: + build = self.buildfarm.builds.get_by_checksum(build_checksum) + except NoSuchBuildError: + start_response('404 Page Not Found', [ + ('Content-Type', 'text/html; charset=utf8')]) + yield "No build with checksum %s found" % build_checksum + return page = ViewBuildPage(self.buildfarm) subfn = wsgiref.util.shift_path_info(environ) if subfn == "+plain": -- 2.34.1