From b55c89d354e616f00ebcf5d6a31f86688a2a8765 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Jelmer=20Vernoo=C4=B3?= Date: Sat, 7 Jun 2014 18:32:33 +0200 Subject: [PATCH] Simplify handling of old build limit showing. --- buildfarm/web/__init__.py | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/buildfarm/web/__init__.py b/buildfarm/web/__init__.py index 08d577a1..8f15f54b 100755 --- a/buildfarm/web/__init__.py +++ b/buildfarm/web/__init__.py @@ -404,7 +404,7 @@ class BuildFarmPage(object): class ViewBuildPage(BuildFarmPage): - def show_oldrevs(self, myself, build, host, compiler, limit): + def show_oldrevs(self, myself, build, host, compiler, limit=None): """show the available old revisions, if any""" tree = build.tree @@ -419,11 +419,7 @@ class ViewBuildPage(BuildFarmPage): yield "RevisionStatusAge\n" yield "\n" - nb = 0 - for old_build in old_builds: - if limit >= 0 and nb >= limit: - break - nb = nb + 1 + for old_build in old_builds[:limit]: yield "%s%s%s\n" % ( revision_link(myself, old_build.revision, tree), build_link(myself, old_build), -- 2.34.1