idtree: fix right shift of signed ints, crash on large ids on AIX
authorRusty Russell <rusty@rustcorp.com.au>
Tue, 5 Oct 2010 02:36:19 +0000 (13:06 +1030)
committerMichael Adam <obnox@samba.org>
Wed, 14 Aug 2013 21:01:03 +0000 (23:01 +0200)
commit7be3abc69333f58602ebf871d38ec138b908a36c
tree4021ee567660ac5446bc280583b90e28ce690171
parent0769ae857d1d6295cba93c4998070de95439863e
idtree: fix right shift of signed ints, crash on large ids on AIX

Right-shifting signed integers in undefined; indeed it seems that on
AIX with their compiler, doing a 30-bit shift on (INT_MAX-200) gives
0, not 1 as we might expect.

The obvious fix is to make id and oid unsigned: l (level count) is also
logically unsigned.

(Note: Samba doesn't generally get to ids > 1 billion, but ctdb does)

Reported-by: Chris Cowan <cc@us.ibm.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-User: Rusty Russell <rusty@samba.org>
Autobuild-Date: Wed Oct  6 08:31:09 UTC 2010 on sn-devel-104
(cherry picked from commit 2db1987f5a3a4268ce64fe570ff598e3bf4ecc73)
lib/util/idtree.c