common: For AF_PACKET socket types, protocol is in network order
authorAmitay Isaacs <amitay@gmail.com>
Thu, 3 Mar 2016 03:17:40 +0000 (14:17 +1100)
committerAmitay Isaacs <amitay@gmail.com>
Mon, 7 Mar 2016 08:32:29 +0000 (19:32 +1100)
commit817199f0535d068a8f3ad558cbccc0f446807ad6
tree6d0d5d2589b7a2ed9b798c0c251c03a9805dc54e
parent3c5e54d2908752f393f8674e3aea8654fdec1bed
common: For AF_PACKET socket types, protocol is in network order

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11770

From man page of packet(7):

                                             protocol is the  IEEE  802.3
   protocol  number  in  network  byte  order.  See the <linux/if_ether.h>
   include file for a list of allowed protocols.  When protocol is set  to
   htons(ETH_P_ALL),  then all protocols are received.

Protocol argument was changed from network order to host order wrongly
in commit 9f8395cb7d49b63a82f75bf504f5f83920102b29.

Specifying "protocol" field to socket(AF_PACKET, ...) call only affects
the packets that are recevied.  So use protocol = 0 when sending raw
packets.

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Fri Mar  4 12:58:50 CET 2016 on sn-devel-144

(Imported from commit f5b6a5b13406c245ab9cc8c1699483af9eb21f88)
common/system_linux.c