From: David Disseldorp <ddiss@samba.org>
Date: Wed, 1 Feb 2012 12:21:04 +0000 (+0100)
Subject: s3-spoolss: remove duplicate "." in smbd spooler path
X-Git-Url: http://git.samba.org/?p=ddiss%2Fsamba.git;a=commitdiff_plain;h=2a54a06ac5e80d3f6173f3eab96791164e2f674d

s3-spoolss: remove duplicate "." in smbd spooler path
---

diff --git a/source3/printing/printspoolss.c b/source3/printing/printspoolss.c
index c02587e3877..b94314e4204 100644
--- a/source3/printing/printspoolss.c
+++ b/source3/printing/printspoolss.c
@@ -100,7 +100,8 @@ NTSTATUS print_spool_open(files_struct *fsp,
 		}
 	}
 
-	/* Ok, now we have to open an actual file.
+	/*
+	 * Ok, now we have to open an actual file.
 	 * Here is the reason:
 	 * We want to write the spool job to this file in
 	 * smbd for scalability reason (and also because
@@ -110,9 +111,13 @@ NTSTATUS print_spool_open(files_struct *fsp,
 	 * to spoolss in output_file so it can monitor and
 	 * take over once we call EndDocPrinter().
 	 * Of course we will not start writing until
-	 * StartDocPrinter() actually gives the ok. */
+	 * StartDocPrinter() actually gives the ok.
+	 * smbd spooler files do not include a print jobid
+	 * path component, as the jobid is only known after
+	 * calling StartDocPrinter().
+	 */
 
-	pf->filename = talloc_asprintf(pf, "%s/%s.XXXXXX",
+	pf->filename = talloc_asprintf(pf, "%s/%sXXXXXX",
 					lp_pathname(SNUM(fsp->conn)),
 					PRINT_SPOOL_PREFIX);
 	if (!pf->filename) {