From: Michael Adam Date: Wed, 11 Apr 2012 14:02:44 +0000 (+0200) Subject: s3:registry: update the seqnum in the subkey cache at the end of regval_store_keys X-Git-Url: http://git.samba.org/?p=ddiss%2Fsamba.git;a=commitdiff_plain;h=96f08f6d43cb9bebda175efd5719ca15549a5b99 s3:registry: update the seqnum in the subkey cache at the end of regval_store_keys The purpose is to prevent next reads from going to disk. Note that this will currently only be effective with local tdbs, not with ctdb: For tdb, store and delete bump the seqnum while transaction commit does not. For ctdb, transaction commit bumps the seqnum, while store and delete don't... This needs fixing (in ctdb). (cherry picked from commit 16d83149c1b5620598edd37bbd1a73bebec82b6e) --- diff --git a/source3/registry/reg_backend_db.c b/source3/registry/reg_backend_db.c index aaa2241997a..e0fe7c12115 100644 --- a/source3/registry/reg_backend_db.c +++ b/source3/registry/reg_backend_db.c @@ -984,7 +984,11 @@ static NTSTATUS regdb_store_keys_action(struct db_context *db, TALLOC_FREE(path); } - werr = WERR_OK; + /* + * Update the seqnum in the container to possibly + * prevent next read from going to disk + */ + werr = regsubkey_ctr_set_seqnum(store_ctx->ctr, db->get_seqnum(db)); done: talloc_free(mem_ctx);