From: Stefan Metzmacher <metze@samba.org>
Date: Fri, 22 Jun 2012 10:20:54 +0000 (+0200)
Subject: s3:serverid: don't ignore the result of dbwrap_parse_record()
X-Git-Tag: samba-4.0.0beta3~240
X-Git-Url: http://git.samba.org/?p=ddiss%2Fsamba.git;a=commitdiff_plain;h=ad82c52db0a057ddb1c463f136d7ff0260d780d0

s3:serverid: don't ignore the result of dbwrap_parse_record()

metze
---

diff --git a/source3/lib/serverid.c b/source3/lib/serverid.c
index 0033d608332..4e317566203 100644
--- a/source3/lib/serverid.c
+++ b/source3/lib/serverid.c
@@ -311,6 +311,7 @@ bool serverids_exist(const struct server_id *ids, int num_ids, bool *results)
 		struct serverid_exists_state state;
 		struct serverid_key key;
 		TDB_DATA tdbkey;
+		NTSTATUS status;
 
 		if (ids[i].unique_id == SERVERID_UNIQUE_ID_NOT_TO_VERIFY) {
 			results[i] = true;
@@ -325,7 +326,11 @@ bool serverids_exist(const struct server_id *ids, int num_ids, bool *results)
 
 		state.id = &ids[i];
 		state.exists = false;
-		dbwrap_parse_record(db, tdbkey, server_exists_parse, &state);
+		status = dbwrap_parse_record(db, tdbkey, server_exists_parse, &state);
+		if (!NT_STATUS_IS_OK(status)) {
+			results[i] = false;
+			continue;
+		}
 		results[i] = state.exists;
 	}
 	return true;