Andrew Tridgell [Tue, 5 Jul 2011 02:36:16 +0000 (12:36 +1000)]
s4-dsdb: allow removal of unknown attributes if RELAX set
this allows attributes not known in the schema to be removed if the
caller has set the RELAX control. This will be used by dbcheck to
allow cleaning of bad attributes from the database
Rusty Russell [Tue, 5 Jul 2011 03:38:09 +0000 (13:08 +0930)]
ccan: fix configure tests for __builtin_clz etc.
It's not enough to compile-test them: Michael Adam points out that nonexistant
functions merely cause a warning. We have to try to link them.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-User: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-Date: Tue Jul 5 07:08:55 CEST 2011 on sn-devel-104
Andrew Bartlett [Mon, 4 Jul 2011 23:47:25 +0000 (09:47 +1000)]
build: remove mktowscript
We finished the conversion a long time ago
Andrew Bartlett
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Tue Jul 5 05:56:06 CEST 2011 on sn-devel-104
Andrew Bartlett [Tue, 5 Jul 2011 02:33:27 +0000 (04:33 +0200)]
build: Add missing depencency on NDR_NBT
Andrew Bartlett [Tue, 5 Jul 2011 02:22:16 +0000 (04:22 +0200)]
build: Add missing dep on UTIL_TEVENT
Michael Adam [Mon, 4 Jul 2011 15:45:30 +0000 (17:45 +0200)]
s3:registry: remove unused function regdb_key_is_base_key()
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Mon Jul 4 21:11:32 CEST 2011 on sn-devel-104
Michael Adam [Mon, 4 Jul 2011 15:22:01 +0000 (17:22 +0200)]
s3:registry: replace use of deprecated talloc_destroy by talloc_free.
Michael Adam [Mon, 4 Jul 2011 15:21:23 +0000 (17:21 +0200)]
s3:registry: remove superfluous check for success of talloc_stackframe()
Michael Adam [Mon, 4 Jul 2011 15:20:28 +0000 (17:20 +0200)]
s3:registry: add debug-level-10 verbosity to regdb_upgrade_v2_v3_fn()
Michael Adam [Mon, 4 Jul 2011 15:13:58 +0000 (17:13 +0200)]
s3:registry: adapt a debug message to be more systematic
Michael Adam [Mon, 4 Jul 2011 14:23:08 +0000 (16:23 +0200)]
s3:registry: set registry version to 3 and add upgrade code
Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>
Michael Adam [Mon, 4 Jul 2011 14:21:26 +0000 (16:21 +0200)]
s3:registry: add db_context argument to regdb_upgrade_v1_to_v2()
Michael Adam [Mon, 4 Jul 2011 14:15:11 +0000 (16:15 +0200)]
s3:registry: wrap the whole db upgrade in one transaction
The purpose of this is to prepare for multiple upgrade steps
to be performed in a single transaction, so that no change
at all is made to that database if one step fails.
Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>
Michael Adam [Mon, 4 Jul 2011 14:09:33 +0000 (16:09 +0200)]
s3:registry: change regdb_store_regdb_version() to take db_context argument.
Michael Adam [Mon, 4 Jul 2011 13:23:39 +0000 (15:23 +0200)]
s3:registry: fix a comment typo
Michael Adam [Fri, 1 Jul 2011 11:49:12 +0000 (13:49 +0200)]
s3:registry: remove unused regdb_delete_sorted_subkeys()
Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>
Michael Adam [Fri, 1 Jul 2011 11:48:16 +0000 (13:48 +0200)]
s3:registry: don't delete the unused subkeys cache record any more
Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>
Michael Adam [Fri, 1 Jul 2011 11:37:41 +0000 (13:37 +0200)]
s3:registry: remove the code to create and search the sorted subkeys cache records
This is not needed any more.
Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>
Michael Adam [Fri, 1 Jul 2011 11:33:44 +0000 (13:33 +0200)]
s3:registry: adapt the comment explaining the definition of the existence of a key.
Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>
Michael Adam [Fri, 1 Jul 2011 11:18:51 +0000 (13:18 +0200)]
s3:registry: regdb_key_exists now checks only for the list-of-subkeys-record
Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>
Michael Adam [Mon, 4 Jul 2011 11:19:13 +0000 (13:19 +0200)]
s3:registry: rewrite init_registry_key_internal
This rewrites init_registry_key_internal() to correctly also create
base keys. It makes use of the existing create functions instead of
duplicating the code.
Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>
Michael Adam [Mon, 4 Jul 2011 11:14:43 +0000 (13:14 +0200)]
s3:registry: add regdb_create_basekey()
Function to create a base key in the registry db, i.e. one that
has no parent key.
Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>
Michael Adam [Mon, 4 Jul 2011 11:09:31 +0000 (13:09 +0200)]
s3:registry: add regdb_create_subkey_internal() taking additional db context argument
Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>
Michael Adam [Mon, 4 Jul 2011 11:06:20 +0000 (13:06 +0200)]
s3:registry: add new mode to regdb_store_subkey_list() for handing in NULL parent key
Standard behaviour is to concatenate parent and key path (parent\key).
This new mode allows for storing subkey lists for base keys using a NULL
parent argument.
Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>
Michael Adam [Fri, 1 Jul 2011 13:50:05 +0000 (15:50 +0200)]
s3:registry: create the empty list of subkeys of the new key in regdb_create_subkey
Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>
Michael Adam [Fri, 1 Jul 2011 13:47:50 +0000 (15:47 +0200)]
s3:registry: refactor creation of subkey list out into regdb_store_subkey_list()
Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>
Michael Adam [Fri, 1 Jul 2011 13:18:12 +0000 (15:18 +0200)]
s3:registry: remove redundant write of zero-lentgh subkey list record
In this case, the zero-lenght list has already been written in step #2.
Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>
Michael Adam [Fri, 1 Jul 2011 12:34:08 +0000 (14:34 +0200)]
s3:registry: don't update the sorted subkeys cache any more in regdb_store_keys_internal2()
Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>
Michael Adam [Fri, 1 Jul 2011 12:23:19 +0000 (14:23 +0200)]
s3:registry: don't skip base key in existence check in regdb_store_keys_internal()
Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>
Michael Adam [Fri, 1 Jul 2011 11:58:45 +0000 (13:58 +0200)]
s3:registry: don't skip base keys from existence check in regdb_create_subkey()
Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>
Michael Adam [Fri, 1 Jul 2011 11:57:19 +0000 (13:57 +0200)]
s3:registry: don't skip base keys from existence check in regdb_delete_subkey()
Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>
Michael Adam [Mon, 4 Jul 2011 15:01:29 +0000 (17:01 +0200)]
selftest: remove invalid use of the globbing operator <>
Michael Adam [Mon, 4 Jul 2011 08:28:43 +0000 (10:28 +0200)]
selftest: eliminate perl warnings (my $cmd masks earlier definition...)
Michael Adam [Mon, 4 Jul 2011 08:24:19 +0000 (10:24 +0200)]
selftest: eliminate a perl warning
In perl, %binary_mapping should be initialized as a hash, not a hash reference.
Christian Ambach [Mon, 4 Jul 2011 15:55:54 +0000 (17:55 +0200)]
s3:smb2 fix smbd crash on premature end of smb2 conn (Bug 8286)
when smbd tries to clean up locks after a premature end of a smb2
connection, lock_db has already been freed and so it crashes
this patch changes the order in which items are freed so that
lock_db is still around when it is needed
Jeremy, Metze, please check
Autobuild-User: Christian Ambach <ambi@samba.org>
Autobuild-Date: Mon Jul 4 20:00:26 CEST 2011 on sn-devel-104
Volker Lendecke [Mon, 4 Jul 2011 14:27:23 +0000 (16:27 +0200)]
s3: Fix an enum/int mixup
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon Jul 4 18:47:59 CEST 2011 on sn-devel-104
Stefan Metzmacher [Mon, 4 Jul 2011 13:57:20 +0000 (15:57 +0200)]
s3:smb2_server: there's no reason to check the session id twice on a smb2_tcon request
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Jul 4 17:34:13 CEST 2011 on sn-devel-104
Stefan Metzmacher [Mon, 4 Jul 2011 13:50:56 +0000 (15:50 +0200)]
s3:smb2_create: call 'return' after smbd_server_connection_terminate()
This is not strictly needed in the fork process model, but we hopefully
support other models in future.
metze
Andrew Bartlett [Mon, 4 Jul 2011 12:08:37 +0000 (22:08 +1000)]
s3-build add tevent depencency on libsmb
This may assist the build on FreeBSD 8.2
Andrew Bartlett
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Mon Jul 4 16:19:10 CEST 2011 on sn-devel-104
Günther Deschner [Fri, 1 Jul 2011 13:39:11 +0000 (15:39 +0200)]
s3-printing: open up a winreg pipe handle for the migration code.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Mon Jul 4 15:06:41 CEST 2011 on sn-devel-104
Andrew Bartlett [Mon, 4 Jul 2011 09:07:40 +0000 (19:07 +1000)]
s3-build link passdb modules against libpassdb
This ensures that they don't include a duplicate copy of
pdb_interface.c functions, because they will instead link the library.
Andrew Bartlett
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Mon Jul 4 12:24:50 CEST 2011 on sn-devel-104
Andrew Bartlett [Mon, 4 Jul 2011 09:03:52 +0000 (19:03 +1000)]
s3-build allow_undefined_symbols=False is the default now
Andrew Bartlett [Mon, 4 Jul 2011 08:30:25 +0000 (18:30 +1000)]
s3-auth libauth no longer requires undefined symbols
Andrew Bartlett [Mon, 4 Jul 2011 08:52:47 +0000 (18:52 +1000)]
s3-lib Move event_add_idle() to source3/lib/events.c
This allows libauth not to depend on smbd_base.
Andrew Bartlett
Andrew Bartlett [Mon, 4 Jul 2011 08:09:38 +0000 (18:09 +1000)]
s3-samr Send IP address only to PAM remote hostname hook on password set
The previous behaviour was to attempt to do a reverse hostname lookup,
where enabled. This new behaviour matches the new behaviour in the
modules called by auth stack.
Andrew Bartlett
Andreas Schneider [Thu, 16 Jun 2011 14:13:01 +0000 (16:13 +0200)]
s3: RIP 'struct client_address'.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Andreas Schneider [Thu, 16 Jun 2011 14:12:07 +0000 (16:12 +0200)]
s3-rpc_server: Remove client_id and server_id from pipes struct.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Andreas Schneider [Thu, 16 Jun 2011 14:09:07 +0000 (16:09 +0200)]
s3-smbd: Remove client_address from smbd_server_connection struct.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Andreas Schneider [Thu, 16 Jun 2011 14:08:09 +0000 (16:08 +0200)]
s3-smbd: Remove obsolete smbd_set_server_fd().
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Andreas Schneider [Thu, 16 Jun 2011 12:23:54 +0000 (14:23 +0200)]
s3-vfs: Replace client_id in exand msdfs.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Andreas Schneider [Thu, 16 Jun 2011 12:20:21 +0000 (14:20 +0200)]
s3-vfs: Replace client_id in smbta.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Andreas Schneider [Thu, 16 Jun 2011 14:03:03 +0000 (16:03 +0200)]
s3-smbd: Replace client_id in smbd session setup.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Andreas Schneider [Thu, 16 Jun 2011 13:57:48 +0000 (15:57 +0200)]
s3-smbd: Replace client_id in smbd session.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Andreas Schneider [Thu, 16 Jun 2011 13:49:41 +0000 (15:49 +0200)]
s3-smbd: Replace client_id in smbd service.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Andreas Schneider [Thu, 16 Jun 2011 13:45:18 +0000 (15:45 +0200)]
s3-smbd: Replace client_id in smbd reply.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Andreas Schneider [Thu, 16 Jun 2011 13:32:00 +0000 (15:32 +0200)]
s3-smbd: Exit cleanly if we can't create an address string.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Andreas Schneider [Thu, 16 Jun 2011 12:29:36 +0000 (14:29 +0200)]
s3-smbd: Replace client_id in smbd connection.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Andreas Schneider [Thu, 16 Jun 2011 13:39:25 +0000 (15:39 +0200)]
s3-smbd: Replace client_id in smbd process.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Andreas Schneider [Thu, 16 Jun 2011 14:22:49 +0000 (16:22 +0200)]
s3-epmapper: Replace server_id in the epmapper.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Andreas Schneider [Thu, 16 Jun 2011 12:46:26 +0000 (14:46 +0200)]
s3-spoolss: Replace client_id in the spoolss server.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Andreas Schneider [Wed, 15 Jun 2011 16:03:30 +0000 (18:03 +0200)]
s3-samr: Replace client_id in samr server.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Andreas Schneider [Wed, 15 Jun 2011 15:55:27 +0000 (17:55 +0200)]
s3-rpc_server: Replace client_id in dcerpc gssapi server.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Andreas Schneider [Wed, 15 Jun 2011 16:08:13 +0000 (18:08 +0200)]
s3-rpc_server: Remove unused client_id in srv_pipe.c.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Andreas Schneider [Wed, 15 Jun 2011 09:32:12 +0000 (11:32 +0200)]
s3-auth: Remove global smbd_server_conn from auth_unix.c.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Andreas Schneider [Wed, 8 Jun 2011 16:55:37 +0000 (18:55 +0200)]
s3-auth: Pass the remote_address down to user_info.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Andreas Schneider [Wed, 15 Jun 2011 09:15:06 +0000 (11:15 +0200)]
s3-auth: Added remote_address to ntlmssp server.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Andreas Schneider [Tue, 7 Jun 2011 15:21:28 +0000 (17:21 +0200)]
s3-rpc_server: Migrate rpc function to tsocket_address.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Andreas Schneider [Tue, 7 Jun 2011 15:03:13 +0000 (17:03 +0200)]
s3-rpc_server: Add local and remote address to pipes struct.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Andreas Schneider [Wed, 8 Jun 2011 12:50:20 +0000 (14:50 +0200)]
s3-util: Add a get_remote_hostname() function.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Andreas Schneider [Mon, 6 Jun 2011 14:07:23 +0000 (16:07 +0200)]
s3-auth: Only reload the config file.
We only need to reload the config file. This removes a dependency to
smbd.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Volker Lendecke [Sun, 3 Jul 2011 17:59:37 +0000 (19:59 +0200)]
s3: Make cli_cm_open return NTSTATUS
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Jul 3 23:57:53 CEST 2011 on sn-devel-104
Volker Lendecke [Sun, 3 Jul 2011 10:12:45 +0000 (12:12 +0200)]
s3: Make cli_cm_connect return NTSTATUS
Volker Lendecke [Sun, 3 Jul 2011 10:08:54 +0000 (12:08 +0200)]
s3: Make "do_connect" return NTSTATUS
Volker Lendecke [Sun, 3 Jul 2011 10:04:24 +0000 (12:04 +0200)]
s3: Remove a use of cli_errstr
Volker Lendecke [Sun, 3 Jul 2011 09:49:07 +0000 (11:49 +0200)]
s3: Remove a use of cli_errstr
Volker Lendecke [Sun, 3 Jul 2011 09:47:44 +0000 (11:47 +0200)]
s3: Remove a use of cli_errstr
Volker Lendecke [Sun, 3 Jul 2011 09:46:50 +0000 (11:46 +0200)]
s3: Remove a use of cli_errstr
Volker Lendecke [Sun, 3 Jul 2011 09:27:53 +0000 (11:27 +0200)]
s3: Remove two uses of cli_errstr
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Jul 3 12:43:32 CEST 2011 on sn-devel-104
Volker Lendecke [Sun, 3 Jul 2011 09:21:50 +0000 (11:21 +0200)]
s3: RAP errors are WERROR
Volker Lendecke [Sun, 3 Jul 2011 09:15:45 +0000 (11:15 +0200)]
s3: Remove some bogus error mappings
The old cli_session_request that used this is gone
Volker Lendecke [Sun, 3 Jul 2011 08:38:30 +0000 (10:38 +0200)]
s3: Remove a use of cli_errstr
All code above that might have failed sets result
Volker Lendecke [Sat, 30 Apr 2011 08:58:35 +0000 (10:58 +0200)]
s3: Allow NULL for arg pwritten in cli_write_andx
Volker Lendecke [Sat, 25 Jun 2011 13:14:25 +0000 (15:14 +0200)]
S3: Fix some nonempty blank lines
Volker Lendecke [Thu, 30 Jun 2011 13:26:21 +0000 (15:26 +0200)]
s3: Read symlink information in smbclient "allinfo"
Volker Lendecke [Thu, 30 Jun 2011 13:25:42 +0000 (15:25 +0200)]
s3: Fix symlink_reparse_buffer_parse
Volker Lendecke [Thu, 30 Jun 2011 13:06:46 +0000 (15:06 +0200)]
s3: Add cli_readlink
Volker Lendecke [Thu, 30 Jun 2011 13:25:16 +0000 (15:25 +0200)]
s3: Add STATUS_STOPPED_ON_SYMLINK error code
Andrew Bartlett [Sun, 3 Jul 2011 07:20:09 +0000 (09:20 +0200)]
s3-build Require fully defined modules by default
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Sun Jul 3 10:33:44 CEST 2011 on sn-devel-104
Andrew Bartlett [Sun, 3 Jul 2011 07:20:02 +0000 (09:20 +0200)]
s3-build Prepare to require fully defined modules
This specifies some more deps for our modules, and ensures that the
subsystem that it links against is in fact a library, which will avoid
issues with introducing duplicate symbols.
Andrew Bartlett
Andrew Bartlett [Fri, 1 Jul 2011 06:02:54 +0000 (16:02 +1000)]
s4-param Remove unused 'announce version'
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Sat Jul 2 05:42:37 CEST 2011 on sn-devel-104
Andrew Bartlett [Fri, 1 Jul 2011 06:01:28 +0000 (16:01 +1000)]
s3-param Remove #defines already in common loadparm.h
Andrew Bartlett [Fri, 1 Jul 2011 04:36:25 +0000 (14:36 +1000)]
s3-param Generate parameter tables
Andrew Bartlett [Fri, 1 Jul 2011 05:14:08 +0000 (15:14 +1000)]
param: Finish conversion from lp_wins_support() -> lp_we_are_a_wins_server()
Jermey started this in 1997 with
0aa493cc0303aa4177f289b9e4c797c8fa180672
(avoiding the duplicate function makes it easier to generate the
struct loadparm_globals).
Andrew Bartlett
Andrew Bartlett [Fri, 1 Jul 2011 04:37:16 +0000 (14:37 +1000)]
s3-param remove unused bIdmapReadOnly
Andrew Bartlett [Fri, 1 Jul 2011 04:19:05 +0000 (14:19 +1000)]
s3-param Remove unused bUpdateEncrypt
Günther Deschner [Fri, 1 Jul 2011 13:02:26 +0000 (15:02 +0200)]
s3-net: use printing_migrate library, and eliminate duplicate code.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Jul 1 17:57:09 CEST 2011 on sn-devel-104
Günther Deschner [Fri, 1 Jul 2011 12:57:32 +0000 (14:57 +0200)]
s3-printing: split out printing migration code into a smaller library.
Guenther
Gregor Beck [Tue, 21 Jun 2011 06:16:56 +0000 (08:16 +0200)]
s3:smbldap: make smbldap_connect_system self contained
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Fri Jul 1 12:37:50 CEST 2011 on sn-devel-104
Gregor Beck [Tue, 21 Jun 2011 06:06:28 +0000 (08:06 +0200)]
s3:smbldap: add a destructor to smbldap_state, just in case
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Gregor Beck [Tue, 21 Jun 2011 06:02:53 +0000 (08:02 +0200)]
s3:smbldap: let smbldap_free_struct do what it claims to
Signed-off-by: Stefan Metzmacher <metze@samba.org>