git.samba.org / kamenim / samba.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: dbf121e) | patch
s4-ldb: Refactor ldb_msg_diff() to be based on ldb_msg_diff_ex() implementatoin
authorKamen Mazdrashki <kamenim@samba.org>
Fri, 9 Jul 2010 03:53:27 +0000 (06:53 +0300)
committerKamen Mazdrashki <kamenim@samba.org>
Sat, 10 Jul 2010 20:03:13 +0000 (23:03 +0300)
commitc3db036163bbb780047dd69725eae01e94825cf7
treebd58141c432339ad44131e42e6799ef67741d873tree
parentdbf121e7b5d85df724aea5675b61fc8f53e6e1d9commit | diff
s4-ldb: Refactor ldb_msg_diff() to be based on ldb_msg_diff_ex() implementatoin

This changes ldb_msg_diff() behavior in two directions:
1. resulting message is allocated in NULL TALLOC_CTX
   This way it should appear as memory leak in talloc
   reports in case the caller haven't freed the memory
2. previous implementation had a hidden leak - internal
   ldb_msg returned from ldb_msg_canonicalize() wasn't freed
   and stays attached to ldb_context for the connection lifetime
source4/lib/ldb/common/ldb_msg.c diff | blob | history
kamenim's wip repo