From: Simo Sorce <idra@samba.org>
Date: Wed, 14 Jul 2010 12:57:47 +0000 (-0400)
Subject: s3-dcerpc: Break memory hierarchy for shared structure
X-Git-Url: http://git.samba.org/?p=kamenim%2Fsamba.git;a=commitdiff_plain;h=23ad6919a1e5f16d02e22adcf36ea7f039a9eeea

s3-dcerpc: Break memory hierarchy for shared structure

Handles are shared among multiple pipes_struct. We cannot allocate
them on any specific pipes_struct or it will vanish for all others
as soon as that pipes_struct is freed, leaving back dangling
pointers.

Signed-off-by: Andreas Schneider <asn@samba.org>
---

diff --git a/source3/rpc_server/rpc_handles.c b/source3/rpc_server/rpc_handles.c
index bfdc7a8561..e073fe45a2 100644
--- a/source3/rpc_server/rpc_handles.c
+++ b/source3/rpc_server/rpc_handles.c
@@ -103,7 +103,7 @@ bool init_pipe_handles(pipes_struct *p, const struct ndr_syntax_id *syntax)
 		/*
 		 * First open, we have to create the handle list
 		 */
-		hl = talloc_zero(p, struct handle_list);
+		hl = talloc_zero(NULL, struct handle_list);
 		if (hl == NULL) {
 			return false;
 		}