From 1ea4215e5681ccef921bbf77bb1af79fc1a82b77 Mon Sep 17 00:00:00 2001 From: Stefan Metzmacher Date: Sat, 10 Jul 2010 09:06:44 +0200 Subject: [PATCH] s4:libnet_GroupList: allocate children strings on the correct talloc parent Otherwise the _recv() function won't move the children strings to the callers memory context and let the callers crash. metze --- source4/libnet/libnet_group.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/source4/libnet/libnet_group.c b/source4/libnet/libnet_group.c index 8c88aa38bb..7679b42610 100644 --- a/source4/libnet/libnet_group.c +++ b/source4/libnet/libnet_group.c @@ -671,11 +671,11 @@ static void continue_groups_enumerated(struct tevent_req *subreq) if (composite_nomem(group_sid, c)) return; /* groupname */ - s->groups[i].groupname = talloc_strdup(c, entry->name.string); + s->groups[i].groupname = talloc_strdup(s->groups, entry->name.string); if (composite_nomem(s->groups[i].groupname, c)) return; /* sid string */ - s->groups[i].sid = dom_sid_string(c, group_sid); + s->groups[i].sid = dom_sid_string(s->groups, group_sid); if (composite_nomem(s->groups[i].sid, c)) return; } -- 2.34.1