From: Volker Lendecke <vl@samba.org>
Date: Wed, 16 Oct 2013 19:02:42 +0000 (+0200)
Subject: winbind3: Fix CID 1107229 Uninitialized pointer read
X-Git-Url: http://git.samba.org/?p=mat%2Fsamba.git;a=commitdiff_plain;h=28cdd1c46fec1bffa380c7be6122fb7ee05a9359

winbind3: Fix CID 1107229 Uninitialized pointer read

The first "goto done" would TALLOC_FREE the uninitialized "value"

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat Oct 19 03:43:04 CEST 2013 on sn-devel-104
---

diff --git a/source3/winbindd/winbindd_cm.c b/source3/winbindd/winbindd_cm.c
index ace0160a1c..edb2c7bac4 100644
--- a/source3/winbindd/winbindd_cm.c
+++ b/source3/winbindd/winbindd_cm.c
@@ -1565,7 +1565,8 @@ bool fetch_current_dc_from_gencache(TALLOC_CTX *mem_ctx,
 				    const char *domain_name,
 				    char **p_dc_name, char **p_dc_ip)
 {
-	char *key, *value, *p;
+	char *key, *p;
+	char *value = NULL;
 	bool ret = false;
 	char *dc_name = NULL;
 	char *dc_ip = NULL;