From 22ca0404fc973a6f716f76e7b4bbfa4656f33ab3 Mon Sep 17 00:00:00 2001 From: Andrew Bartlett Date: Mon, 14 Oct 2013 15:36:18 +1300 Subject: [PATCH] param: Skip generating hooks for local and string parameters Signed-off-by: Andrew Bartlett Reviewed-by: Stefan Metzmacher --- script/mks3param.pl | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/script/mks3param.pl b/script/mks3param.pl index 4222ca5744..799958c0b0 100644 --- a/script/mks3param.pl +++ b/script/mks3param.pl @@ -108,7 +108,14 @@ sub handle_loadparm($$) { my ($file,$line) = @_; - if ($line =~ /^FN_(GLOBAL|LOCAL)_(CONST_STRING|STRING|BOOL|bool|CHAR|INTEGER|LIST)\((\w+),.*\)/o) { + # Local parameters don't need the ->s3_fns because the struct + # loadparm_service is shared and lpcfg_service() checks the ->s3_fns + # hook + # + # STRING isn't handled as we do not yet have a way to pass in a memory context nor + # do we have a good way of dealing with the % macros yet. + + if ($line =~ /^FN_(GLOBAL)_(CONST_STRING|BOOL|bool|CHAR|INTEGER|LIST)\((\w+),.*\)/o) { my $scope = $1; my $type = $2; my $name = $3; -- 2.34.1