From 2343df451a13115eebfd46f9247ec2ae8c3a85c0 Mon Sep 17 00:00:00 2001 From: Andreas Schneider Date: Mon, 14 Oct 2013 13:17:12 +0200 Subject: [PATCH] talloc: Add a warning to talloc_reference() documentation. Signed-off-by: Andreas Schneider Reviewed-by: Kai Blin Autobuild-User(master): Andreas Schneider Autobuild-Date(master): Mon Oct 14 23:05:54 CEST 2013 on sn-devel-104 --- lib/talloc/talloc.h | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/lib/talloc/talloc.h b/lib/talloc/talloc.h index 1b59390e33..5d29a8d5cf 100644 --- a/lib/talloc/talloc.h +++ b/lib/talloc/talloc.h @@ -961,6 +961,10 @@ size_t talloc_reference_count(const void *ptr); * @return The original pointer 'ptr', NULL if talloc ran out of * memory in creating the reference. * + * @warning You should try to avoid using this interface. It turns a beautiful + * talloc-tree into a graph. It is often really hard to debug if you + * screw something up by accident. + * * Example: * @code * unsigned int *a, *b, *c; @@ -1001,6 +1005,10 @@ void *_talloc_reference_loc(const void *context, const void *ptr, const char *lo * this function will fail and will return -1. Likewise, if ptr is NULL, * then the function will make no modifications and return -1. * + * @warning You should try to avoid using this interface. It turns a beautiful + * talloc-tree into a graph. It is often really hard to debug if you + * screw something up by accident. + * * Example: * @code * unsigned int *a, *b, *c; -- 2.34.1