idtree: fix right shift of signed ints, crash on large ids on AIX
authorRusty Russell <rusty@rustcorp.com.au>
Tue, 5 Oct 2010 02:36:19 +0000 (13:06 +1030)
committerRonnie Sahlberg <ronniesahlberg@gmail.com>
Fri, 8 Oct 2010 01:30:19 +0000 (12:30 +1100)
commit90b7e79446f06990f82c0128b2581e15497094fe
tree08f9f55bdac9aa30eb4fa85ace4e1b20f1e8adbb
parent25f96db966230e90291eee57841c9faaae33713b
idtree: fix right shift of signed ints, crash on large ids on AIX

Right-shifting signed integers in undefined; indeed it seems that on
AIX with their compiler, doing a 30-bit shift on (INT_MAX-200) gives
0, not 1 as we might expect.

The obvious fix is to make id and oid unsigned: l (level count) is also
logically unsigned.

(Note: Samba doesn't generally get to ids > 1 billion, but ctdb does)

Reported-by: Chris Cowan <cc@us.ibm.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-User: Rusty Russell <rusty@samba.org>
Autobuild-Date: Wed Oct  6 08:31:09 UTC 2010 on sn-devel-104
lib/util/idtree.c