s3:libsmb/cli*: use CLI_BUFFER_SIZE instead of cli->max_xmit
[metze/samba/wip.git] / source3 / libsmb / clidfs.c
index 7b63f9535e935d6ba40093153a16f5284d08765c..a40ef896e8cabf2fdc8a631f28604327bd7274ff 100644 (file)
@@ -3,7 +3,7 @@
    client connect/disconnect routines
    Copyright (C) Andrew Tridgell                  1994-1998
    Copyright (C) Gerald (Jerry) Carter            2004
-   Copyright (C) Jeremy Allison                   2007
+   Copyright (C) Jeremy Allison                   2007-2009
 
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
 */
 
 #include "includes.h"
+#include "libsmb/libsmb.h"
+#include "libsmb/clirap.h"
+#include "msdfs.h"
+#include "trans2.h"
+#include "libsmb/nmblib.h"
 
 /********************************************************************
  Important point.
    as a separator when looking at the pathname part.... JRA.
 ********************************************************************/
 
-struct client_connection {
-       struct client_connection *prev, *next;
-       struct cli_state *cli;
-       char *mount;
-};
-
-/* global state....globals reek! */
-int max_protocol = PROTOCOL_NT1;
-
-static struct cm_cred_struct {
-       char *username;
-       char *password;
-       bool got_pass;
-       bool use_kerberos;
-       bool fallback_after_kerberos;
-       int signing_state;
-} cm_creds;
-
-static void cm_set_password(const char *newpass);
-
-static int port;
-static int name_type = 0x20;
-static bool have_ip;
-static struct sockaddr_storage dest_ss;
-
-static struct client_connection *connections;
-
-static bool cli_check_msdfs_proxy(TALLOC_CTX *ctx,
-                               struct cli_state *cli,
-                               const char *sharename,
-                               char **pp_newserver,
-                               char **pp_newshare,
-                               bool force_encrypt,
-                               const char *username,
-                               const char *password,
-                               const char *domain);
-
 /********************************************************************
  Ensure a connection is encrypted.
 ********************************************************************/
@@ -104,21 +72,23 @@ NTSTATUS cli_cm_force_encryption(struct cli_state *c,
 
        return status;
 }
-       
+
 /********************************************************************
  Return a connection to a server.
 ********************************************************************/
 
-static struct cli_state *do_connect(TALLOC_CTX *ctx,
+static NTSTATUS do_connect(TALLOC_CTX *ctx,
                                        const char *server,
                                        const char *share,
+                                       const struct user_auth_info *auth_info,
                                        bool show_sessetup,
-                                       bool force_encrypt)
+                                       bool force_encrypt,
+                                       int max_protocol,
+                                       int port,
+                                       int name_type,
+                                       struct cli_state **pcli)
 {
        struct cli_state *c = NULL;
-       struct nmb_name called, calling;
-       const char *server_n;
-       struct sockaddr_storage ss;
        char *servicename;
        char *sharename;
        char *newserver, *newshare;
@@ -129,112 +99,90 @@ static struct cli_state *do_connect(TALLOC_CTX *ctx,
        /* make a copy so we don't modify the global string 'service' */
        servicename = talloc_strdup(ctx,share);
        if (!servicename) {
-               return NULL;
+               return NT_STATUS_NO_MEMORY;
        }
        sharename = servicename;
        if (*sharename == '\\') {
-               server = sharename+2;
-               sharename = strchr_m(server,'\\');
+               sharename += 2;
+               if (server == NULL) {
+                       server = sharename;
+               }
+               sharename = strchr_m(sharename,'\\');
                if (!sharename) {
-                       return NULL;
+                       return NT_STATUS_NO_MEMORY;
                }
                *sharename = 0;
                sharename++;
        }
+       if (server == NULL) {
+               return NT_STATUS_INVALID_PARAMETER;
+       }
 
-       server_n = server;
-
-       zero_addr(&ss);
-
-       make_nmb_name(&calling, global_myname(), 0x0);
-       make_nmb_name(&called , server, name_type);
-
- again:
-       zero_addr(&ss);
-       if (have_ip)
-               ss = dest_ss;
+       status = cli_connect_nb(
+               server, NULL, port, name_type, NULL,
+               get_cmdline_auth_info_signing_state(auth_info), &c);
 
-       /* have to open a new connection */
-       if (!(c=cli_initialise()) || (cli_set_port(c, port) != port)) {
-               d_printf("Connection to %s failed\n", server_n);
-               if (c) {
-                       cli_shutdown(c);
-               }
-               return NULL;
-       }
-       status = cli_connect(c, server_n, &ss);
        if (!NT_STATUS_IS_OK(status)) {
                d_printf("Connection to %s failed (Error %s)\n",
-                               server_n,
+                               server,
                                nt_errstr(status));
-               cli_shutdown(c);
-               return NULL;
+               return status;
        }
 
-       c->protocol = max_protocol;
-       c->use_kerberos = cm_creds.use_kerberos;
-       c->fallback_after_kerberos = cm_creds.fallback_after_kerberos;
-       cli_setup_signing_state(c, cm_creds.signing_state);
-
-       if (!cli_session_request(c, &calling, &called)) {
-               char *p;
-               d_printf("session request to %s failed (%s)\n",
-                        called.name, cli_errstr(c));
-               cli_shutdown(c);
-               c = NULL;
-               if ((p=strchr_m(called.name, '.'))) {
-                       *p = 0;
-                       goto again;
-               }
-               if (strcmp(called.name, "*SMBSERVER")) {
-                       make_nmb_name(&called , "*SMBSERVER", 0x20);
-                       goto again;
-               }
-               return NULL;
+       if (max_protocol == 0) {
+               max_protocol = PROTOCOL_NT1;
        }
+       c->protocol = max_protocol;
+       c->use_kerberos = get_cmdline_auth_info_use_kerberos(auth_info);
+       c->fallback_after_kerberos =
+               get_cmdline_auth_info_fallback_after_kerberos(auth_info);
+       c->use_ccache = get_cmdline_auth_info_use_ccache(auth_info);
 
        DEBUG(4,(" session request ok\n"));
 
-       if (!cli_negprot(c)) {
-               d_printf("protocol negotiation failed\n");
-               cli_shutdown(c);
-               return NULL;
-       }
+       status = cli_negprot(c);
 
-       if (!cm_creds.got_pass && !cm_creds.use_kerberos) {
-               char *label = NULL;
-               char *pass;
-               label = talloc_asprintf(ctx, "Enter %s's password: ",
-                       cm_creds.username);
-               pass = getpass(label);
-               if (pass) {
-                       cm_set_password(pass);
-               }
-               TALLOC_FREE(label);
+       if (!NT_STATUS_IS_OK(status)) {
+               d_printf("protocol negotiation failed: %s\n",
+                        nt_errstr(status));
+               cli_shutdown(c);
+               return status;
        }
 
-       username = cm_creds.username ? cm_creds.username : "";
-       password = cm_creds.password ? cm_creds.password : "";
+       username = get_cmdline_auth_info_username(auth_info);
+       password = get_cmdline_auth_info_password(auth_info);
 
-       if (!NT_STATUS_IS_OK(cli_session_setup(c, username,
-                                              password, strlen(password),
-                                              password, strlen(password),
-                                              lp_workgroup()))) {
+       status = cli_session_setup(c, username,
+                                  password, strlen(password),
+                                  password, strlen(password),
+                                  lp_workgroup());
+       if (!NT_STATUS_IS_OK(status)) {
                /* If a password was not supplied then
                 * try again with a null username. */
-               if (password[0] || !username[0] || cm_creds.use_kerberos ||
-                   !NT_STATUS_IS_OK(cli_session_setup(c, "",
+               if (password[0] || !username[0] ||
+                       get_cmdline_auth_info_use_kerberos(auth_info) ||
+                       !NT_STATUS_IS_OK(status = cli_session_setup(c, "",
                                                "", 0,
                                                "", 0,
                                               lp_workgroup()))) {
-                       d_printf("session setup failed: %s\n", cli_errstr(c));
+                       d_printf("session setup failed: %s\n",
+                                nt_errstr(status));
                        if (NT_STATUS_V(cli_nt_error(c)) ==
                            NT_STATUS_V(NT_STATUS_MORE_PROCESSING_REQUIRED))
                                d_printf("did you forget to run kinit?\n");
                        cli_shutdown(c);
-                       return NULL;
+                       return status;
                }
                d_printf("Anonymous login successful\n");
+               status = cli_init_creds(c, "", lp_workgroup(), "");
+       } else {
+               status = cli_init_creds(c, username, lp_workgroup(), password);
+       }
+
+       if (!NT_STATUS_IS_OK(status)) {
+               DEBUG(10,("cli_init_creds() failed: %s\n", nt_errstr(status)));
+               cli_shutdown(c);
+               return status;
        }
 
        if ( show_sessetup ) {
@@ -251,9 +199,9 @@ static struct cli_state *do_connect(TALLOC_CTX *ctx,
        /* here's the fun part....to support 'msdfs proxy' shares
           (on Samba or windows) we have to issues a TRANS_GET_DFS_REFERRAL
           here before trying to connect to the original share.
-          check_dfs_proxy() will fail if it is a normal share. */
+          cli_check_msdfs_proxy() will fail if it is a normal share. */
 
-       if ((c->capabilities & CAP_DFS) &&
+       if ((cli_state_capabilities(c) & CAP_DFS) &&
                        cli_check_msdfs_proxy(ctx, c, sharename,
                                &newserver, &newshare,
                                force_encrypt,
@@ -262,16 +210,19 @@ static struct cli_state *do_connect(TALLOC_CTX *ctx,
                                lp_workgroup())) {
                cli_shutdown(c);
                return do_connect(ctx, newserver,
-                               newshare, false, force_encrypt);
+                               newshare, auth_info, false,
+                               force_encrypt, max_protocol,
+                               port, name_type, pcli);
        }
 
        /* must be a normal share */
 
-       if (!cli_send_tconX(c, sharename, "?????",
-                               password, strlen(password)+1)) {
-               d_printf("tree connect failed: %s\n", cli_errstr(c));
+       status = cli_tcon_andx(c, sharename, "?????",
+                              password, strlen(password)+1);
+       if (!NT_STATUS_IS_OK(status)) {
+               d_printf("tree connect failed: %s\n", nt_errstr(status));
                cli_shutdown(c);
-               return NULL;
+               return status;
        }
 
        if (force_encrypt) {
@@ -282,116 +233,112 @@ static struct cli_state *do_connect(TALLOC_CTX *ctx,
                                        sharename);
                if (!NT_STATUS_IS_OK(status)) {
                        cli_shutdown(c);
-                       return NULL;
+                       return status;
                }
        }
 
        DEBUG(4,(" tconx ok\n"));
-       return c;
-}
-
-/****************************************************************************
-****************************************************************************/
-
-static void cli_cm_set_mntpoint(struct cli_state *c, const char *mnt)
-{
-       struct client_connection *p;
-       int i;
-
-       for (p=connections,i=0; p; p=p->next,i++) {
-               if (strequal(p->cli->desthost, c->desthost) &&
-                               strequal(p->cli->share, c->share)) {
-                       break;
-               }
-       }
-
-       if (p) {
-               char *name = clean_name(NULL, p->mount);
-               if (!name) {
-                       return;
-               }
-               p->mount = talloc_strdup(p, name);
-               TALLOC_FREE(name);
-       }
+       *pcli = c;
+       return NT_STATUS_OK;
 }
 
 /****************************************************************************
 ****************************************************************************/
 
-const char *cli_cm_get_mntpoint(struct cli_state *c)
+static void cli_set_mntpoint(struct cli_state *cli, const char *mnt)
 {
-       struct client_connection *p;
-       int i;
-
-       for (p=connections,i=0; p; p=p->next,i++) {
-               if (strequal(p->cli->desthost, c->desthost) &&
-                               strequal(p->cli->share, c->share)) {
-                       break;
-               }
-       }
-
-       if (p) {
-               return p->mount;
+       char *name = clean_name(NULL, mnt);
+       if (!name) {
+               return;
        }
-       return NULL;
+       TALLOC_FREE(cli->dfs_mountpoint);
+       cli->dfs_mountpoint = talloc_strdup(cli, name);
+       TALLOC_FREE(name);
 }
 
 /********************************************************************
- Add a new connection to the list
+ Add a new connection to the list.
+ referring_cli == NULL means a new initial connection.
 ********************************************************************/
 
-static struct cli_state *cli_cm_connect(TALLOC_CTX *ctx,
-                                       struct cli_state *referring_cli,
-                                       const char *server,
-                                       const char *share,
-                                       bool show_hdr,
-                                       bool force_encrypt)
+static NTSTATUS cli_cm_connect(TALLOC_CTX *ctx,
+                              struct cli_state *referring_cli,
+                              const char *server,
+                              const char *share,
+                              const struct user_auth_info *auth_info,
+                              bool show_hdr,
+                              bool force_encrypt,
+                              int max_protocol,
+                              int port,
+                              int name_type,
+                              struct cli_state **pcli)
 {
-       struct client_connection *node;
-
-       /* NB This must be the null context here... JRA. */
-       node = TALLOC_ZERO_ARRAY(NULL, struct client_connection, 1);
-       if (!node) {
-               return NULL;
-       }
+       struct cli_state *cli;
+       NTSTATUS status;
 
-       node->cli = do_connect(ctx, server, share, show_hdr, force_encrypt);
+       status = do_connect(ctx, server, share,
+                               auth_info,
+                               show_hdr, force_encrypt, max_protocol,
+                               port, name_type, &cli);
 
-       if ( !node->cli ) {
-               TALLOC_FREE( node );
-               return NULL;
+       if (!NT_STATUS_IS_OK(status)) {
+               return status;
        }
 
-       DLIST_ADD( connections, node );
-
-       cli_cm_set_mntpoint(node->cli, "");
+       /* Enter into the list. */
+       if (referring_cli) {
+               DLIST_ADD_END(referring_cli, cli, struct cli_state *);
+       }
 
-       if (referring_cli && referring_cli->posix_capabilities) {
+       if (referring_cli && referring_cli->requested_posix_capabilities) {
                uint16 major, minor;
                uint32 caplow, caphigh;
-               if (cli_unix_extensions_version(node->cli, &major,
-                                       &minor, &caplow, &caphigh)) {
-                       cli_set_unix_extensions_capabilities(node->cli,
+               status = cli_unix_extensions_version(cli, &major, &minor,
+                                                    &caplow, &caphigh);
+               if (NT_STATUS_IS_OK(status)) {
+                       cli_set_unix_extensions_capabilities(cli,
                                        major, minor,
                                        caplow, caphigh);
                }
        }
 
-       return node->cli;
+       *pcli = cli;
+       return NT_STATUS_OK;
 }
 
 /********************************************************************
- Return a connection to a server.
+ Return a connection to a server on a particular share.
 ********************************************************************/
 
-static struct cli_state *cli_cm_find(const char *server, const char *share)
+static struct cli_state *cli_cm_find(struct cli_state *cli,
+                               const char *server,
+                               const char *share)
 {
-       struct client_connection *p;
+       struct cli_state *p;
+
+       if (cli == NULL) {
+               return NULL;
+       }
+
+       /* Search to the start of the list. */
+       for (p = cli; p; p = DLIST_PREV(p)) {
+               const char *remote_name =
+                       cli_state_remote_name(p);
+
+               if (strequal(server, remote_name) &&
+                               strequal(share,p->share)) {
+                       return p;
+               }
+       }
+
+       /* Search to the end of the list. */
+       for (p = cli->next; p; p = p->next) {
+               const char *remote_name =
+                       cli_state_remote_name(p);
 
-       for (p=connections; p; p=p->next) {
-               if ( strequal(server, p->cli->desthost) &&
-                               strequal(share,p->cli->share)) {
-                       return p->cli;
+               if (strequal(server, remote_name) &&
+                               strequal(share,p->share)) {
+                       return p;
                }
        }
 
@@ -399,167 +346,98 @@ static struct cli_state *cli_cm_find(const char *server, const char *share)
 }
 
 /****************************************************************************
- Open a client connection to a \\server\share.  Set's the current *cli
- global variable as a side-effect (but only if the connection is successful).
+ Open a client connection to a \\server\share.
 ****************************************************************************/
 
-struct cli_state *cli_cm_open(TALLOC_CTX *ctx,
+NTSTATUS cli_cm_open(TALLOC_CTX *ctx,
                                struct cli_state *referring_cli,
                                const char *server,
                                const char *share,
+                               const struct user_auth_info *auth_info,
                                bool show_hdr,
-                               bool force_encrypt)
+                               bool force_encrypt,
+                               int max_protocol,
+                               int port,
+                               int name_type,
+                               struct cli_state **pcli)
 {
-       struct cli_state *c;
-
-       /* try to reuse an existing connection */
+       /* Try to reuse an existing connection in this list. */
+       struct cli_state *c = cli_cm_find(referring_cli, server, share);
+       NTSTATUS status;
 
-       c = cli_cm_find(server, share);
-       if (!c) {
-               c = cli_cm_connect(ctx, referring_cli,
-                               server, share, show_hdr, force_encrypt);
+       if (c) {
+               *pcli = c;
+               return NT_STATUS_OK;
        }
 
-       return c;
-}
-
-/****************************************************************************
-****************************************************************************/
-
-void cli_cm_shutdown(void)
-{
-       struct client_connection *p, *x;
-
-       for (p=connections; p;) {
-               cli_shutdown(p->cli);
-               x = p;
-               p = p->next;
-
-               TALLOC_FREE(x);
+       if (auth_info == NULL) {
+               /* Can't do a new connection
+                * without auth info. */
+               d_printf("cli_cm_open() Unable to open connection [\\%s\\%s] "
+                       "without auth info\n",
+                       server, share );
+               return NT_STATUS_INVALID_PARAMETER;
        }
 
-       connections = NULL;
-       return;
+       status = cli_cm_connect(ctx,
+                               referring_cli,
+                               server,
+                               share,
+                               auth_info,
+                               show_hdr,
+                               force_encrypt,
+                               max_protocol,
+                               port,
+                               name_type,
+                               &c);
+       if (!NT_STATUS_IS_OK(status)) {
+               return status;
+       }
+       *pcli = c;
+       return NT_STATUS_OK;
 }
 
 /****************************************************************************
 ****************************************************************************/
 
-void cli_cm_display(void)
+void cli_cm_display(struct cli_state *cli)
 {
-       struct client_connection *p;
        int i;
 
-       for ( p=connections,i=0; p; p=p->next,i++ ) {
+       for (i=0; cli; cli = cli->next,i++ ) {
                d_printf("%d:\tserver=%s, share=%s\n",
-                       i, p->cli->desthost, p->cli->share );
+                       i, cli_state_remote_name(cli), cli->share);
        }
 }
 
 /****************************************************************************
 ****************************************************************************/
 
-static void cm_set_password(const char *newpass)
-{
-       SAFE_FREE(cm_creds.password);
-       cm_creds.password = SMB_STRDUP(newpass);
-       if (cm_creds.password) {
-               cm_creds.got_pass = true;
-       }
-}
-
 /****************************************************************************
 ****************************************************************************/
 
-void cli_cm_set_credentials(void)
+#if 0
+void cli_cm_set_credentials(struct user_auth_info *auth_info)
 {
        SAFE_FREE(cm_creds.username);
-       cm_creds.username = SMB_STRDUP(get_cmdline_auth_info_username());
+       cm_creds.username = SMB_STRDUP(get_cmdline_auth_info_username(
+                                              auth_info));
 
-       if (get_cmdline_auth_info_got_pass()) {
-               cm_set_password(get_cmdline_auth_info_password());
+       if (get_cmdline_auth_info_got_pass(auth_info)) {
+               cm_set_password(get_cmdline_auth_info_password(auth_info));
        }
 
-       cm_creds.use_kerberos = get_cmdline_auth_info_use_kerberos();
+       cm_creds.use_kerberos = get_cmdline_auth_info_use_kerberos(auth_info);
        cm_creds.fallback_after_kerberos = false;
-       cm_creds.signing_state = get_cmdline_auth_info_signing_state();
-}
-
-/****************************************************************************
-****************************************************************************/
-
-void cli_cm_set_port(int port_number)
-{
-       port = port_number;
-}
-
-/****************************************************************************
-****************************************************************************/
-
-void cli_cm_set_dest_name_type(int type)
-{
-       name_type = type;
-}
-
-/****************************************************************************
-****************************************************************************/
-
-void cli_cm_set_signing_state(int state)
-{
-       cm_creds.signing_state = state;
-}
-
-/****************************************************************************
-****************************************************************************/
-
-void cli_cm_set_username(const char *username)
-{
-       SAFE_FREE(cm_creds.username);
-       cm_creds.username = SMB_STRDUP(username);
-}
-
-/****************************************************************************
-****************************************************************************/
-
-void cli_cm_set_password(const char *newpass)
-{
-       SAFE_FREE(cm_creds.password);
-       cm_creds.password = SMB_STRDUP(newpass);
-       if (cm_creds.password) {
-               cm_creds.got_pass = true;
-       }
-}
-
-/****************************************************************************
-****************************************************************************/
-
-void cli_cm_set_use_kerberos(void)
-{
-       cm_creds.use_kerberos = true;
-}
-
-/****************************************************************************
-****************************************************************************/
-
-void cli_cm_set_fallback_after_kerberos(void)
-{
-       cm_creds.fallback_after_kerberos = true;
-}
-
-/****************************************************************************
-****************************************************************************/
-
-void cli_cm_set_dest_ss(struct sockaddr_storage *pss)
-{
-       dest_ss = *pss;
-       have_ip = true;
+       cm_creds.signing_state = get_cmdline_auth_info_signing_state(auth_info);
 }
+#endif
 
 /**********************************************************************
  split a dfs path into the server, share name, and extrapath components
 **********************************************************************/
 
-static void split_dfs_path(TALLOC_CTX *ctx,
+static bool split_dfs_path(TALLOC_CTX *ctx,
                                const char *nodepath,
                                char **pp_server,
                                char **pp_share,
@@ -574,16 +452,16 @@ static void split_dfs_path(TALLOC_CTX *ctx,
 
        path = talloc_strdup(ctx, nodepath);
        if (!path) {
-               return;
+               goto fail;
        }
 
        if ( path[0] != '\\' ) {
-               return;
+               goto fail;
        }
 
        p = strchr_m( path + 1, '\\' );
        if ( !p ) {
-               return;
+               goto fail;
        }
 
        *p = '\0';
@@ -598,9 +476,28 @@ static void split_dfs_path(TALLOC_CTX *ctx,
        } else {
                *pp_extrapath = talloc_strdup(ctx, "");
        }
+       if (*pp_extrapath == NULL) {
+               goto fail;
+       }
 
        *pp_share = talloc_strdup(ctx, p);
+       if (*pp_share == NULL) {
+               goto fail;
+       }
+
        *pp_server = talloc_strdup(ctx, &path[1]);
+       if (*pp_server == NULL) {
+               goto fail;
+       }
+
+       TALLOC_FREE(path);
+       return true;
+
+fail:
+       TALLOC_FREE(*pp_share);
+       TALLOC_FREE(*pp_extrapath);
+       TALLOC_FREE(path);
+       return false;
 }
 
 /****************************************************************************
@@ -664,32 +561,43 @@ static char *cli_dfs_make_full_path(TALLOC_CTX *ctx,
                                        struct cli_state *cli,
                                        const char *dir)
 {
+       char path_sep = '\\';
+
        /* Ensure the extrapath doesn't start with a separator. */
        while (IS_DIRECTORY_SEP(*dir)) {
                dir++;
        }
 
-       return talloc_asprintf(ctx, "\\%s\\%s\\%s",
-                       cli->desthost, cli->share, dir);
+       if (cli->requested_posix_capabilities & CIFS_UNIX_POSIX_PATHNAMES_CAP) {
+               path_sep = '/';
+       }
+       return talloc_asprintf(ctx, "%c%s%c%s%c%s",
+                       path_sep,
+                       cli_state_remote_name(cli),
+                       path_sep,
+                       cli->share,
+                       path_sep,
+                       dir);
 }
 
 /********************************************************************
  check for dfs referral
 ********************************************************************/
 
-static bool cli_dfs_check_error( struct cli_state *cli, NTSTATUS status )
+static bool cli_dfs_check_error(struct cli_state *cli, NTSTATUS expected,
+                               NTSTATUS status)
 {
-       uint32 flgs2 = SVAL(cli->inbuf,smb_flg2);
-
        /* only deal with DS when we negotiated NT_STATUS codes and UNICODE */
 
-       if (!((flgs2&FLAGS2_32_BIT_ERROR_CODES) &&
-                               (flgs2&FLAGS2_UNICODE_STRINGS)))
+       if (!(cli_state_capabilities(cli) & CAP_UNICODE)) {
                return false;
-
-       if (NT_STATUS_EQUAL(status, NT_STATUS(IVAL(cli->inbuf,smb_rcls))))
+       }
+       if (!(cli_state_capabilities(cli) & CAP_STATUS32)) {
+               return false;
+       }
+       if (NT_STATUS_EQUAL(status, expected)) {
                return true;
-
+       }
        return false;
 }
 
@@ -697,81 +605,113 @@ static bool cli_dfs_check_error( struct cli_state *cli, NTSTATUS status )
  Get the dfs referral link.
 ********************************************************************/
 
-bool cli_dfs_get_referral(TALLOC_CTX *ctx,
+NTSTATUS cli_dfs_get_referral(TALLOC_CTX *ctx,
                        struct cli_state *cli,
                        const char *path,
-                       CLIENT_DFS_REFERRAL**refs,
+                       struct client_dfs_referral **refs,
                        size_t *num_refs,
-                       uint16 *consumed)
+                       size_t *consumed)
 {
        unsigned int data_len = 0;
        unsigned int param_len = 0;
-       uint16 setup = TRANSACT2_GET_DFS_REFERRAL;
-       char *param;
-       char *rparam=NULL, *rdata=NULL;
+       uint16_t setup[1];
+       uint16_t recv_flags2;
+       uint8_t *param = NULL;
+       uint8_t *rdata = NULL;
        char *p;
        char *endp;
-       size_t pathlen = 2*(strlen(path)+1);
+       smb_ucs2_t *path_ucs;
+       char *consumed_path = NULL;
+       uint16_t consumed_ucs;
        uint16 num_referrals;
-       CLIENT_DFS_REFERRAL *referrals = NULL;
-       bool ret = false;
+       struct client_dfs_referral *referrals = NULL;
+       NTSTATUS status;
+       TALLOC_CTX *frame = talloc_stackframe();
 
        *num_refs = 0;
        *refs = NULL;
 
-       param = SMB_MALLOC_ARRAY(char, 2+pathlen+2);
+       SSVAL(setup, 0, TRANSACT2_GET_DFS_REFERRAL);
+
+       param = talloc_array(talloc_tos(), uint8_t, 2);
        if (!param) {
-               return false;
+               status = NT_STATUS_NO_MEMORY;
+               goto out;
        }
        SSVAL(param, 0, 0x03);  /* max referral level */
-       p = &param[2];
-
-       p += clistr_push(cli, p, path, pathlen, STR_TERMINATE);
-       param_len = PTR_DIFF(p, param);
-
-       if (!cli_send_trans(cli, SMBtrans2,
-                       NULL,                        /* name */
-                       -1, 0,                          /* fid, flags */
-                       &setup, 1, 0,                   /* setup, length, max */
-                       param, param_len, 2,            /* param, length, max */
-                       NULL, 0, cli->max_xmit /* data, length, max */
-                       )) {
-               SAFE_FREE(param);
-               return false;
-       }
 
-       SAFE_FREE(param);
-
-       if (!cli_receive_trans(cli, SMBtrans2,
-               &rparam, &param_len,
-               &rdata, &data_len)) {
-                       return false;
+       param = trans2_bytes_push_str(param, cli_ucs2(cli),
+                                     path, strlen(path)+1,
+                                     NULL);
+       if (!param) {
+               status = NT_STATUS_NO_MEMORY;
+               goto out;
        }
-
-       if (data_len < 4) {
+       param_len = talloc_get_size(param);
+       path_ucs = (smb_ucs2_t *)&param[2];
+
+       status = cli_trans(talloc_tos(), cli, SMBtrans2,
+                          NULL, 0xffff, 0, 0,
+                          setup, 1, 0,
+                          param, param_len, 2,
+                          NULL, 0, CLI_BUFFER_SIZE,
+                          &recv_flags2,
+                          NULL, 0, NULL, /* rsetup */
+                          NULL, 0, NULL,
+                          &rdata, 4, &data_len);
+       if (!NT_STATUS_IS_OK(status)) {
                goto out;
        }
 
-       endp = rdata + data_len;
+       endp = (char *)rdata + data_len;
 
-       *consumed     = SVAL(rdata, 0);
+       consumed_ucs  = SVAL(rdata, 0);
        num_referrals = SVAL(rdata, 2);
 
+       /* consumed_ucs is the number of bytes
+        * of the UCS2 path consumed not counting any
+        * terminating null. We need to convert
+        * back to unix charset and count again
+        * to get the number of bytes consumed from
+        * the incoming path. */
+
+       errno = 0;
+       if (pull_string_talloc(talloc_tos(),
+                       NULL,
+                       0,
+                       &consumed_path,
+                       path_ucs,
+                       consumed_ucs,
+                       STR_UNICODE) == 0) {
+               if (errno != 0) {
+                       status = map_nt_error_from_unix(errno);
+               } else {
+                       status = NT_STATUS_INVALID_NETWORK_RESPONSE;
+               }
+               goto out;
+       }
+       if (consumed_path == NULL) {
+               status = map_nt_error_from_unix(errno);
+               goto out;
+       }
+       *consumed = strlen(consumed_path);
+
        if (num_referrals != 0) {
                uint16 ref_version;
                uint16 ref_size;
                int i;
                uint16 node_offset;
 
-               referrals = TALLOC_ARRAY(ctx, CLIENT_DFS_REFERRAL,
-                               num_referrals);
+               referrals = talloc_array(ctx, struct client_dfs_referral,
+                                        num_referrals);
 
                if (!referrals) {
+                       status = NT_STATUS_NO_MEMORY;
                        goto out;
                }
                /* start at the referrals array */
 
-               p = rdata+8;
+               p = (char *)rdata+8;
                for (i=0; i<num_referrals && p < endp; i++) {
                        if (p + 18 > endp) {
                                goto out;
@@ -789,47 +729,52 @@ bool cli_dfs_get_referral(TALLOC_CTX *ctx,
                        referrals[i].ttl       = SVAL(p, 10);
 
                        if (p + node_offset > endp) {
+                               status = NT_STATUS_INVALID_NETWORK_RESPONSE;
                                goto out;
                        }
-                       clistr_pull_talloc(ctx, cli, &referrals[i].dfspath,
-                               p+node_offset, -1,
-                               STR_TERMINATE|STR_UNICODE );
+                       clistr_pull_talloc(referrals,
+                                          (const char *)rdata,
+                                          recv_flags2,
+                                          &referrals[i].dfspath,
+                                          p+node_offset,
+                                          PTR_DIFF(endp, p+node_offset),
+                                          STR_TERMINATE|STR_UNICODE);
 
                        if (!referrals[i].dfspath) {
+                               status = map_nt_error_from_unix(errno);
                                goto out;
                        }
                        p += ref_size;
                }
                if (i < num_referrals) {
+                       status = NT_STATUS_INVALID_NETWORK_RESPONSE;
                        goto out;
                }
        }
 
-       ret = true;
-
        *num_refs = num_referrals;
        *refs = referrals;
 
   out:
 
-       SAFE_FREE(rdata);
-       SAFE_FREE(rparam);
-       return ret;
+       TALLOC_FREE(frame);
+       return status;
 }
 
 /********************************************************************
 ********************************************************************/
 
-bool cli_resolve_path(TALLOC_CTX *ctx,
-                       const char *mountpt,
-                       struct cli_state *rootcli,
-                       const char *path,
-                       struct cli_state **targetcli,
-                       char **pp_targetpath)
+NTSTATUS cli_resolve_path(TALLOC_CTX *ctx,
+                         const char *mountpt,
+                         const struct user_auth_info *dfs_auth_info,
+                         struct cli_state *rootcli,
+                         const char *path,
+                         struct cli_state **targetcli,
+                         char **pp_targetpath)
 {
-       CLIENT_DFS_REFERRAL *refs = NULL;
+       struct client_dfs_referral *refs = NULL;
        size_t num_refs = 0;
-       uint16 consumed;
+       size_t consumed = 0;
        struct cli_state *cli_ipc = NULL;
        char *dfs_path = NULL;
        char *cleanpath = NULL;
@@ -843,9 +788,10 @@ bool cli_resolve_path(TALLOC_CTX *ctx,
        char *ppath = NULL;
        SMB_STRUCT_STAT sbuf;
        uint32 attributes;
+       NTSTATUS status;
 
        if ( !rootcli || !path || !targetcli ) {
-               return false;
+               return NT_STATUS_INVALID_PARAMETER;
        }
 
        /* Don't do anything if this is not a DFS root. */
@@ -854,9 +800,9 @@ bool cli_resolve_path(TALLOC_CTX *ctx,
                *targetcli = rootcli;
                *pp_targetpath = talloc_strdup(ctx, path);
                if (!*pp_targetpath) {
-                       return false;
+                       return NT_STATUS_NO_MEMORY;
                }
-               return true;
+               return NT_STATUS_OK;
        }
 
        *targetcli = NULL;
@@ -865,79 +811,90 @@ bool cli_resolve_path(TALLOC_CTX *ctx,
 
        cleanpath = clean_path(ctx, path);
        if (!cleanpath) {
-               return false;
+               return NT_STATUS_NO_MEMORY;
        }
 
        dfs_path = cli_dfs_make_full_path(ctx, rootcli, cleanpath);
        if (!dfs_path) {
-               return false;
+               return NT_STATUS_NO_MEMORY;
        }
 
-       if (cli_qpathinfo_basic( rootcli, dfs_path, &sbuf, &attributes)) {
+       status = cli_qpathinfo_basic( rootcli, dfs_path, &sbuf, &attributes);
+       if (NT_STATUS_IS_OK(status)) {
                /* This is an ordinary path, just return it. */
                *targetcli = rootcli;
                *pp_targetpath = talloc_strdup(ctx, path);
                if (!*pp_targetpath) {
-                       return false;
+                       return NT_STATUS_NO_MEMORY;
                }
                goto done;
        }
 
        /* Special case where client asked for a path that does not exist */
 
-       if (cli_dfs_check_error(rootcli, NT_STATUS_OBJECT_NAME_NOT_FOUND)) {
+       if (cli_dfs_check_error(rootcli, NT_STATUS_OBJECT_NAME_NOT_FOUND,
+                               status)) {
                *targetcli = rootcli;
                *pp_targetpath = talloc_strdup(ctx, path);
                if (!*pp_targetpath) {
-                       return false;
+                       return NT_STATUS_NO_MEMORY;
                }
                goto done;
        }
 
        /* We got an error, check for DFS referral. */
 
-       if (!cli_dfs_check_error(rootcli, NT_STATUS_PATH_NOT_COVERED)) {
-               return false;
+       if (!cli_dfs_check_error(rootcli, NT_STATUS_PATH_NOT_COVERED,
+                                status)) {
+               return status;
        }
 
        /* Check for the referral. */
 
-       if (!(cli_ipc = cli_cm_open(ctx, rootcli,
-                                       rootcli->desthost,
-                                       "IPC$", false,
-                                       (rootcli->trans_enc_state != NULL)))) {
-               return false;
+       status = cli_cm_open(ctx,
+                            rootcli,
+                            cli_state_remote_name(rootcli),
+                            "IPC$",
+                            dfs_auth_info,
+                            false,
+                            cli_state_encryption_on(rootcli),
+                            cli_state_protocol(rootcli),
+                            0,
+                            0x20,
+                            &cli_ipc);
+       if (!NT_STATUS_IS_OK(status)) {
+               return status;
        }
 
-       if (!cli_dfs_get_referral(ctx, cli_ipc, dfs_path, &refs,
-                       &num_refs, &consumed) || !num_refs) {
-               return false;
+       status = cli_dfs_get_referral(ctx, cli_ipc, dfs_path, &refs,
+                                     &num_refs, &consumed);
+       if (!NT_STATUS_IS_OK(status) || !num_refs) {
+               return status;
        }
 
        /* Just store the first referral for now. */
 
        if (!refs[0].dfspath) {
-               return false;
+               return NT_STATUS_NOT_FOUND;
        }
-       split_dfs_path(ctx, refs[0].dfspath, &server, &share, &extrapath );
-
-       if (!server || !share) {
-               return false;
+       if (!split_dfs_path(ctx, refs[0].dfspath, &server, &share,
+                           &extrapath)) {
+               return NT_STATUS_NOT_FOUND;
        }
 
        /* Make sure to recreate the original string including any wildcards. */
 
        dfs_path = cli_dfs_make_full_path(ctx, rootcli, path);
        if (!dfs_path) {
-               return false;
+               return NT_STATUS_NO_MEMORY;
        }
-       pathlen = strlen(dfs_path)*2;
+       pathlen = strlen(dfs_path);
        consumed = MIN(pathlen, consumed);
-       *pp_targetpath = talloc_strdup(ctx, &dfs_path[consumed/2]);
+       *pp_targetpath = talloc_strdup(ctx, &dfs_path[consumed]);
        if (!*pp_targetpath) {
-               return false;
+               return NT_STATUS_NO_MEMORY;
        }
-       dfs_path[consumed/2] = '\0';
+       dfs_path[consumed] = '\0';
 
        /*
         * *pp_targetpath is now the unconsumed part of the path.
@@ -946,23 +903,38 @@ bool cli_resolve_path(TALLOC_CTX *ctx,
         */
 
        /* Open the connection to the target server & share */
-       if ((*targetcli = cli_cm_open(ctx, rootcli,
-                                       server,
-                                       share,
-                                       false,
-                                       (rootcli->trans_enc_state != NULL))) == NULL) {
+       status = cli_cm_open(ctx, rootcli,
+                            server,
+                            share,
+                            dfs_auth_info,
+                            false,
+                            cli_state_encryption_on(rootcli),
+                            cli_state_protocol(rootcli),
+                            0,
+                            0x20,
+                            targetcli);
+       if (!NT_STATUS_IS_OK(status)) {
                d_printf("Unable to follow dfs referral [\\%s\\%s]\n",
                        server, share );
-               return false;
+               return status;
        }
 
        if (extrapath && strlen(extrapath) > 0) {
-               *pp_targetpath = talloc_asprintf(ctx,
-                                               "%s%s",
-                                               extrapath,
-                                               *pp_targetpath);
+               /* EMC Celerra NAS version 5.6.50 (at least) doesn't appear to */
+               /* put the trailing \ on the path, so to be save we put one in if needed */
+               if (extrapath[strlen(extrapath)-1] != '\\' && **pp_targetpath != '\\') {
+                       *pp_targetpath = talloc_asprintf(ctx,
+                                                 "%s\\%s",
+                                                 extrapath,
+                                                 *pp_targetpath);
+               } else {
+                       *pp_targetpath = talloc_asprintf(ctx,
+                                                 "%s%s",
+                                                 extrapath,
+                                                 *pp_targetpath);
+               }
                if (!*pp_targetpath) {
-                       return false;
+                       return NT_STATUS_NO_MEMORY;
                }
        }
 
@@ -975,40 +947,42 @@ bool cli_resolve_path(TALLOC_CTX *ctx,
                d_printf("cli_resolve_path: "
                        "dfs_path (%s) not in correct format.\n",
                        dfs_path );
-               return false;
+               return NT_STATUS_NOT_FOUND;
        }
 
        ppath++; /* Now pointing at start of server name. */
 
        if ((ppath = strchr_m( dfs_path, '\\' )) == NULL) {
-               return false;
+               return NT_STATUS_NOT_FOUND;
        }
 
        ppath++; /* Now pointing at start of share name. */
 
        if ((ppath = strchr_m( ppath+1, '\\' )) == NULL) {
-               return false;
+               return NT_STATUS_NOT_FOUND;
        }
 
        ppath++; /* Now pointing at path component. */
 
        newmount = talloc_asprintf(ctx, "%s\\%s", mountpt, ppath );
        if (!newmount) {
-               return false;
+               return NT_STATUS_NOT_FOUND;
        }
 
-       cli_cm_set_mntpoint(*targetcli, newmount);
+       cli_set_mntpoint(*targetcli, newmount);
 
        /* Check for another dfs referral, note that we are not
           checking for loops here. */
 
        if (!strequal(*pp_targetpath, "\\") && !strequal(*pp_targetpath, "/")) {
-               if (cli_resolve_path(ctx,
-                                       newmount,
-                                       *targetcli,
-                                       *pp_targetpath,
-                                       &newcli,
-                                       &newpath)) {
+               status = cli_resolve_path(ctx,
+                                         newmount,
+                                         dfs_auth_info,
+                                         *targetcli,
+                                         *pp_targetpath,
+                                         &newcli,
+                                         &newpath);
+               if (NT_STATUS_IS_OK(status)) {
                        /*
                         * When cli_resolve_path returns true here it's always
                         * returning the complete path in newpath, so we're done
@@ -1016,7 +990,7 @@ bool cli_resolve_path(TALLOC_CTX *ctx,
                         */
                        *targetcli = newcli;
                        *pp_targetpath = newpath;
-                       return true;
+                       return status;
                }
        }
 
@@ -1026,18 +1000,21 @@ bool cli_resolve_path(TALLOC_CTX *ctx,
        if ((*targetcli)->dfsroot) {
                dfs_path = talloc_strdup(ctx, *pp_targetpath);
                if (!dfs_path) {
-                       return false;
+                       return NT_STATUS_NO_MEMORY;
                }
                *pp_targetpath = cli_dfs_make_full_path(ctx, *targetcli, dfs_path);
+               if (*pp_targetpath == NULL) {
+                       return NT_STATUS_NO_MEMORY;
+               }
        }
 
-       return true;
+       return NT_STATUS_OK;
 }
 
 /********************************************************************
 ********************************************************************/
 
-static bool cli_check_msdfs_proxy(TALLOC_CTX *ctx,
+bool cli_check_msdfs_proxy(TALLOC_CTX *ctx,
                                struct cli_state *cli,
                                const char *sharename,
                                char **pp_newserver,
@@ -1047,19 +1024,22 @@ static bool cli_check_msdfs_proxy(TALLOC_CTX *ctx,
                                const char *password,
                                const char *domain)
 {
-       CLIENT_DFS_REFERRAL *refs = NULL;
+       struct client_dfs_referral *refs = NULL;
        size_t num_refs = 0;
-       uint16 consumed;
+       size_t consumed = 0;
        char *fullpath = NULL;
        bool res;
        uint16 cnum;
        char *newextrapath = NULL;
+       NTSTATUS status;
+       const char *remote_name;
 
        if (!cli || !sharename) {
                return false;
        }
 
-       cnum = cli->cnum;
+       remote_name = cli_state_remote_name(cli);
+       cnum = cli_state_get_tid(cli);
 
        /* special case.  never check for a referral on the IPC$ share */
 
@@ -1069,19 +1049,19 @@ static bool cli_check_msdfs_proxy(TALLOC_CTX *ctx,
 
        /* send a trans2_query_path_info to check for a referral */
 
-       fullpath = talloc_asprintf(ctx, "\\%s\\%s", cli->desthost, sharename );
+       fullpath = talloc_asprintf(ctx, "\\%s\\%s", remote_name, sharename);
        if (!fullpath) {
                return false;
        }
 
        /* check for the referral */
 
-       if (!cli_send_tconX(cli, "IPC$", "IPC", NULL, 0)) {
+       if (!NT_STATUS_IS_OK(cli_tcon_andx(cli, "IPC$", "IPC", NULL, 0))) {
                return false;
        }
 
        if (force_encrypt) {
-               NTSTATUS status = cli_cm_force_encryption(cli,
+               status = cli_cm_force_encryption(cli,
                                        username,
                                        password,
                                        lp_workgroup(),
@@ -1091,13 +1071,16 @@ static bool cli_check_msdfs_proxy(TALLOC_CTX *ctx,
                }
        }
 
-       res = cli_dfs_get_referral(ctx, cli, fullpath, &refs, &num_refs, &consumed);
+       status = cli_dfs_get_referral(ctx, cli, fullpath, &refs,
+                                     &num_refs, &consumed);
+       res = NT_STATUS_IS_OK(status);
 
-       if (!cli_tdis(cli)) {
+       status = cli_tdis(cli);
+       if (!NT_STATUS_IS_OK(status)) {
                return false;
        }
 
-       cli->cnum = cnum;
+       cli_state_set_tid(cli, cnum);
 
        if (!res || !num_refs) {
                return false;
@@ -1107,16 +1090,14 @@ static bool cli_check_msdfs_proxy(TALLOC_CTX *ctx,
                return false;
        }
 
-       split_dfs_path(ctx, refs[0].dfspath, pp_newserver,
-                       pp_newshare, &newextrapath );
-
-       if ((*pp_newserver == NULL) || (*pp_newshare == NULL)) {
+       if (!split_dfs_path(ctx, refs[0].dfspath, pp_newserver,
+                           pp_newshare, &newextrapath)) {
                return false;
        }
 
        /* check that this is not a self-referral */
 
-       if (strequal(cli->desthost, *pp_newserver) &&
+       if (strequal(remote_name, *pp_newserver) &&
                        strequal(sharename, *pp_newshare)) {
                return false;
        }