s3:nmbd: as the sig_term() handler only sets a flag we don't need to block SIGTERM
[metze/samba/wip.git] / source3 / nmbd / nmbd.c
index 344831ddca77cd2ed37ae908da01d1ce6098e69e..1b26c0a5ada8e01878141ab2b584b1fce12e1fb4 100644 (file)
@@ -52,9 +52,12 @@ struct messaging_context *nmbd_messaging_context(void)
 {
        static struct messaging_context *ctx;
 
-       if (!ctx && !(ctx = messaging_init(NULL, server_id_self(),
-                                          nmbd_event_context()))) {
-               smb_panic("Could not init nmbd messaging context");
+       if (ctx == NULL) {
+               ctx = messaging_init(NULL, server_id_self(),
+                                    nmbd_event_context());
+       }
+       if (ctx == NULL) {
+               DEBUG(0, ("Could not init nmbd messaging context.\n"));
        }
        return ctx;
 }
@@ -163,18 +166,27 @@ static void expire_names_and_servers(time_t t)
 
 /************************************************************************** **
  Reload the list of network interfaces.
+ Doesn't return until a network interface is up.
  ************************************************************************** */
 
-static bool reload_interfaces(time_t t)
+static void reload_interfaces(time_t t)
 {
        static time_t lastt;
        int n;
+       bool print_waiting_msg = true;
        struct subnet_record *subrec;
 
-       if (t && ((t - lastt) < NMBD_INTERFACES_RELOAD)) return False;
+       if (t && ((t - lastt) < NMBD_INTERFACES_RELOAD)) {
+               return;
+       }
+
        lastt = t;
 
-       if (!interfaces_changed()) return False;
+       if (!interfaces_changed()) {
+               return;
+       }
+
+  try_again:
 
        /* the list of probed interfaces has changed, we may need to add/remove
           some subnets */
@@ -207,7 +219,7 @@ static bool reload_interfaces(time_t t)
                 * ignore it here. JRA.
                 */
 
-               if (is_loopback_addr(&iface->ip)) {
+               if (is_loopback_addr((struct sockaddr *)&iface->ip)) {
                        DEBUG(2,("reload_interfaces: Ignoring loopback "
                                "interface %s\n",
                                print_sockaddr(str, sizeof(str), &iface->ip) ));
@@ -268,12 +280,36 @@ static bool reload_interfaces(time_t t)
 
        rescan_listen_set = True;
 
-       /* We need to shutdown if there are no subnets... */
+       /* We need to wait if there are no subnets... */
        if (FIRST_SUBNET == NULL) {
-               DEBUG(0,("reload_interfaces: No subnets to listen to. Shutting down...\n"));
-               return True;
+               void (*saved_handler)(int);
+
+               if (print_waiting_msg) {
+                       DEBUG(0,("reload_interfaces: "
+                               "No subnets to listen to. Waiting..\n"));
+                       print_waiting_msg = false;
+               }
+
+               /*
+                * Whilst we're waiting for an interface, allow SIGTERM to
+                * cause us to exit.
+                */
+               saved_handler = CatchSignal( SIGTERM, SIGNAL_CAST SIG_DFL );
+
+               /* We only count IPv4, non-loopback interfaces here. */
+               while (iface_count_v4_nl() == 0) {
+                       sleep(5);
+                       load_interfaces();
+               }
+
+               CatchSignal( SIGTERM, SIGNAL_CAST saved_handler );
+
+               /*
+                * We got an interface, go back to blocking term.
+                */
+
+               goto try_again;
        }
-       return False;
 }
 
 /**************************************************************************** **
@@ -288,7 +324,7 @@ static bool reload_nmbd_services(bool test)
 
        if ( lp_loaded() ) {
                const char *fname = lp_configfile();
-               if (file_exist(fname,NULL) && !strcsequal(fname,get_dyn_CONFIGFILE())) {
+               if (file_exist(fname) && !strcsequal(fname,get_dyn_CONFIGFILE())) {
                        set_dyn_CONFIGFILE(fname);
                        test = False;
                }
@@ -310,8 +346,6 @@ static bool reload_nmbd_services(bool test)
 
 /**************************************************************************** **
  * React on 'smbcontrol nmbd reload-config' in the same way as to SIGHUP
- * We use buf here to return bool result to process() when reload_interfaces()
- * detects that there are no subnets.
  **************************************************************************** */
 
 static void msg_reload_nmbd_services(struct messaging_context *msg,
@@ -324,14 +358,7 @@ static void msg_reload_nmbd_services(struct messaging_context *msg,
        dump_all_namelists();
        reload_nmbd_services( True );
        reopen_logs();
-       
-       if (data->data) {
-               /* We were called from process() */
-               /* If reload_interfaces() returned True */
-               /* we need to shutdown if there are no subnets... */
-               /* pass this info back to process() */
-               *((bool *)data->data) = reload_interfaces(0);  
-       }
+       reload_interfaces(0);
 }
 
 static void msg_nmbd_send_packet(struct messaging_context *msg,
@@ -362,7 +389,7 @@ static void msg_nmbd_send_packet(struct messaging_context *msg,
        }
 
        in_addr_to_sockaddr_storage(&ss, p->ip);
-       pss = iface_ip(&ss);
+       pss = iface_ip((struct sockaddr *)&ss);
 
        if (pss == NULL) {
                DEBUG(2, ("Could not find ip for packet from %d\n",
@@ -401,16 +428,11 @@ static void msg_nmbd_send_packet(struct messaging_context *msg,
 static void process(void)
 {
        bool run_election;
-       bool no_subnets;
 
        while( True ) {
                time_t t = time(NULL);
                TALLOC_CTX *frame = talloc_stackframe();
 
-               /* Check for internal messages */
-
-               message_dispatch(nmbd_messaging_context());
-
                /*
                 * Check all broadcast subnets to see if
                 * we need to run an election on any of them.
@@ -612,26 +634,17 @@ static void process(void)
                 */
 
                if(reload_after_sighup) {
-                       DATA_BLOB blob = data_blob_const(&no_subnets,
-                                                        sizeof(no_subnets));
                        DEBUG( 0, ( "Got SIGHUP dumping debug info.\n" ) );
                        msg_reload_nmbd_services(nmbd_messaging_context(),
                                                 NULL, MSG_SMB_CONF_UPDATED,
-                                                procid_self(), &blob);
+                                                procid_self(), NULL);
 
-                       if(no_subnets) {
-                               TALLOC_FREE(frame);
-                               return;
-                       }
                        reload_after_sighup = 0;
                }
 
                /* check for new network interfaces */
 
-               if(reload_interfaces(t)) {
-                       TALLOC_FREE(frame);
-                       return;
-               }
+               reload_interfaces(t);
 
                /* free up temp memory */
                TALLOC_FREE(frame);
@@ -676,11 +689,18 @@ static bool open_sockets(bool isdaemon, int port)
                ClientNMB = 0;
        }
 
+       if (ClientNMB == -1) {
+               return false;
+       }
+
        ClientDGRAM = open_socket_in(SOCK_DGRAM, DGRAM_PORT,
                                           3, &ss,
                                           true);
 
-       if (ClientNMB == -1) {
+       if (ClientDGRAM == -1) {
+               if (ClientNMB != 0) {
+                       close(ClientNMB);
+               }
                return false;
        }
 
@@ -771,12 +791,12 @@ static bool open_sockets(bool isdaemon, int port)
        sys_srandom(time(NULL) ^ sys_getpid());
        
        if (!override_logfile) {
-               char *logfile = NULL;
-               if (asprintf(&logfile, "%s/log.nmbd", get_dyn_LOGFILEBASE()) < 0) {
+               char *lfile = NULL;
+               if (asprintf(&lfile, "%s/log.nmbd", get_dyn_LOGFILEBASE()) < 0) {
                        exit(1);
                }
-               lp_set_logfile(logfile);
-               SAFE_FREE(logfile);
+               lp_set_logfile(lfile);
+               SAFE_FREE(lfile);
        }
        
        fault_setup((void (*)(void *))fault_continue );
@@ -815,9 +835,18 @@ static bool open_sockets(bool isdaemon, int port)
 
        reopen_logs();
 
-       DEBUG(0,("nmbd version %s started.\n", SAMBA_VERSION_STRING));
+       DEBUG(0,("nmbd version %s started.\n", samba_version_string()));
        DEBUGADD(0,("%s\n", COPYRIGHT_STARTUP_MESSAGE));
 
+       if (!lp_load_initial_only(get_dyn_CONFIGFILE())) {
+               DEBUG(0, ("error opening config file\n"));
+               exit(1);
+       }
+
+       if (nmbd_messaging_context() == NULL) {
+               return 1;
+       }
+
        if ( !reload_nmbd_services(False) )
                return(-1);
 
@@ -864,11 +893,21 @@ static bool open_sockets(bool isdaemon, int port)
        }
 #endif
 
-       if (!directory_exist(lp_lockdir(), NULL)) {
+       if (!directory_exist(lp_lockdir())) {
                mkdir(lp_lockdir(), 0755);
        }
 
        pidfile_create("nmbd");
+
+       if (!reinit_after_fork(nmbd_messaging_context(),
+                              nmbd_event_context(), false)) {
+               DEBUG(0,("reinit_after_fork() failed\n"));
+               exit(1);
+       }
+
+       /* get broadcast messages */
+       claim_connection(NULL,"",FLAG_MSG_GENERAL|FLAG_MSG_DBWRAP);
+
        messaging_register(nmbd_messaging_context(), NULL,
                           MSG_FORCE_ELECTION, nmbd_message_election);
 #if 0
@@ -930,9 +969,6 @@ static bool open_sockets(bool isdaemon, int port)
                exit(1);
        }
 
-       /* We can only take signals in the select. */
-       BlockSignals( True, SIGTERM );
-
        TALLOC_FREE(frame);
        process();