getnc_exop.py: Fix GET_TGT behaviour in DRS tests
authorTim Beale <timbeale@catalyst.net.nz>
Tue, 23 May 2017 02:37:56 +0000 (14:37 +1200)
committerGarming Sam <garming@samba.org>
Mon, 18 Sep 2017 03:51:24 +0000 (05:51 +0200)
commit172eedc0760b5d471af091c2f08ea70f17b36293
treece21dae6d8f130f451d80facb7cfcd80a95cae9d
parentaf38d73b06c0c40ef59c2ffe0fc6580b0787b7d0
getnc_exop.py: Fix GET_TGT behaviour in DRS tests

The existing code never passed the more_flags parameter into the
actual getNCChanges request, i.e. _getnc_req10(). This meant the
existing GET_TGT tests effectively did nothing.

Passing the flag through properly means we have to now change the tests
as the DNs returned by Windows now include any target objects in the
linked attributes. These tests now fail against Samba (because it
doesn't support GET_TGT yet).

Also added comments to the tests to help explain what they are actually
doing.

Note that Samba and Windows can return the objects in different orders,
due to significant differences in their underlying DB implementations
(Windows stores links in a separate DB, so sends links ordered strictly
by USN, whereas Samba sends links based on the USN of the source
object). To make the test a fair comparison between Windows and Samba,
we need to use dn_ordered=False.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
selftest/knownfail.d/getnc_exop [new file with mode: 0644]
source4/torture/drs/python/drs_base.py
source4/torture/drs/python/getnc_exop.py