libcli/auth/ntlmssp Be clear about talloc parents for session keys
authorAndrew Bartlett <abartlet@samba.org>
Thu, 16 Sep 2010 04:37:20 +0000 (14:37 +1000)
committerAndrew Tridgell <tridge@samba.org>
Thu, 16 Sep 2010 11:09:17 +0000 (21:09 +1000)
commit6832d5e9334f93d2b41fa50580379a2381311748
treec4cb065d6ca93f4f367a2329b14a6eac90d163af
parentd5a4e53ad8dd572b9469530dfcd37601e2905a88
libcli/auth/ntlmssp Be clear about talloc parents for session keys

The previous API was not clear as to who owned the returned session key.
This fixes a valgrind-found use-after-free in the NTLMSSP key derivation code,
and avoids making allocations - we steal and zero instead.

Andrew Bartlett

Signed-off-by: Andrew Tridgell <tridge@samba.org>
libcli/auth/ntlmssp.h
libcli/auth/ntlmssp_server.c
source3/auth/auth_ntlmssp.c
source3/smbd/sesssetup.c
source3/utils/ntlm_auth.c
source4/auth/ntlmssp/ntlmssp_server.c