s4:lsa_lookup: remove TALLOC_FREE(state) after all dcesrv_lsa_Lookup{Names,Sids}_base...
authorStefan Metzmacher <metze@samba.org>
Fri, 11 May 2018 04:43:14 +0000 (06:43 +0200)
committerAndrew Bartlett <abartlet@samba.org>
Sun, 13 May 2018 08:27:28 +0000 (10:27 +0200)
commit9a513304adadd79d1c63d55fcf06b67ed45d43ba
tree8ddf26723583393056704d38ff259a460a49f187
parent26c4084ad2d5f35d4e35026c96150759d062969a
s4:lsa_lookup: remove TALLOC_FREE(state) after all dcesrv_lsa_Lookup{Names,Sids}_base_map() calls

This completes the regression fix of commit 7e091e505156381e385235ab4518b4d133a98497.

There might be strings allocated on state, which are part of the
result.

The reason for the TALLOC_FREE(state) was to cleanup the possible
irpc_handle before leaving the function. Now we call
TALLOC_FREE(state->wb.irpc_handle) explicitly in
dcesrv_lsa_Lookup{Names,Sids}_base_done() instead.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13420

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Sun May 13 10:27:28 CEST 2018 on sn-devel-144
source4/rpc_server/lsa/lsa_lookup.c