s4:http/gensec: add missing tevent_req_done() to gensec_http_ntlm_update_done()
authorStefan Metzmacher <metze@samba.org>
Thu, 20 Jul 2017 09:56:21 +0000 (11:56 +0200)
committerStefan Metzmacher <metze@samba.org>
Fri, 21 Jul 2017 14:23:48 +0000 (16:23 +0200)
commita06ae5fc7ee5d061e39401ed945d31ebcf6e9efb
tree825bbec6204949f92336223809b23e58252412b0
parent5cb0d0a0a56f5a2fec6a77b0f8fec8fab8ea2a9e
s4:http/gensec: add missing tevent_req_done() to gensec_http_ntlm_update_done()

This was missing in commit d718e92d5e145dccd492c46febc249e462ce50c6.

Sadly we can't have automated tests for this as we only implement
the client side for this protocol.

I've tested with using:

bin/smbtorture \
  -W BLA --realm=BLA.BASE \
  -s /dev/null -Uadministrator%A1b2C3d4 \
  ncacn_http:w2k8r2-219[593,RpcProxy=w2k8r2-219.bla.base,HttpUseTls=false,HttpAuthOption=basic] \
  rpc.epmapper.epmapper.Lookup_simple \

and:

bin/smbtorture \
  -W BLA --realm=BLA.BASE \
  -s /dev/null -Uadministrator%A1b2C3d4 \
  ncacn_http:w2k8r2-219[593,RpcProxy=w2k8r2-219.bla.base,HttpUseTls=false,HttpAuthOption=ntlm] \
  rpc.epmapper.epmapper.Lookup_simple \

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12919

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
source4/lib/http/gensec/ntlm.c