git.samba.org / metze / samba / wip.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 0dd2152) | patch
s4-ldapcmp: fixed exception handling
authorAndrew Tridgell <tridge@samba.org>
Mon, 29 Nov 2010 02:30:46 +0000 (13:30 +1100)
committerAndrew Tridgell <tridge@samba.org>
Mon, 29 Nov 2010 07:04:42 +0000 (18:04 +1100)
commitf8d73e466b454a63f256021ad2f353e9ad93e8f7
tree929cc112ed8917e121da5a433ec1e144a588a30ctree
parent0dd2152b01b93b2a09ea0332ba60e2e0338b1c15commit | diff
s4-ldapcmp: fixed exception handling

This pattern, which is common in our code, is wrong:
            except LdbError, (ERR_NO_SUCH_OBJECT, _):

what it actually does it to change the value of ldb.ERR_NO_SUCH_OBJECT
to be equal to whatever ldb error occurred! This led to some really
bizarre behavior
source4/scripting/devel/ldapcmp diff | blob | history
Work in progress branches