From: Jeremy Allison <jra@samba.org>
Date: Fri, 30 Jan 2009 01:31:12 +0000 (-0800)
Subject: Fix coverity CID#116. Resource leak on error path.
X-Git-Url: http://git.samba.org/?p=metze%2Fsamba%2Fwip.git;a=commitdiff_plain;h=08802db8dbbbf842b7c006e5ff57ba1c2d0d6439

Fix coverity CID#116. Resource leak on error path.
Jeremy.
---

diff --git a/source3/libnet/libnet_samsync_ldif.c b/source3/libnet/libnet_samsync_ldif.c
index 428633189357..cee0e17e37bd 100644
--- a/source3/libnet/libnet_samsync_ldif.c
+++ b/source3/libnet/libnet_samsync_ldif.c
@@ -542,8 +542,10 @@ static NTSTATUS fetch_group_info_to_ldif(TALLOC_CTX *mem_ctx,
 	groupmap->sambaSID	= talloc_asprintf(mem_ctx, "%s-%d", sid, g_rid);
 	groupmap->group_dn	= talloc_asprintf(mem_ctx,
 	     "cn=%s,ou=%s,%s", groupname, group_attr, suffix);
-	NT_STATUS_HAVE_NO_MEMORY(groupmap->sambaSID);
-	NT_STATUS_HAVE_NO_MEMORY(groupmap->group_dn);
+	if (groupmap->sambaSID == NULL || groupmap->group_dn == NULL) {
+		SAFE_FREE(group_attr);
+		return NT_STATUS_NO_MEMORY;
+	}
 
 	/* Write the data to the temporary add ldif file */
 	fprintf(add_fd, "# %s, %s, %s\n", groupname, group_attr,