From: Jeremy Allison Date: Mon, 14 May 2018 18:09:53 +0000 (-0700) Subject: smbd: fileserver: Change defaults to work with EA support out of the box. X-Git-Url: http://git.samba.org/?p=metze%2Fsamba%2Fwip.git;a=commitdiff_plain;h=506c520503eacff33064c1c23a068399f7296d86 smbd: fileserver: Change defaults to work with EA support out of the box. Signed-off-by: Jeremy Allison Reviewed-by: Volker Lendecke Autobuild-User(master): Volker Lendecke Autobuild-Date(master): Tue May 15 12:40:48 CEST 2018 on sn-devel-144 --- diff --git a/WHATSNEW.txt b/WHATSNEW.txt index 7bd37927160e..574e9b27e68d 100644 --- a/WHATSNEW.txt +++ b/WHATSNEW.txt @@ -61,9 +61,16 @@ REMOVED FEATURES smb.conf changes ================ +As the most popular Samba install platforms (Linux and FreeBSD) both +support extended attributes by default, the parameters "map readonly", +"store dos attributes" and "ea support" have had their defaults changed +to allow better Windows fileserver compatibility in a default install. + Parameter Name Description Default -------------- ----------- ------- - + map readonly Default changed no + store dos attributes Default changed yes + ea support Default changed yes KNOWN ISSUES ============ diff --git a/docs-xml/smbdotconf/filename/mapreadonly.xml b/docs-xml/smbdotconf/filename/mapreadonly.xml index 54a5e01ce399..dae17c25614f 100644 --- a/docs-xml/smbdotconf/filename/mapreadonly.xml +++ b/docs-xml/smbdotconf/filename/mapreadonly.xml @@ -49,6 +49,13 @@ attribute. + + The default has changed to no in Samba release 4.9.0 and above to allow better Windows + fileserver compatibility in a default install. In addition the default setting of + has been changed to Yes + in Samba release 4.9.0 and above. + + -yes +no diff --git a/docs-xml/smbdotconf/filename/storedosattributes.xml b/docs-xml/smbdotconf/filename/storedosattributes.xml index 30665eb500ce..2cdaeef9c6d2 100644 --- a/docs-xml/smbdotconf/filename/storedosattributes.xml +++ b/docs-xml/smbdotconf/filename/storedosattributes.xml @@ -21,7 +21,10 @@ extended attribute by earlier versions of Samba, but they will not be able to read the create time stored there. Storing the create time separately from the normal filesystem meta-data allows Samba to faithfully reproduce NTFS semantics on top of a POSIX filesystem. + + The default has changed to yes in Samba release 4.9.0 and above to allow better Windows + fileserver compatibility in a default install. -no +yes diff --git a/docs-xml/smbdotconf/protocol/easupport.xml b/docs-xml/smbdotconf/protocol/easupport.xml index b453b86d78ae..403e48f5a897 100644 --- a/docs-xml/smbdotconf/protocol/easupport.xml +++ b/docs-xml/smbdotconf/protocol/easupport.xml @@ -24,8 +24,11 @@ access to this tight space via extended attribute support could consume all of it by unsuspecting client applications, which would prevent changing system metadata due to lack of space. + + The default has changed to yes in Samba release 4.9.0 and above to allow better Windows + fileserver compatibility in a default install. -no +yes diff --git a/lib/param/loadparm.c b/lib/param/loadparm.c index bcb41419e1c8..3b7f8053e4ae 100644 --- a/lib/param/loadparm.c +++ b/lib/param/loadparm.c @@ -2880,7 +2880,7 @@ struct loadparm_context *loadparm_init(TALLOC_CTX *mem_ctx) lpcfg_do_global_parameter(lp_ctx, "strict sync", "yes"); - lpcfg_do_global_parameter(lp_ctx, "map readonly", "yes"); + lpcfg_do_global_parameter(lp_ctx, "map readonly", "no"); lpcfg_do_global_parameter(lp_ctx, "allow trusted domains", "yes"); @@ -3000,6 +3000,10 @@ struct loadparm_context *loadparm_init(TALLOC_CTX *mem_ctx) lpcfg_do_global_parameter(lp_ctx, "check parent directory delete on close", "no"); + lpcfg_do_global_parameter(lp_ctx, "ea support", "yes"); + + lpcfg_do_global_parameter(lp_ctx, "store dos attributes", "yes"); + for (i = 0; parm_table[i].label; i++) { if (!(lp_ctx->flags[i] & FLAG_CMDLINE)) { lp_ctx->flags[i] |= FLAG_DEFAULT; diff --git a/source3/param/loadparm.c b/source3/param/loadparm.c index 520d0660ccf3..ecff22eb638f 100644 --- a/source3/param/loadparm.c +++ b/source3/param/loadparm.c @@ -193,7 +193,7 @@ static const struct loadparm_service _sDefault = .map_system = false, .map_hidden = false, .map_archive = true, - .store_dos_attributes = false, + .store_dos_attributes = true, .dmapi_support = false, .locking = true, .strict_locking = Auto, @@ -231,7 +231,7 @@ static const struct loadparm_service _sDefault = ._use_sendfile = false, .map_acl_inherit = false, .afs_share = false, - .ea_support = false, + .ea_support = true, .acl_check_permissions = true, .acl_map_full_control = true, .acl_group_control = false, @@ -239,7 +239,7 @@ static const struct loadparm_service _sDefault = .allocation_roundup_size = SMB_ROUNDUP_ALLOCATION_SIZE, .aio_read_size = 1, .aio_write_size = 1, - .map_readonly = MAP_READONLY_YES, + .map_readonly = MAP_READONLY_NO, .directory_name_cache_size = 100, .smb_encrypt = SMB_SIGNING_DEFAULT, .kernel_share_modes = true,