From: Stefan Metzmacher <metze@samba.org>
Date: Fri, 1 Aug 2008 13:53:01 +0000 (+0200)
Subject: auth_server: fix the logic of server_get_challenge()
X-Git-Url: http://git.samba.org/?p=metze%2Fsamba%2Fwip.git;a=commitdiff_plain;h=699e3cdb52acdf2524347d8c053730306c579dd9

auth_server: fix the logic of server_get_challenge()

metze
---

diff --git a/source/auth/ntlm/auth_server.c b/source/auth/ntlm/auth_server.c
index 7efbdb30504d..42606c14baea 100644
--- a/source/auth/ntlm/auth_server.c
+++ b/source/auth/ntlm/auth_server.c
@@ -79,10 +79,10 @@ static NTSTATUS server_get_challenge(struct auth_method_context *ctx, TALLOC_CTX
 
 	status = smb_composite_connect(&io, mem_ctx, lp_resolve_context(ctx->auth_ctx->lp_ctx),
 				       ctx->auth_ctx->event_ctx);
-	if (!NT_STATUS_IS_OK(status)) {
-		*_blob = io.out.tree->session->transport->negotiate.secblob;
-		ctx->private_data = talloc_steal(ctx, io.out.tree->session);
-	}
+	NT_STATUS_NOT_OK_RETURN(status);
+
+	*_blob = io.out.tree->session->transport->negotiate.secblob;
+	ctx->private_data = talloc_steal(ctx, io.out.tree->session);
 	return NT_STATUS_OK;
 }