From: Kamen Mazdrashki <kamenim@samba.org>
Date: Thu, 16 Sep 2010 23:45:59 +0000 (+0300)
Subject: s4-prefixMap: use dsdb_schema_info_blob_is_valid() for schemaInfo blob validation
X-Git-Url: http://git.samba.org/?p=metze%2Fsamba%2Fwip.git;a=commitdiff_plain;h=aedefd3e99f36d11e49e6fbf51cb16ceffec13c4

s4-prefixMap: use dsdb_schema_info_blob_is_valid() for schemaInfo blob validation

This fixes a leaking dsdb_schema_info object also.
---

diff --git a/source4/dsdb/schema/schema_prefixmap.c b/source4/dsdb/schema/schema_prefixmap.c
index 50f74b71618d..8105f1274da9 100644
--- a/source4/dsdb/schema/schema_prefixmap.c
+++ b/source4/dsdb/schema/schema_prefixmap.c
@@ -394,7 +394,6 @@ static WERROR _dsdb_drsuapi_pfm_verify(const struct drsuapi_DsReplicaOIDMapping_
 
 	if (have_schema_info) {
 		DATA_BLOB blob;
-		struct dsdb_schema_info *schi = NULL;
 
 		if (ctr->num_mappings < 2) {
 			return WERR_INVALID_PARAMETER;
@@ -406,10 +405,9 @@ static WERROR _dsdb_drsuapi_pfm_verify(const struct drsuapi_DsReplicaOIDMapping_
 			return WERR_INVALID_PARAMETER;
 		}
 
-		/* parse schemaInfo blob to verify it is valid */
+		/* verify schemaInfo blob is valid one */
 		blob = data_blob_const(mapping->oid.binary_oid, mapping->oid.length);
-		if (!W_ERROR_IS_OK(dsdb_schema_info_from_blob(&blob, talloc_autofree_context(), &schi))) {
-			talloc_free(schi);
+		if (!dsdb_schema_info_blob_is_valid(&blob)) {
 			return WERR_INVALID_PARAMETER;
 		}