From: Stefan Metzmacher <metze@samba.org>
Date: Thu, 12 May 2016 15:16:28 +0000 (+0200)
Subject: s3:libsmb: don't use gensec_ntlmssp_server_domain()
X-Git-Url: http://git.samba.org/?p=metze%2Fsamba%2Fwip.git;a=commitdiff_plain;h=e3658730398bf18ec38be0789afa0d98737c74fe

s3:libsmb: don't use gensec_ntlmssp_server_domain()

This is a layer violation and this information is not
when using kerberos.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
---

diff --git a/source3/libsmb/cliconnect.c b/source3/libsmb/cliconnect.c
index 1d2a6b5fed6b..f7acac39253e 100644
--- a/source3/libsmb/cliconnect.c
+++ b/source3/libsmb/cliconnect.c
@@ -1242,7 +1242,6 @@ static void cli_session_setup_gensec_ready(struct tevent_req *req)
 	struct cli_session_setup_gensec_state *state =
 		tevent_req_data(req,
 		struct cli_session_setup_gensec_state);
-	const char *server_domain = NULL;
 	NTSTATUS status;
 
 	if (state->blob_in.length != 0) {
@@ -1255,27 +1254,6 @@ static void cli_session_setup_gensec_ready(struct tevent_req *req)
 		return;
 	}
 
-	/*
-	 * gensec_ntlmssp_server_domain() returns NULL
-	 * if NTLMSSP is not used.
-	 *
-	 * We can remove this later
-	 * and leave the server domain empty for SMB2 and above
-	 * in future releases.
-	 */
-	server_domain = gensec_ntlmssp_server_domain(
-				state->auth_generic->gensec_security);
-
-	if (state->cli->server_domain[0] == '\0' && server_domain != NULL) {
-		TALLOC_FREE(state->cli->server_domain);
-		state->cli->server_domain = talloc_strdup(state->cli,
-					server_domain);
-		if (state->cli->server_domain == NULL) {
-			tevent_req_nterror(req, NT_STATUS_NO_MEMORY);
-			return;
-		}
-	}
-
 	if (state->is_anonymous) {
 		/*
 		 * Windows server does not set the