metze/samba/wip.git
12 years agoTODO downgrade on LOGON_FAILURE??? gensec: move event-using code to gensec_update...
Andrew Bartlett [Mon, 17 Oct 2011 02:46:57 +0000 (13:46 +1100)]
TODO downgrade on LOGON_FAILURE??? gensec: move event-using code to gensec_update() hooks out of gensec_start*()

This ensures that only gensec_update() will require an event context argument
when the API is refactored.

Andrew Bartlett

12 years agontlmssp: Refuse to seal if we did not negotiate to sign
Andrew Bartlett [Sat, 15 Oct 2011 03:56:11 +0000 (14:56 +1100)]
ntlmssp: Refuse to seal if we did not negotiate to sign

Signed-off-by: Stefan Metzmacher <metze@samba.org>
12 years agogensec: Refuse to seal if we did not negotiate to sign
Andrew Bartlett [Sat, 15 Oct 2011 03:56:01 +0000 (14:56 +1100)]
gensec: Refuse to seal if we did not negotiate to sign

Signed-off-by: Stefan Metzmacher <metze@samba.org>
12 years agos4-auth: match the new s3 gensec client and always negotiate SIGN with SEAL
Andrew Bartlett [Sat, 15 Oct 2011 02:19:41 +0000 (13:19 +1100)]
s4-auth: match the new s3 gensec client and always negotiate SIGN with SEAL

Signed-off-by: Stefan Metzmacher <metze@samba.org>
12 years agogensec: Assert that we have not been subject to a downgrade attack in DCE/RPC clients
Andrew Bartlett [Sat, 15 Oct 2011 02:17:33 +0000 (13:17 +1100)]
gensec: Assert that we have not been subject to a downgrade attack in DCE/RPC clients

Because of the calling convention, this is the best place to assert
that we have not been subject to a downgrade attack on the negotiated
features.  (In DCE/RPC, this isn't a negotiation, the client simply
specifies the level of protection that is required).

Andrew Bartlett

(some formatting fixes)
Signed-off-by: Stefan Metzmacher <metze@samba.org>
12 years agos3-smbd Give the nt error string when failing to set up encrypted transport
Andrew Bartlett [Tue, 11 Oct 2011 05:13:49 +0000 (16:13 +1100)]
s3-smbd Give the nt error string when failing to set up encrypted transport

Signed-off-by: Stefan Metzmacher <metze@samba.org>
12 years agos3-ntlmssp Implement the server-side auth_ntlmssp code as a GENSEC module
Andrew Bartlett [Tue, 26 Jul 2011 02:35:09 +0000 (12:35 +1000)]
s3-ntlmssp Implement the server-side auth_ntlmssp code as a GENSEC module

This uses the top level gensec_ntlmssp helper functions which are identical
to the parts of ntlmssp_wrap.c that are now not called.

(Includes formatting and correctness fixes from Metze)

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
12 years agogensec: an event context is no longer mandetory
Andrew Bartlett [Sat, 15 Oct 2011 06:27:30 +0000 (17:27 +1100)]
gensec: an event context is no longer mandetory

If you do not specify one however, you better know that the modules
you are using do not need one!

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
12 years agontlmssp: Put members from auth_ntlmssp_state into gensec_ntlmssp_state
Andrew Bartlett [Mon, 25 Jul 2011 07:43:50 +0000 (17:43 +1000)]
ntlmssp: Put members from auth_ntlmssp_state into gensec_ntlmssp_state

Signed-off-by: Stefan Metzmacher <metze@samba.org>
12 years agontlmssp: Prepare gensec_ntlmssp_start() for broader use
Andrew Bartlett [Tue, 26 Jul 2011 02:32:08 +0000 (12:32 +1000)]
ntlmssp: Prepare gensec_ntlmssp_start() for broader use

This moves the allocation of the ntlmssp pointer back to the callers.

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
12 years agontlmssp: Move ntlmssp code to auth/ntlmssp
Andrew Bartlett [Mon, 25 Jul 2011 06:04:38 +0000 (16:04 +1000)]
ntlmssp: Move ntlmssp code to auth/ntlmssp

This brings in the code from both libcli/auth and
source4/auth/ntlmssp.

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
12 years agobuild: compile gensec_start.c and credentials.c in the autoconf build
Andrew Bartlett [Sun, 9 Oct 2011 12:28:54 +0000 (23:28 +1100)]
build: compile gensec_start.c and credentials.c in the autoconf build

Signed-off-by: Stefan Metzmacher <metze@samba.org>
12 years agos4-s3-upgrade: Give a better clue when we cannot open secrets.tdb
Andrew Bartlett [Mon, 17 Oct 2011 01:22:44 +0000 (12:22 +1100)]
s4-s3-upgrade: Give a better clue when we cannot open secrets.tdb

Signed-off-by: Stefan Metzmacher <metze@samba.org>
12 years agoprovision: fix the doc
Matthieu Patou [Tue, 4 Oct 2011 19:06:31 +0000 (21:06 +0200)]
provision: fix the doc

Autobuild-User: Matthieu Patou <mat@samba.org>
Autobuild-Date: Sun Oct 16 01:31:21 CEST 2011 on sn-devel-104

12 years agos4-interfaces: allow pure ipv6 to work
Matthieu Patou [Sat, 15 Oct 2011 09:13:40 +0000 (11:13 +0200)]
s4-interfaces: allow pure ipv6 to work

This is the complementary part of patch
abe5afc580dcaaab70f136904d98fa83bfae7b6e for samba4.

12 years agos4: check that the xattr are supported in the folder where we want to provision
Matthieu Patou [Fri, 14 Oct 2011 09:22:20 +0000 (11:22 +0200)]
s4: check that the xattr are supported in the folder where we want to provision

By default we were checking this on the default folder for
tempfile.NamedTemporaryFile (usualy /tmp) but this folder can be mounted
on tmpfs (which didn't support xattr currently). Now we should check on
the filesystem where the provision will be done.

12 years agoRemoved unused variable.
Jeremy Allison [Fri, 14 Oct 2011 21:02:39 +0000 (14:02 -0700)]
Removed unused variable.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Sat Oct 15 00:38:28 CEST 2011 on sn-devel-104

12 years agoRemove unused function.
Jeremy Allison [Fri, 14 Oct 2011 21:01:24 +0000 (14:01 -0700)]
Remove unused function.

12 years agoFix printf warning.
Jeremy Allison [Fri, 14 Oct 2011 20:53:53 +0000 (13:53 -0700)]
Fix printf warning.

12 years agoFix const warnings.
Jeremy Allison [Fri, 14 Oct 2011 20:51:26 +0000 (13:51 -0700)]
Fix const warnings.

12 years agoFix const warnings.
Jeremy Allison [Fri, 14 Oct 2011 20:48:53 +0000 (13:48 -0700)]
Fix const warnings.

12 years agoFix bug with Samba not recognising an 6to4 IPv6 interface.
Matthieu Patou [Fri, 14 Oct 2011 20:45:48 +0000 (13:45 -0700)]
Fix bug with Samba not recognising an 6to4 IPv6 interface.

"The 6to4 interface has the flags IFF_POINTTOPOINT interface but no
ifa_dstaddr as it's not at the IPv6 level a point to point interface
(at least from my understanding), as we don't have a IFF_BROADCAST
flag set (I have the impression that this flag is only set on a
interface that has also an IPv4 address) the first test is not valid
also, which result in a skipped interface."

12 years agoFix const warning.
Jeremy Allison [Fri, 14 Oct 2011 20:20:07 +0000 (13:20 -0700)]
Fix const warning.

12 years agos3:dbwrap_ctdb: return the number of records in db_ctdb_traverse() for persistent dbs
Stefan Metzmacher [Fri, 14 Oct 2011 14:11:06 +0000 (16:11 +0200)]
s3:dbwrap_ctdb: return the number of records in db_ctdb_traverse() for persistent dbs

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Fri Oct 14 20:59:37 CEST 2011 on sn-devel-104

12 years agos3-net: Fix uninitialized variable in rpc_conf_import_internal().
Günther Deschner [Fri, 14 Oct 2011 14:51:07 +0000 (16:51 +0200)]
s3-net: Fix uninitialized variable in rpc_conf_import_internal().

Michael, please check.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Oct 14 19:25:47 CEST 2011 on sn-devel-104

12 years agoFix sys_fseek wrapper
Brad Smith [Wed, 12 Oct 2011 08:23:58 +0000 (04:23 -0400)]
Fix sys_fseek wrapper

Signed-off-by: Günther Deschner <gd@samba.org>
12 years agobuild: added autoconf --disable-silent-rules option
Sumit Bose [Thu, 6 Oct 2011 08:32:58 +0000 (10:32 +0200)]
build: added autoconf --disable-silent-rules option

Signed-off-by: Günther Deschner <gd@samba.org>
12 years agos3:net registry: fix segfault when net registry is called without subcommands...
Michael Adam [Fri, 14 Oct 2011 14:19:03 +0000 (16:19 +0200)]
s3:net registry: fix segfault when net registry is called without subcommands...

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Fri Oct 14 17:51:53 CEST 2011 on sn-devel-104

12 years agolibreplace: add a missing "eval" to the AC_VERIFY_C_PROTOTYPE macro
Michael Adam [Fri, 14 Oct 2011 12:05:09 +0000 (14:05 +0200)]
libreplace: add a missing "eval" to the AC_VERIFY_C_PROTOTYPE macro

Without this eval, upon test success the corresponding actions
(like defining corresponding variables) are not taken.

Found by Timur I. Bakeyev, and based on his patch for 3.5.

12 years agos3-utils: add capabilities to dbwrap_tool
Björn Baumbach [Fri, 14 Oct 2011 10:22:16 +0000 (12:22 +0200)]
s3-utils: add capabilities to dbwrap_tool

Make it possible to work with strings in addition to int32 and uint32.

Signed-off-by: Michael Adam <obnox@samba.org>
12 years agos3-waf: install passdb headers.
Günther Deschner [Tue, 27 Sep 2011 16:23:39 +0000 (18:23 +0200)]
s3-waf: install passdb headers.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Oct 14 13:37:38 CEST 2011 on sn-devel-104

12 years agos3-passdb: remove libwbclient header dependency for passdb/lookup_sid.h.
Günther Deschner [Thu, 13 Oct 2011 12:56:37 +0000 (14:56 +0200)]
s3-passdb: remove libwbclient header dependency for passdb/lookup_sid.h.

Guenther

12 years agos3-passdb: remove fstring from pdb_set_user_sid_from_string().
Günther Deschner [Thu, 13 Oct 2011 12:55:32 +0000 (14:55 +0200)]
s3-passdb: remove fstring from pdb_set_user_sid_from_string().

Guenther

12 years agos3-passdb: add define guards for machine_sid.h.
Günther Deschner [Thu, 13 Oct 2011 12:54:51 +0000 (14:54 +0200)]
s3-passdb: add define guards for machine_sid.h.

Guenther

12 years agos3-passdb: add {LM|NT}_HASH_LEN defines in passdb.h.
Günther Deschner [Wed, 12 Oct 2011 13:51:19 +0000 (15:51 +0200)]
s3-passdb: add {LM|NT}_HASH_LEN defines in passdb.h.

Guenther

12 years agos3-passdb: use uintX_t at least in headers.
Günther Deschner [Wed, 12 Oct 2011 13:50:44 +0000 (15:50 +0200)]
s3-passdb: use uintX_t at least in headers.

Guenther

12 years agos3-passdb: move passdb prototypes into passdb.h
Günther Deschner [Tue, 27 Sep 2011 15:53:09 +0000 (17:53 +0200)]
s3-passdb: move passdb prototypes into passdb.h

Guenther

12 years agos3-passdb: move group mapping headers into passdb.h
Günther Deschner [Tue, 27 Sep 2011 15:50:51 +0000 (17:50 +0200)]
s3-passdb: move group mapping headers into passdb.h

Guenther

12 years agos3-auth: token_util needs system/passwd.h.
Günther Deschner [Thu, 13 Oct 2011 12:56:03 +0000 (14:56 +0200)]
s3-auth: token_util needs system/passwd.h.

Guenther

12 years agos3: remove some dead prototypes.
Günther Deschner [Thu, 13 Oct 2011 12:37:47 +0000 (14:37 +0200)]
s3: remove some dead prototypes.

Guenther

12 years agoAdd support for VFS op streaminfo chaining in all relevant VFS modules.
Frank Lahm [Thu, 13 Oct 2011 22:41:53 +0000 (15:41 -0700)]
Add support for VFS op streaminfo chaining in all relevant VFS modules.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Oct 14 03:26:06 CEST 2011 on sn-devel-104

12 years agosamba-tool: Add test to make sure all commands have a short description set.
Jelmer Vernooij [Thu, 13 Oct 2011 21:49:05 +0000 (23:49 +0200)]
samba-tool: Add test to make sure all commands have a short description set.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Fri Oct 14 01:53:45 CEST 2011 on sn-devel-104

12 years agosamba-tool: Add test to make sure all commands have a synopsis set.
Jelmer Vernooij [Thu, 13 Oct 2011 21:47:45 +0000 (23:47 +0200)]
samba-tool: Add test to make sure all commands have a synopsis set.

12 years agosamba-tool: Move main command implementation to samba.netcmd.main, so it is accessibl...
Jelmer Vernooij [Thu, 13 Oct 2011 21:36:10 +0000 (23:36 +0200)]
samba-tool: Move main command implementation to samba.netcmd.main, so it is accessible by the testsuite.

12 years agosamba-tool: Don't require full prog line to be in synopsis.
Jelmer Vernooij [Thu, 13 Oct 2011 21:27:22 +0000 (23:27 +0200)]
samba-tool: Don't require full prog line to be in synopsis.

12 years agosamba.netcmd: Reintroduce Command.name.
Jelmer Vernooij [Thu, 13 Oct 2011 21:16:58 +0000 (23:16 +0200)]
samba.netcmd: Reintroduce Command.name.

12 years agoCodingStyle: Add some notes about Python 2.4 compatibility.
Jelmer Vernooij [Thu, 13 Oct 2011 21:08:45 +0000 (23:08 +0200)]
CodingStyle: Add some notes about Python 2.4 compatibility.

12 years agosamba-tool: Determine long option from docstring.
Jelmer Vernooij [Thu, 13 Oct 2011 21:08:32 +0000 (23:08 +0200)]
samba-tool: Determine long option from docstring.

12 years agocreds: Remove unnecessary calls to credopts.get_credentials.
Jelmer Vernooij [Thu, 13 Oct 2011 20:24:50 +0000 (22:24 +0200)]
creds: Remove unnecessary calls to credopts.get_credentials.

12 years agopython: Remove extra newlines.
Jelmer Vernooij [Thu, 13 Oct 2011 20:21:48 +0000 (22:21 +0200)]
python: Remove extra newlines.

12 years agos4:selftest: flakey test samba4.drs.delete_object.python should go into skip
Michael Adam [Thu, 13 Oct 2011 20:43:41 +0000 (22:43 +0200)]
s4:selftest: flakey test samba4.drs.delete_object.python should go into skip

not knownfail, which will render it flakey again, just the other way round.
Thanks Jelmer for pointing that out...

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Fri Oct 14 00:21:26 CEST 2011 on sn-devel-104

12 years agoUpdate to newer version of subunit.
Jelmer Vernooij [Thu, 13 Oct 2011 17:03:26 +0000 (19:03 +0200)]
Update to newer version of subunit.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Thu Oct 13 20:37:18 CEST 2011 on sn-devel-104

12 years agos3:dbwrap_ctdb: fix the build after changing signature of tdb_wrap_open()
Michael Adam [Thu, 13 Oct 2011 14:50:57 +0000 (16:50 +0200)]
s3:dbwrap_ctdb: fix the build after changing signature of tdb_wrap_open()

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Thu Oct 13 18:50:47 CEST 2011 on sn-devel-104

12 years agoadd lib/param files to .gitignore
Andrew Bartlett [Thu, 13 Oct 2011 11:58:26 +0000 (22:58 +1100)]
add lib/param files to .gitignore

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Thu Oct 13 15:40:16 CEST 2011 on sn-devel-104

12 years agobuild: run perl generators at autogen.sh time
Andrew Bartlett [Thu, 13 Oct 2011 11:53:20 +0000 (22:53 +1100)]
build: run perl generators at autogen.sh time

12 years agobuild: clean new generated param headers
Andrew Bartlett [Thu, 13 Oct 2011 11:53:03 +0000 (22:53 +1100)]
build: clean new generated param headers

12 years agobuild: only regenerate param files when required
Andrew Bartlett [Thu, 13 Oct 2011 11:51:30 +0000 (22:51 +1100)]
build: only regenerate param files when required

12 years agolib/param reduce the cost of loadparm_init_s3()
Andrew Bartlett [Thu, 13 Oct 2011 09:16:28 +0000 (20:16 +1100)]
lib/param reduce the cost of loadparm_init_s3()

The parameter redirection covers most things now, so this should be safe.

Andrew Bartlett

12 years agolib/util: Add back control of mmap and hash size in tdb for top level build
Andrew Bartlett [Wed, 12 Oct 2011 12:01:08 +0000 (23:01 +1100)]
lib/util: Add back control of mmap and hash size in tdb for top level build

This passes down a struct loadparm_context to allow these
parameters to be checked.  This may be s3 or s4 context, allowing the
#if _SAMBA_BUILD_ macro to go away safely.

Andrew Bartlett

12 years agos4-messaging: Pass the loadparm context, not just the messaging path
Andrew Bartlett [Thu, 13 Oct 2011 09:01:56 +0000 (20:01 +1100)]
s4-messaging: Pass the loadparm context, not just the messaging path

This will allow the TDB layer to get at the lp_ctx for tdb options.

Andrew Bartlett

12 years agolibcli/auth: Provide a struct loadparm_context to schannel calls
Andrew Bartlett [Wed, 12 Oct 2011 11:55:34 +0000 (22:55 +1100)]
libcli/auth: Provide a struct loadparm_context to schannel calls

This will allow us to pass this down to the tdb_wrap layer.

Andrew Bartlett

12 years agolib/param Print error when mkdir of lock path fails
Andrew Bartlett [Wed, 12 Oct 2011 11:37:24 +0000 (22:37 +1100)]
lib/param Print error when mkdir of lock path fails

This matches the s3 code for lock_path().

Andrew Bartlett

12 years agolib/param Add 'use mmap' parameter to control tdb use of mmap
Andrew Bartlett [Wed, 12 Oct 2011 11:36:40 +0000 (22:36 +1100)]
lib/param Add 'use mmap' parameter to control tdb use of mmap

12 years agobuild: use lib/param loadparm code in source3 to get at lpcfg_ functions
Andrew Bartlett [Sat, 8 Oct 2011 01:18:09 +0000 (12:18 +1100)]
build: use lib/param loadparm code in source3 to get at lpcfg_ functions

12 years agoAnother part of the fix for Bug 8473 - smb2_find uses a hard coded max reply size...
Jeremy Allison [Wed, 12 Oct 2011 21:00:32 +0000 (14:00 -0700)]
Another part of the fix for Bug 8473 - smb2_find uses a hard coded max reply size of 0x10000 instead of smb2_max_trans.

Change the defaults and the documentation to reflect the 64k limit.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Oct 13 12:22:23 CEST 2011 on sn-devel-104

12 years agoconfig.h: define HAVE_LIBREPLACE
Rusty Russell [Thu, 13 Oct 2011 03:07:52 +0000 (13:37 +1030)]
config.h: define HAVE_LIBREPLACE

tdb2 wants to know if it should use replace.h.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-User: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-Date: Thu Oct 13 08:58:35 CEST 2011 on sn-devel-104

12 years agosamba-tool: Use self.outf in a few more places.
Jelmer Vernooij [Wed, 12 Oct 2011 22:36:44 +0000 (00:36 +0200)]
samba-tool: Use self.outf in a few more places.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Thu Oct 13 05:06:52 CEST 2011 on sn-devel-104

12 years agosamba-tool delegation: Use self.outf, simplify some code.
Jelmer Vernooij [Wed, 12 Oct 2011 22:19:51 +0000 (00:19 +0200)]
samba-tool delegation: Use self.outf, simplify some code.

12 years agosamba.getopt: Refactor parsing of --kerberos argument into separate function.
Jelmer Vernooij [Wed, 12 Oct 2011 21:45:52 +0000 (23:45 +0200)]
samba.getopt: Refactor parsing of --kerberos argument into separate function.

12 years agos3:smb2_server: get/set info are limited by max_trans size (bug #8473)
Stefan Metzmacher [Wed, 12 Oct 2011 15:46:50 +0000 (17:46 +0200)]
s3:smb2_server: get/set info are limited by max_trans size (bug #8473)

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Oct 13 03:32:02 CEST 2011 on sn-devel-104

12 years agos3:smb2_server: reject writes larger then the negotiated max_write size (bug #8473)
Stefan Metzmacher [Wed, 12 Oct 2011 14:58:46 +0000 (16:58 +0200)]
s3:smb2_server: reject writes larger then the negotiated max_write size (bug #8473)

metze

12 years agos3:smb2_server: remember the max_{trans,read,write} sizes we negotiated (bug #8473)
Stefan Metzmacher [Fri, 23 Sep 2011 15:18:14 +0000 (17:18 +0200)]
s3:smb2_server: remember the max_{trans,read,write} sizes we negotiated (bug #8473)

We should enforce the negotiated max sizes instead of the
lp_smb2_max_*() sizes.

metze

12 years agos4:torture/smb2: we only support 64KB reads/writes for now
Stefan Metzmacher [Wed, 12 Oct 2011 16:34:26 +0000 (18:34 +0200)]
s4:torture/smb2: we only support 64KB reads/writes for now

We don't have multi-credit support yet.

metze

12 years agosamba-tools/testparm: Add really basic unit test, demonstrating how to write unit...
Jelmer Vernooij [Wed, 12 Oct 2011 21:27:57 +0000 (23:27 +0200)]
samba-tools/testparm: Add really basic unit test, demonstrating how to write unit tests for samba-tool in Python.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Thu Oct 13 01:56:20 CEST 2011 on sn-devel-104

12 years agonetcmd: Add Command.get_logger() method.
Jelmer Vernooij [Wed, 12 Oct 2011 21:21:52 +0000 (23:21 +0200)]
netcmd: Add Command.get_logger() method.

12 years agonetcmd: Add errf stream to command instances.
Jelmer Vernooij [Wed, 12 Oct 2011 21:19:12 +0000 (23:19 +0200)]
netcmd: Add errf stream to command instances.

12 years agosamba-tool/testparm: Fix traceback when checking client name/ip against hosts allowed.
Jelmer Vernooij [Wed, 12 Oct 2011 21:11:14 +0000 (23:11 +0200)]
samba-tool/testparm: Fix traceback when checking client name/ip against hosts allowed.

12 years agosamba-tool/testparm: Fix handling of command-line options.
Jelmer Vernooij [Wed, 12 Oct 2011 21:10:14 +0000 (23:10 +0200)]
samba-tool/testparm: Fix handling of command-line options.

12 years agoselftest: mark samba4.drs.delete_object.python knownfail
Michael Adam [Wed, 12 Oct 2011 20:11:26 +0000 (22:11 +0200)]
selftest: mark samba4.drs.delete_object.python knownfail

this currently prevents autobuild from succeeding intermittently

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Thu Oct 13 00:22:18 CEST 2011 on sn-devel-104

12 years agos3:smbcacls: fix violation of coding conventions
Gregor Beck [Wed, 12 Oct 2011 12:34:45 +0000 (14:34 +0200)]
s3:smbcacls: fix violation of coding conventions

Signed-off-by: Michael Adam <obnox@samba.org>
12 years agos3:net: avoid unnecessary initialization of the registry.
Gregor Beck [Mon, 26 Sep 2011 11:42:15 +0000 (13:42 +0200)]
s3:net: avoid unnecessary initialization of the registry.

This allows for using help without having access to the registry and
prevents update code to run if only a readonly check is to be performed.

Signed-off-by: Michael Adam <obnox@samba.org>
12 years agos3:doc manpage for "net registry check"
Gregor Beck [Thu, 25 Aug 2011 14:26:25 +0000 (16:26 +0200)]
s3:doc manpage for "net registry check"

Signed-off-by: Michael Adam <obnox@samba.org>
12 years agos3:net: add command registry check
Gregor Beck [Thu, 30 Jun 2011 10:08:16 +0000 (12:08 +0200)]
s3:net: add command registry check

Signed-off-by: Michael Adam <obnox@samba.org>
12 years agos3:net: factor out interact_edit()
Gregor Beck [Thu, 18 Aug 2011 12:13:28 +0000 (14:13 +0200)]
s3:net: factor out interact_edit()

Signed-off-by: Michael Adam <obnox@samba.org>
12 years agos3:registry add function srprs_hive()
Gregor Beck [Tue, 12 Jul 2011 11:04:37 +0000 (13:04 +0200)]
s3:registry add function srprs_hive()

Signed-off-by: Michael Adam <obnox@samba.org>
12 years agos3:utils change data_blob_dup_talloc() to take a DATA_BLOB by value
Gregor Beck [Thu, 7 Jul 2011 12:50:47 +0000 (14:50 +0200)]
s3:utils change data_blob_dup_talloc() to take a DATA_BLOB by value

Signed-off-by: Michael Adam <obnox@samba.org>
12 years agos3:smbcontrol: let smbd pass the idmap msg to its children for convenience
Gregor Beck [Thu, 6 Oct 2011 13:26:32 +0000 (15:26 +0200)]
s3:smbcontrol: let smbd pass the idmap msg to its children for convenience

Signed-off-by: Michael Adam <obnox@samba.org>
12 years agos3: factor out messaging_send_to_children()
Gregor Beck [Thu, 6 Oct 2011 12:38:20 +0000 (14:38 +0200)]
s3: factor out messaging_send_to_children()

Signed-off-by: Michael Adam <obnox@samba.org>
12 years agos3: fix id_cache_kill to delete the the id-mappig from caches
Gregor Beck [Thu, 6 Oct 2011 11:49:02 +0000 (13:49 +0200)]
s3: fix id_cache_kill to delete the the id-mappig from caches

The intendet and documented behavior of smbcontrol smbd idmap kill is to
delete the mapping from caches and additionally kill the smbd if an affected id
is in use.

Signed-off-by: Michael Adam <obnox@samba.org>
12 years agos3:smbcacls: make get_domain_sid() static
Michael Adam [Wed, 12 Oct 2011 11:02:31 +0000 (13:02 +0200)]
s3:smbcacls: make get_domain_sid() static

12 years agos3:dbwrap_ctdb: improve the check for skipping the __db_sequence_number__ record...
Michael Adam [Wed, 12 Oct 2011 10:04:50 +0000 (12:04 +0200)]
s3:dbwrap_ctdb: improve the check for skipping the __db_sequence_number__ record in traverse

It did not compare the last charcter (usually '\0')

12 years agos3:dbwrap_ctdb: fix check for skipping the __db_sequence_number__ in traverse
Michael Adam [Wed, 12 Oct 2011 10:03:42 +0000 (12:03 +0200)]
s3:dbwrap_ctdb: fix check for skipping the __db_sequence_number__ in traverse

Brown paperbag. This omitted the "== 0" hand hence skipped all keys of the
same length as __db_sequence_number__ but different from it...

12 years agosamba.upgrade: Use list comprehension.
Jelmer Vernooij [Wed, 12 Oct 2011 18:12:26 +0000 (20:12 +0200)]
samba.upgrade: Use list comprehension.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Wed Oct 12 22:44:40 CEST 2011 on sn-devel-104

12 years agoFix bug #8515 - Empty CIFS share can be blocked for other clients by deleting it...
Volodymyr Khomenko [Wed, 12 Oct 2011 16:57:57 +0000 (09:57 -0700)]
Fix bug #8515 - Empty CIFS share can be blocked for other clients by deleting it via empty path (DELETE_PENDING until the last client)

Disallow "." in can_set_delete_on_close().

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Oct 12 21:07:27 CEST 2011 on sn-devel-104

12 years agoFix bug #8521 - winbindd cache timeout expiry test was reversed
Jeremy Allison [Wed, 12 Oct 2011 16:43:18 +0000 (09:43 -0700)]
Fix bug #8521 - winbindd cache timeout expiry test was reversed

Found and fix reported by Micha Lenk <micha@lenk.info>. Thanks !

12 years agos3-group-mapping: Remove fstrings from GROUP_MAP.
Simo Sorce [Mon, 26 Sep 2011 21:55:47 +0000 (17:55 -0400)]
s3-group-mapping: Remove fstrings from GROUP_MAP.

Signed-off-by: Andreas Schneider <asn@samba.org>
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Oct 12 19:28:12 CEST 2011 on sn-devel-104

12 years agos3-dbwrap_ctdb: fix the build.
Günther Deschner [Wed, 12 Oct 2011 09:48:55 +0000 (11:48 +0200)]
s3-dbwrap_ctdb: fix the build.

Michael, please check.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Oct 12 15:25:56 CEST 2011 on sn-devel-104

12 years agos3-groupdb: split out groupdb/mapping_tdb.h.
Günther Deschner [Wed, 12 Oct 2011 09:17:57 +0000 (11:17 +0200)]
s3-groupdb: split out groupdb/mapping_tdb.h.

Guenther

12 years agoselftest: Fix plugin_s4_dc configuration.
Andreas Schneider [Tue, 11 Oct 2011 14:41:24 +0000 (16:41 +0200)]
selftest: Fix plugin_s4_dc configuration.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Oct 12 13:50:10 CEST 2011 on sn-devel-104

12 years agos3 waf: Use upper case uselib_store parameter, otherwise the following checks won...
Kai Blin [Wed, 12 Oct 2011 06:17:02 +0000 (08:17 +0200)]
s3 waf: Use upper case uselib_store parameter, otherwise the following checks won't find it

Autobuild-User: Kai Blin <kai@samba.org>
Autobuild-Date: Wed Oct 12 09:49:50 CEST 2011 on sn-devel-104