Günther Deschner [Tue, 27 Apr 2010 23:07:08 +0000 (01:07 +0200)]
s3-lanman: remove a unnecessary memset in api_WPrintJobEnumerate().
Guenther
Günther Deschner [Tue, 27 Apr 2010 21:12:40 +0000 (23:12 +0200)]
s3-lanman: remove unused code.
Guenther
Günther Deschner [Tue, 27 Apr 2010 20:55:11 +0000 (22:55 +0200)]
s3-lanman: use spoolss for api_DosPrintQGetInfo and api_DosPrintQEnum.
Guenther
Jeremy Allison [Tue, 27 Apr 2010 23:07:12 +0000 (16:07 -0700)]
Don't return an intermediate reply on async on a pipe call (Windows doesn't).
Jeremy.
Günther Deschner [Tue, 27 Apr 2010 17:58:32 +0000 (19:58 +0200)]
s3-lanman: use spoolss for api_PrintJobInfo().
Guenther
Günther Deschner [Tue, 27 Apr 2010 22:05:41 +0000 (00:05 +0200)]
s4-smbtorture: also try renaming jobname in test_DoPrintTest_check_jobs().
Guenther
Günther Deschner [Tue, 27 Apr 2010 21:33:05 +0000 (23:33 +0200)]
s4-smbtorture: allow to pass down spoolss_JobInfoContainer to SetJob functions.
Guenther
Günther Deschner [Tue, 27 Apr 2010 21:31:25 +0000 (23:31 +0200)]
s4-smbtorture: be more liberal when spoolss_SetJob fails.
For some reason, spoolss_SetJob pausing and resuming of printjob is still racy
on the buildfarm. Converting the fatal assert to a warning for now.
Guenther
Günther Deschner [Tue, 27 Apr 2010 17:57:47 +0000 (19:57 +0200)]
s3-spoolss: add support for SetJobInfo level 1 (for jobfile rename).
Guenther
Günther Deschner [Tue, 27 Apr 2010 17:30:49 +0000 (19:30 +0200)]
s3-lanman: remove unsupported print_job_set_place().
Guenther
Jeremy Allison [Tue, 27 Apr 2010 19:10:20 +0000 (12:10 -0700)]
Fix more S3 build breakage. Matthias, please ensure S3 builds when
changing common code.
Jeremy.
Marcel Ritter [Tue, 27 Apr 2010 11:53:04 +0000 (13:53 +0200)]
Install spn_update_list to setup/ dir
Signed-off-by: Matthias Dieter Wallnöfer <mdw@samba.org>
Matthias Dieter Wallnöfer [Tue, 27 Apr 2010 18:45:06 +0000 (20:45 +0200)]
s3:libads/ldap.c - fix a build breakage
Matthias Dieter Wallnöfer [Tue, 27 Apr 2010 16:25:21 +0000 (18:25 +0200)]
Revert "s4:web_server: use tsocket_address functions to get the local ip and port"
This reverts commit
9a1a00199c2603376eacfdba7e7d0d55bc64f405.
This broke the build.
Matthias Dieter Wallnöfer [Tue, 27 Apr 2010 16:07:09 +0000 (18:07 +0200)]
s4:cldap_server/netlogon.c - handle the domain SID correctly
Matthias Dieter Wallnöfer [Tue, 27 Apr 2010 14:56:36 +0000 (16:56 +0200)]
nbt: samlogon/netlogon structures - unify denominations
Matthias Dieter Wallnöfer [Tue, 27 Apr 2010 14:32:46 +0000 (16:32 +0200)]
s4:fill_netlogon_samlogon_response - reorder assign operations (to be consistent)
Matthias Dieter Wallnöfer [Tue, 27 Apr 2010 14:31:07 +0000 (16:31 +0200)]
s4:fill_netlogon_samlogon_response - use "lp_workgroup" for the short netbios domainname
This call is only for the DC mode.
Matthias Dieter Wallnöfer [Tue, 27 Apr 2010 13:27:40 +0000 (15:27 +0200)]
s4:torture - DsRAddressToSitenames[Ex]W testsuite - make it IPv4-only compatible
Günther Deschner [Tue, 27 Apr 2010 16:00:43 +0000 (18:00 +0200)]
Revert "s3-build: Remove --enable-merged support."
This reverts commit
f8fc7fcbeb8141c5b2775e2219bae17c55ad4a3c.
Was that pushed by coincidence ? merged build is really, really required over
here.
Günther Deschner [Tue, 27 Apr 2010 15:52:47 +0000 (17:52 +0200)]
s4-smbtorture: make sure to zero the add driver info 8 struct before adding drivers.
Guenther
Günther Deschner [Tue, 27 Apr 2010 15:32:34 +0000 (17:32 +0200)]
s3-spoolss: publish "Monitor" in winreg for drivers.
Found by torture test.
Guenther
Günther Deschner [Tue, 27 Apr 2010 14:48:29 +0000 (16:48 +0200)]
s3-spoolss: fix winreg attribute for storing datatype.
Found by torture test (and checked with w2k, w2k3 and w2k8).
Guenther
Günther Deschner [Tue, 27 Apr 2010 15:55:55 +0000 (17:55 +0200)]
s3-spoolss: fix some uninitialized variables.
Guenther
Stefan Metzmacher [Tue, 27 Apr 2010 11:36:21 +0000 (13:36 +0200)]
s3:smbd: keep local and remote tsocket_address per connection
metze
Björn Jacke [Tue, 27 Apr 2010 15:06:55 +0000 (17:06 +0200)]
s3/packaging: make rpm build work by overriding strict linker flags
Stefan Metzmacher [Tue, 27 Apr 2010 14:49:00 +0000 (16:49 +0200)]
s4:rpc_server: remove unused socket_address based functions
metze
Stefan Metzmacher [Tue, 27 Apr 2010 14:36:26 +0000 (16:36 +0200)]
s4:web_server: use tsocket_address functions to get the local ip and port
metze
Stefan Metzmacher [Tue, 27 Apr 2010 14:05:08 +0000 (16:05 +0200)]
s4:smb_server: use tsocket_address_string() for debugging the client address
metze
Stefan Metzmacher [Tue, 27 Apr 2010 14:17:28 +0000 (16:17 +0200)]
s4:wrepl_server: use tsocket_address functions to get the peer ip
metze
Stefan Metzmacher [Tue, 27 Apr 2010 15:04:32 +0000 (17:04 +0200)]
s4:lib/registry: fix the waf build
The pass to a source file is relative to the wscript* file.
metze
Günther Deschner [Tue, 27 Apr 2010 13:56:09 +0000 (15:56 +0200)]
s4-smbtorture: upload the full cups driver, otherwise windows will not allow using it.
Guenther
Günther Deschner [Tue, 27 Apr 2010 13:48:03 +0000 (15:48 +0200)]
s4-smbtorture: only compare level 3 for s3 when checking winreg and spoolss_Driver.
Guenther
Günther Deschner [Tue, 27 Apr 2010 12:13:12 +0000 (14:13 +0200)]
s4-smbtorture: mention architecture of added drivers in debug output.
Guenther
Günther Deschner [Tue, 27 Apr 2010 13:48:52 +0000 (15:48 +0200)]
s4-smbtorture: make sure to not attempt to remove a driver file twice.
Guenther
Günther Deschner [Tue, 27 Apr 2010 11:15:04 +0000 (13:15 +0200)]
s4-smbtorture: setup all members of level 3,4,6,8 driver add.
Guenther
Günther Deschner [Tue, 27 Apr 2010 09:30:35 +0000 (11:30 +0200)]
s4-smbtorture: use a torture_printer_context and upload own driver for RPC-SPOOLSS-PRINTER test.
Guenther
Günther Deschner [Tue, 27 Apr 2010 08:38:36 +0000 (10:38 +0200)]
s4-smbtorture: split RPC-SPOOLSS-PRINTER into more tests.
Guenther
Günther Deschner [Mon, 26 Apr 2010 21:35:19 +0000 (23:35 +0200)]
s4-smbtorture: finally test REG_MULTI_SZ in winreg/driverinfo consistency tests.
Guenther
Günther Deschner [Tue, 27 Apr 2010 14:38:40 +0000 (16:38 +0200)]
s3: use shared registry functions.
Guenther
Günther Deschner [Tue, 27 Apr 2010 14:37:56 +0000 (16:37 +0200)]
s4: use shared registry functions.
Guenther
Günther Deschner [Tue, 27 Apr 2010 14:37:06 +0000 (16:37 +0200)]
registry: add some shared registry helper functions.
Guenther
Günther Deschner [Mon, 26 Apr 2010 21:21:07 +0000 (23:21 +0200)]
s4-smbtorture: remove some typecasts in rap tests.
Guenther
Andrew Tridgell [Tue, 27 Apr 2010 13:39:57 +0000 (23:39 +1000)]
s4-netlogon: fixed getDcNameEx2 for blank inputs
w2k8r2 returns the local DC information on no inputs for
getDcNameEx2. This is needed for starting dsa.msc (ADUC) on
Win7.
CDLAP on the same call returns an error. This uses a parameter
fill_on_blank_request to distinguish the two cases.
Stefan Metzmacher [Tue, 27 Apr 2010 14:17:28 +0000 (16:17 +0200)]
s4:wrepl_server: use tsocket_address functions to get the peer ip
metze
Stefan Metzmacher [Tue, 27 Apr 2010 14:05:08 +0000 (16:05 +0200)]
s4:smb_server: use tsocket_address_string() for debugging the client address
metze
Stefan Metzmacher [Tue, 27 Apr 2010 13:45:12 +0000 (15:45 +0200)]
s4:smb_server: use tsocket_address_string() to display the client address
metze
Stefan Metzmacher [Tue, 27 Apr 2010 13:44:40 +0000 (15:44 +0200)]
s4:smb_server: remove unused socket_address functions
metze
Stefan Metzmacher [Tue, 27 Apr 2010 13:06:33 +0000 (15:06 +0200)]
s4:ntvfs/ipc: remote // debug comments
metze
Andrew Tridgell [Tue, 27 Apr 2010 11:56:51 +0000 (21:56 +1000)]
s4-torture: not all platforms have defines like AF_AX25
all we need are invalid values here, so just use fixd high values.
Stefan Metzmacher [Mon, 26 Apr 2010 11:38:00 +0000 (13:38 +0200)]
s4:ntvfs: remove socket_address based functions
metze
Stefan Metzmacher [Mon, 26 Apr 2010 11:37:12 +0000 (13:37 +0200)]
s4:ntvfs/ipc: pass the already given tsocket_address structures to the named_pipe_auth code
metze
Stefan Metzmacher [Mon, 26 Apr 2010 11:34:44 +0000 (13:34 +0200)]
s4:smb_server: pass tsocket_addresses to the ntvfs layer
metze
Stefan Metzmacher [Mon, 26 Apr 2010 11:40:15 +0000 (13:40 +0200)]
s4:ntvfs: add tsocket based addresses to ntvfs_context
metze
Stefan Metzmacher [Mon, 26 Apr 2010 11:39:36 +0000 (13:39 +0200)]
s4:rpc_server: remove 'socket_address' based functions
metze
Stefan Metzmacher [Mon, 26 Apr 2010 11:27:51 +0000 (13:27 +0200)]
s4:rpc_server/srvsvc: pass tsocket_address to the ntvfs layer
metze
Stefan Metzmacher [Mon, 26 Apr 2010 11:22:01 +0000 (13:22 +0200)]
s4:rpc_server/spoolss: use tsocket_address in dcesrv_spoolss_check_server_name()
metze
Stefan Metzmacher [Mon, 26 Apr 2010 11:18:41 +0000 (13:18 +0200)]
s4:rpc_server/netlogon: use tsocket_address in dcesrv_netr_DsRGetDCNameEx2()
metze
Stefan Metzmacher [Mon, 26 Apr 2010 11:06:07 +0000 (13:06 +0200)]
s4:rpc_server: remember the local and remote address
metze
Stefan Metzmacher [Mon, 26 Apr 2010 11:56:06 +0000 (13:56 +0200)]
s4:service_named_pipe: use the passed client and server addresses
This gives the rpc server code the correct client and server
ip addresses for ncacn_np.
metze
Stefan Metzmacher [Tue, 27 Apr 2010 08:22:25 +0000 (10:22 +0200)]
s4:cldap_server: allow src_address = NULL in fill_netlogon_samlogon_response()
If we don't have the client address, we assume it's a local call,
maybe ncalrpc.
metze
Stefan Metzmacher [Tue, 27 Apr 2010 08:21:28 +0000 (10:21 +0200)]
s4:dsdb/common: if we don't have the ip of the client return the server site as client site
metze
Stefan Metzmacher [Tue, 27 Apr 2010 08:41:46 +0000 (10:41 +0200)]
lib/tsocket: add tsocket_address_is_unix() function
metze
Stefan Metzmacher [Tue, 27 Apr 2010 08:34:15 +0000 (10:34 +0200)]
lib/tsocket: add tsocket_address_is_inet() function
metze
Andrew Tridgell [Tue, 27 Apr 2010 09:45:49 +0000 (19:45 +1000)]
s4-test: make spnupdate work without make install
thanks to metze for noticing this
Andrew Tridgell [Tue, 27 Apr 2010 08:38:47 +0000 (18:38 +1000)]
s4-provision: setup spn_update_list in provision
Andrew Tridgell [Tue, 27 Apr 2010 08:38:25 +0000 (18:38 +1000)]
s4-dns: install samba_spnupdate
Andrew Tridgell [Tue, 27 Apr 2010 08:38:04 +0000 (18:38 +1000)]
s4-dns: call spn update command alongside dns update
call samba_spnupdate at the same time as samba_spnupdate
Andrew Tridgell [Tue, 27 Apr 2010 08:37:12 +0000 (18:37 +1000)]
s4-param: added a "spn update command" option
used by SPN update code
Andrew Tridgell [Tue, 27 Apr 2010 08:25:55 +0000 (18:25 +1000)]
s4-dsdb: added samba_spnupdate
this script adds all our required servicePrincipalName entries at
runtime. The admin can add more entries to spn_update_list as needed
Andrew Tridgell [Tue, 27 Apr 2010 08:25:06 +0000 (18:25 +1000)]
s4-dns: explain what the file is for
Andrew Tridgell [Tue, 27 Apr 2010 08:24:52 +0000 (18:24 +1000)]
s4-dns: cope better with comments in dns_update_list
Andrew Bartlett [Tue, 20 Apr 2010 05:00:50 +0000 (15:00 +1000)]
s4:gensec Use a different form of 'name' in GSSAPI import_name()
The idea here is to make it not dependent on the system's default
realm.
Andrew Bartlett
Marcel Ritter [Thu, 22 Apr 2010 12:29:52 +0000 (14:29 +0200)]
Simple fix to prevent crash for non-pac principals
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Andrew Bartlett [Tue, 27 Apr 2010 03:57:39 +0000 (13:57 +1000)]
s4:kerberos Give a better error message than "Could not allocate memory"
Andrew Bartlett
Matthias Dieter Wallnöfer [Tue, 27 Apr 2010 06:19:10 +0000 (08:19 +0200)]
s4:kcc_periodic.c - fix counter types
We are counting LDB objects here -> therefore "unsigned"
Matthias Dieter Wallnöfer [Mon, 26 Apr 2010 18:19:36 +0000 (20:19 +0200)]
s4:wb_cmd_getdcname.c - fix s4 winbind up regarding the new correct "GetAnyDCName" behaviour
We get back "NO_SUCH_DOMAIN" when we query the PDC. This is fine and therefore
we use the "logon_server" variable as "dcname".
Matthias Dieter Wallnöfer [Tue, 13 Apr 2010 20:49:48 +0000 (22:49 +0200)]
s4:netr_DsRAddressToSitenames[Ex]W calls - implement them correctly with the client site information
This behaviour should be similar to the one of Windows Server (in my case 2008)
Matthias Dieter Wallnöfer [Tue, 27 Apr 2010 06:08:42 +0000 (08:08 +0200)]
Revert "s4:netr_DsRAddressToSitenames[Ex]W calls - implement them correctly with the client site information"
This reverts commit
908d982980846257b65ab576d31131e8793e9399.
I need to merge the improved version of this commit.
Matthias Dieter Wallnöfer [Tue, 27 Apr 2010 06:07:19 +0000 (08:07 +0200)]
Revert "s4-netlogon: fixed breakage of dcesrv_netr_GetAnyDCName in sites patch"
This reverts commit
e88a54a87e185b44e2d216bd853e6a87bf950be6.
This isn't the correct behaviour. See MS-NRPC documentation under the
"GetAnyDCName" section.
Andrew Tridgell [Tue, 27 Apr 2010 05:02:29 +0000 (15:02 +1000)]
s4-libnet: cope with an empty client site name from CLDAP
We fall back to the server site name in a vampire
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Tue, 27 Apr 2010 04:25:14 +0000 (14:25 +1000)]
s4-netlogon: fixed breakage of dcesrv_netr_GetAnyDCName in sites patch
We should respond when we are the PDC
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Matthias Dieter Wallnöfer [Wed, 21 Apr 2010 17:30:37 +0000 (19:30 +0200)]
s4:knownfail - remove tests which should pass
Signed-off-by: Andrew Tridgell <tridge@samba.org>
Matthias Dieter Wallnöfer [Wed, 21 Apr 2010 15:54:06 +0000 (17:54 +0200)]
s4:netlogon RPC server - we don't need "are we DC" proofs
When we aren't a DC we shouldn't have the netlogon pipe available.
[MS-NRPC 1.3] says that we can only have DCs on the server side.
Signed-off-by: Andrew Tridgell <tridge@samba.org>
Matthias Dieter Wallnöfer [Thu, 22 Apr 2010 08:37:45 +0000 (10:37 +0200)]
s4:torture - DsRGetDcSiteCoverageW - adapt test to check for the sitename
Signed-off-by: Andrew Tridgell <tridge@samba.org>
Matthias Dieter Wallnöfer [Thu, 22 Apr 2010 08:28:37 +0000 (10:28 +0200)]
s4:dcesrv_netr_DsrGetDcSiteCoverageW - provide a basic implementation
Does for now only return DC's primary site.
Signed-off-by: Andrew Tridgell <tridge@samba.org>
Matthias Dieter Wallnöfer [Wed, 21 Apr 2010 17:13:11 +0000 (19:13 +0200)]
s4:torture - DsRGetSiteName - move "skip" statement before the "computer_name" check
We don't support the check for the computer name on the RPC server side.
Signed-off-by: Andrew Tridgell <tridge@samba.org>
Matthias Dieter Wallnöfer [Sun, 18 Apr 2010 17:01:18 +0000 (19:01 +0200)]
s4:dcesrv_netr_DsRGetSiteName - provide an implementation according to the MS-NRPC docs
Signed-off-by: Andrew Tridgell <tridge@samba.org>
Matthias Dieter Wallnöfer [Tue, 20 Apr 2010 14:59:48 +0000 (16:59 +0200)]
s4:torture - GetAnyDCName - adaptions
- Check for the various domainname set modes (on NULL and "" the domain should
be the default domain on the server)
- support return value "WERR_NO_SUCH_DOMAIN" (the server is the PDC of the
domain)
Signed-off-by: Andrew Tridgell <tridge@samba.org>
Matthias Dieter Wallnöfer [Sun, 18 Apr 2010 13:02:06 +0000 (15:02 +0200)]
s4:dcesrv_netr_GetAnyDCName - improve the call according to the MS-NRPC documentation
This implementation checks if the domainname is valid for us or a trusted domain.
Then I've also added the PDC location functionality. That means that we should
return "WERR_NO_SUCH_DOMAIN" (MS-NRPC 3.5.5.2.5).
Signed-off-by: Andrew Tridgell <tridge@samba.org>
Matthias Dieter Wallnöfer [Wed, 21 Apr 2010 19:39:20 +0000 (21:39 +0200)]
s4:torture - DsRAddressesToSitenames - enhance the testsuite
This shows the Windows behaviour of these two calls which we should match.
Signed-off-by: Andrew Tridgell <tridge@samba.org>
Matthias Dieter Wallnöfer [Tue, 13 Apr 2010 20:49:48 +0000 (22:49 +0200)]
s4:netr_DsRAddressToSitenames[Ex]W calls - implement them correctly with the client site information
This behaviour should be similar to the one of Windows Server (in my case 2008)
Signed-off-by: Andrew Tridgell <tridge@samba.org>
Matthias Dieter Wallnöfer [Sun, 11 Apr 2010 11:17:05 +0000 (13:17 +0200)]
s4:CLDAP server - make use of the new "samdb_client_site_name" call
Signed-off-by: Andrew Tridgell <tridge@samba.org>
Matthias Dieter Wallnöfer [Tue, 13 Apr 2010 16:28:53 +0000 (18:28 +0200)]
s4:util - add a function which finds the matching client site using the client address
The lookup of the client site is done using the subnets in the configuration
partition. If no one matches we use the Windows Server fallback mechansim.
This means: if only one site is available just use it. If they're more set the
output variable to "".
Signed-off-by: Andrew Tridgell <tridge@samba.org>
Andrew Tridgell [Tue, 27 Apr 2010 02:18:02 +0000 (12:18 +1000)]
s4-drsdevel: support sites in drs developer scripts
Andrew Tridgell [Tue, 27 Apr 2010 02:17:36 +0000 (12:17 +1000)]
s4-vampire: show main CLDAP response attributes during vampire
Andrew Tridgell [Tue, 27 Apr 2010 02:17:08 +0000 (12:17 +1000)]
s4-repl: added a workaround for WERR_DS_DRA_NO_REPLICA DsReplicaSync errors
The 0xc0002104/WERR_DS_DRA_NO_REPLICA seems to be spurious, and can be
avoided by setting DRSUAPI_DRS_SYNC_ALL in the DsReplicaSync request.
We need to investigate this further, and find out from MS why this is
sometimes being sent, even when the target DC has the right repsFrom
entries
Jeremy Allison [Tue, 27 Apr 2010 04:36:01 +0000 (21:36 -0700)]
Correctly report share types (now Win7 makes RPC calls against us).
Jeremy.
Jeremy Allison [Tue, 27 Apr 2010 03:11:59 +0000 (20:11 -0700)]
Plumb in get_nt_acl into SMB2.
Jeremy.
Andrew Tridgell [Tue, 27 Apr 2010 01:01:12 +0000 (11:01 +1000)]
s4-dns: fixed dc.dc duplication in DNS update list