metze/samba/wip.git
11 years agoRevert "dcerpc ..." master4-named-pipe
Stefan Metzmacher [Mon, 22 Apr 2013 09:27:44 +0000 (11:27 +0200)]
Revert "dcerpc ..."

This reverts commit 593f3208e68131bb2963fe08cbd26a72ec9b52f2.

11 years agodcerpc ...
Stefan Metzmacher [Tue, 15 Sep 2009 18:29:35 +0000 (20:29 +0200)]
dcerpc ...

11 years agonpecho tests
Stefan Metzmacher [Fri, 4 Sep 2009 13:40:46 +0000 (15:40 +0200)]
npecho tests

11 years agoRevert "lib/util: add tevent_coroutine infrastructure based on Portable Coroutine...
Stefan Metzmacher [Mon, 22 Apr 2013 09:26:17 +0000 (11:26 +0200)]
Revert "lib/util: add tevent_coroutine infrastructure based on Portable Coroutine Library"

This reverts commit 755caa868be41b000cf0f197ad96aaf5f2253189.

11 years agoRevert "example_coro..."
Stefan Metzmacher [Mon, 22 Apr 2013 09:22:36 +0000 (11:22 +0200)]
Revert "example_coro..."

This reverts commit f826b4aa5fb9eab4da068cebe35d52af1fb9450b.

11 years agoRevert "tevent_coroutine: let tevent_coroutine_yield() check for subreq == NULL,...
Stefan Metzmacher [Sat, 22 May 2010 10:07:10 +0000 (12:07 +0200)]
Revert "tevent_coroutine: let tevent_coroutine_yield() check for subreq == NULL, to make the callers easier."

This reverts commit 568884ef8235d3910dc8d51abc76586ab3be71b8.

11 years agoRevert "example_coro: make the callers simpler as tevent_coroutine_yield does the...
Stefan Metzmacher [Sat, 22 May 2010 10:07:03 +0000 (12:07 +0200)]
Revert "example_coro: make the callers simpler as tevent_coroutine_yield does the checks"

This reverts commit 9371dab717c20e8a08afc7826b93e15fca84707e.

11 years agoexample_coro: make the callers simpler as tevent_coroutine_yield does the checks
Stefan Metzmacher [Mon, 4 May 2009 10:24:35 +0000 (12:24 +0200)]
example_coro: make the callers simpler as tevent_coroutine_yield does the checks
and bails out it self

metze

11 years agotevent_coroutine: let tevent_coroutine_yield() check for subreq == NULL, to make...
Stefan Metzmacher [Mon, 4 May 2009 10:23:34 +0000 (12:23 +0200)]
tevent_coroutine: let tevent_coroutine_yield() check for subreq == NULL, to make the callers easier.

Do we want that?

metze

11 years agoexample_coro...
Stefan Metzmacher [Mon, 4 May 2009 09:20:41 +0000 (11:20 +0200)]
example_coro...

11 years agolib/util: add tevent_coroutine infrastructure based on Portable Coroutine Library
Stefan Metzmacher [Sun, 3 May 2009 17:57:35 +0000 (19:57 +0200)]
lib/util: add tevent_coroutine infrastructure based on Portable Coroutine Library

metze

11 years agoRevert "ldap sign|seal"
Stefan Metzmacher [Mon, 4 May 2009 09:38:39 +0000 (11:38 +0200)]
Revert "ldap sign|seal"

This reverts commit fb47681d8d3f4bb92197d5859812ce8fb53409f8.

11 years agoldap sign|seal
Stefan Metzmacher [Mon, 4 May 2009 09:21:41 +0000 (11:21 +0200)]
ldap sign|seal

11 years agoRevert "RPC-NAMEDPIPE01..."
Stefan Metzmacher [Mon, 22 Apr 2013 09:19:55 +0000 (11:19 +0200)]
Revert "RPC-NAMEDPIPE01..."

This reverts commit d53563e8360aaf0bddaddd7597719e4b506adf17.

11 years agoRevert "named_pipe_echo raw mode..."
Stefan Metzmacher [Fri, 1 May 2009 13:14:00 +0000 (15:14 +0200)]
Revert "named_pipe_echo raw mode..."

This reverts commit ed1c9e20717753bc77b23af1614faf95ed1bf120.

11 years agonamed_pipe_echo raw mode...
Stefan Metzmacher [Thu, 30 Apr 2009 15:26:45 +0000 (17:26 +0200)]
named_pipe_echo raw mode...

11 years agoRPC-NAMEDPIPE01...
Stefan Metzmacher [Mon, 20 Apr 2009 12:24:41 +0000 (14:24 +0200)]
RPC-NAMEDPIPE01...

11 years agoRevert "ntlmssp..."
Stefan Metzmacher [Thu, 30 Apr 2009 10:40:01 +0000 (12:40 +0200)]
Revert "ntlmssp..."

This reverts commit 9f6a1da40141083ec514f6841cd616da03c3c749.

11 years agontlmssp...
Stefan Metzmacher [Thu, 30 Apr 2009 10:24:04 +0000 (12:24 +0200)]
ntlmssp...

11 years agonpecho_message_server.c...
Stefan Metzmacher [Mon, 20 Apr 2009 12:32:24 +0000 (14:32 +0200)]
npecho_message_server.c...

11 years agoRevert "tevent debug"
Stefan Metzmacher [Fri, 17 Apr 2009 17:55:45 +0000 (19:55 +0200)]
Revert "tevent debug"

This reverts commit 2be9806dc84bb82392157f650810961acd7dccbd.

11 years agotevent debug
Stefan Metzmacher [Thu, 16 Apr 2009 19:31:40 +0000 (21:31 +0200)]
tevent debug

11 years agoRevert "cldap benchmarks hacks ..."
Stefan Metzmacher [Mon, 22 Apr 2013 09:14:54 +0000 (11:14 +0200)]
Revert "cldap benchmarks hacks ..."

This reverts commit 32860d3d29ca568e5b01e006ff93e39b4c003858.

11 years agocldap benchmarks hacks ...
Stefan Metzmacher [Sat, 28 Mar 2009 22:31:36 +0000 (23:31 +0100)]
cldap benchmarks hacks ...

11 years agoTODO: ...npecho_*3
Stefan Metzmacher [Tue, 10 Feb 2009 10:56:43 +0000 (11:56 +0100)]
TODO: ...npecho_*3

metze

11 years agoRevert "TODO:better name? tsocket: add tsocket_context infrastructure"
Stefan Metzmacher [Sat, 22 May 2010 10:06:53 +0000 (12:06 +0200)]
Revert "TODO:better name? tsocket: add tsocket_context infrastructure"

This reverts commit a7b77d7edb99c805f5ba43ebb1b253cbc5710717.

11 years agoTODO:better name? tsocket: add tsocket_context infrastructure
Stefan Metzmacher [Fri, 3 Apr 2009 14:12:21 +0000 (16:12 +0200)]
TODO:better name? tsocket: add tsocket_context infrastructure

This one only takes care accept_send/recv().

metze

11 years agoFix bug in old create temp SMB request. Only use VFS functions.
Jeremy Allison [Wed, 17 Apr 2013 21:42:20 +0000 (14:42 -0700)]
Fix bug in old create temp SMB request. Only use VFS functions.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Sat Apr 20 21:13:36 CEST 2013 on sn-devel-104

11 years agoEnsure the RECVFILE path in vfs_pwrite_data() operates on a blocking socket.
Jeremy Allison [Mon, 8 Apr 2013 17:49:03 +0000 (10:49 -0700)]
Ensure the RECVFILE path in vfs_pwrite_data() operates on a blocking socket.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan (metze) Metzmacher <metze@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat Apr 20 01:04:05 CEST 2013 on sn-devel-104

11 years agoEnsure the RECVFILE path in vfs_write_data() operates on a blocking socket.
Jeremy Allison [Mon, 8 Apr 2013 17:32:10 +0000 (10:32 -0700)]
Ensure the RECVFILE path in vfs_write_data() operates on a blocking socket.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan (metze) Metzmacher <metze@samba.org>
11 years agoEnsure drain_socket() operates on a blocking socket.
Jeremy Allison [Mon, 8 Apr 2013 17:16:48 +0000 (10:16 -0700)]
Ensure drain_socket() operates on a blocking socket.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan (metze) Metzmacher <metze@samba.org>
11 years agoAdd the internals of is_smb2_recvfile_write.
Jeremy Allison [Mon, 1 Apr 2013 18:16:01 +0000 (11:16 -0700)]
Add the internals of is_smb2_recvfile_write.

This turns on the real receivefile detection, and completes
the receivefile code path changes.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan (metze) Metzmacher <metze@samba.org>
11 years agoThe guts of the receivefile code changes.
Jeremy Allison [Mon, 1 Apr 2013 20:24:07 +0000 (13:24 -0700)]
The guts of the receivefile code changes.

If an incoming PDU might qualify, only read
SMBD_SMB2_SHORT_RECEIVEFILE_WRITE_LEN = (SMB2_HEADER + SMB2_WRITE_BODY_LEN)
bytes rather than the whole PDU.

Next time we're called, use is_smb2_recvfile_write() to decide if
this is an SMB2_WRITE that fit the receivefile criteria, otherwise
just read the rest of the PDU.

If we did do a short receivefile read, set up the smb2_req->smb1req->unread_bytes
value to show what bytes remain in the TCP buffers.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan (metze) Metzmacher <metze@samba.org>
11 years agoAdd stub static function that will turn on/off receivefile code path.
Jeremy Allison [Mon, 1 Apr 2013 20:19:01 +0000 (13:19 -0700)]
Add stub static function that will turn on/off receivefile code path.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan (metze) Metzmacher <metze@samba.org>
11 years agoAdd extra fields into struct smbd_smb2_request_read_state to support receivefile.
Jeremy Allison [Mon, 1 Apr 2013 20:17:09 +0000 (13:17 -0700)]
Add extra fields into struct smbd_smb2_request_read_state to support receivefile.

Initialize min_recv_size with the size that will trigger the
receivefile write path.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan (metze) Metzmacher <metze@samba.org>
11 years agoAdd macro SMBD_SMB2_SHORT_RECEIVEFILE_WRITE_LEN.
Jeremy Allison [Mon, 1 Apr 2013 20:14:13 +0000 (13:14 -0700)]
Add macro SMBD_SMB2_SHORT_RECEIVEFILE_WRITE_LEN.

This is the 'short' length we'll read in the SMB2_WRITE receivefile
code path.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan (metze) Metzmacher <metze@samba.org>
11 years agoAdd utility function get_min_receive_file_size().
Jeremy Allison [Mon, 1 Apr 2013 20:12:55 +0000 (13:12 -0700)]
Add utility function get_min_receive_file_size().

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan (metze) Metzmacher <metze@samba.org>
11 years agoAllow smbd_smb2_request_error_ex() to cope with unread bytes on error.
Jeremy Allison [Tue, 19 Mar 2013 19:36:52 +0000 (12:36 -0700)]
Allow smbd_smb2_request_error_ex() to cope with unread bytes on error.

Drain the socket if a RECVFILE write failed.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan (metze) Metzmacher <metze@samba.org>
11 years agoAdd function smbd_smb2_unread_bytes().
Jeremy Allison [Tue, 19 Mar 2013 19:24:17 +0000 (12:24 -0700)]
Add function smbd_smb2_unread_bytes().

Returns number of bytes left to read for recvfile. Will be
used in SMB_2_WRITE_FILE code path.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan (metze) Metzmacher <metze@samba.org>
11 years agoIf we already have an smb1req attached to the struct smbd_smb2_request, don't recreat...
Jeremy Allison [Tue, 19 Mar 2013 19:16:32 +0000 (12:16 -0700)]
If we already have an smb1req attached to the struct smbd_smb2_request, don't recreate it.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan (metze) Metzmacher <metze@samba.org>
11 years agoEnsure we don't do an SMB2 aio write if RECVFILE is active.
Jeremy Allison [Mon, 18 Mar 2013 19:00:25 +0000 (12:00 -0700)]
Ensure we don't do an SMB2 aio write if RECVFILE is active.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan (metze) Metzmacher <metze@samba.org>
11 years agosamba-tool/dns: Fix a typo in ttl variable name
Amitay Isaacs [Fri, 19 Apr 2013 14:46:19 +0000 (00:46 +1000)]
samba-tool/dns: Fix a typo in ttl variable name

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
11 years agofileserver: raise the debug level for share connection from non IPC to 2
Matthieu Patou [Sat, 26 Jan 2013 22:42:57 +0000 (14:42 -0800)]
fileserver: raise the debug level for share connection from non IPC to 2

So that logs of make test are not spamed, the code dates from 1999 maybe
at that moment we wanted to have some warning I think nodays it's pretty
stable.

Reviewed-by: Jeremy Allison <jra@samba.org>
11 years agos3:locking add NDR debug in share_mode_forall
Christian Ambach [Fri, 19 Apr 2013 09:10:45 +0000 (11:10 +0200)]
s3:locking add NDR debug in share_mode_forall

Reviewed-by: Volker Lendecke <vl@samba.org>
Signed-off-by: Christian Ambach <ambi@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Fri Apr 19 15:06:33 CEST 2013 on sn-devel-104

11 years agos3:rpc_server increase a debug level
Christian Ambach [Fri, 19 Apr 2013 09:21:06 +0000 (11:21 +0200)]
s3:rpc_server increase a debug level

those messages are not worth level 0 or 1 and potentially
clutter the system logs

Reviewed-by: Volker Lendecke <vl@samba.org>
Signed-off-by: Christian Ambach <ambi@samba.org>
11 years agos3:registry increase a debug level
Christian Ambach [Fri, 19 Apr 2013 09:20:38 +0000 (11:20 +0200)]
s3:registry increase a debug level

do not clutter the logs

Reviewed-by: Volker Lendecke <vl@samba.org>
Signed-off-by: Christian Ambach <ambi@samba.org>
11 years agos3:smbd stop working on a dead client socket
Christian Ambach [Fri, 19 Apr 2013 08:04:08 +0000 (10:04 +0200)]
s3:smbd stop working on a dead client socket

when the client has already disconnected, exit server as done
in other paths in smbd_process

Signed-off-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
11 years agos3:smbd increase a loglevel
Christian Ambach [Mon, 8 Apr 2013 16:09:05 +0000 (18:09 +0200)]
s3:smbd increase a loglevel

do not complain too loudly if the socket has already gone

Signed-off-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
11 years agos3:smbstatus do not print orphaned share entries
Christian Ambach [Thu, 18 Apr 2013 15:09:32 +0000 (17:09 +0200)]
s3:smbstatus do not print orphaned share entries

Pair-Programmed-With: Volker Lendecke <vl@samba.org>
Signed-off-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
11 years agosmbd: Fix signing when the async echo handler kicks in
Volker Lendecke [Fri, 19 Apr 2013 10:36:08 +0000 (12:36 +0200)]
smbd: Fix signing when the async echo handler kicks in

This was introduced as a copy&paste error in 5e0258fc932c

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Christian Ambach <ambi@samba.org>
11 years agos4:dsdb: Fix warnings about not set / set but unused / shadowed variables
Matthieu Patou [Fri, 12 Apr 2013 05:30:27 +0000 (22:30 -0700)]
s4:dsdb: Fix warnings about not set / set but unused / shadowed variables

Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Fri Apr 19 13:15:40 CEST 2013 on sn-devel-104

11 years agos3:smbd:smb2:scavenger: fix format error for debugging open_persistent_id in scavenge...
Michael Adam [Thu, 18 Apr 2013 21:45:24 +0000 (23:45 +0200)]
s3:smbd:smb2:scavenger: fix format error for debugging open_persistent_id in scavenger_timer()

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Apr 19 01:36:15 CEST 2013 on sn-devel-104

11 years agotalloc: Simplify _talloc_free_poolmem a bit
Volker Lendecke [Mon, 15 Apr 2013 20:19:25 +0000 (22:19 +0200)]
talloc: Simplify _talloc_free_poolmem a bit

Early returns are easier to understand than "else if"

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Apr 18 22:50:42 CEST 2013 on sn-devel-104

11 years agotalloc: Do an early return
Volker Lendecke [Mon, 15 Apr 2013 20:12:50 +0000 (22:12 +0200)]
talloc: Do an early return

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
11 years agotalloc: Avoid some "else" by doing early returns
Volker Lendecke [Mon, 15 Apr 2013 20:11:44 +0000 (22:11 +0200)]
talloc: Avoid some "else" by doing early returns

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
11 years agotalloc: Fix nonblank line endings
Volker Lendecke [Mon, 15 Apr 2013 19:44:38 +0000 (21:44 +0200)]
talloc: Fix nonblank line endings

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
11 years agoselftest: S3 does not do leases yet
Volker Lendecke [Wed, 17 Apr 2013 15:19:59 +0000 (17:19 +0200)]
selftest: S3 does not do leases yet

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Thu Apr 18 16:59:39 CEST 2013 on sn-devel-104

11 years agos4:torture/smb2: add v2 lease requests
Stefan Metzmacher [Wed, 31 Oct 2012 08:07:19 +0000 (09:07 +0100)]
s4:torture/smb2: add v2 lease requests

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
11 years agos4:torture/smb2: add smb2_lease_v2_create_share() helper
Stefan Metzmacher [Wed, 31 Oct 2012 08:06:48 +0000 (09:06 +0100)]
s4:torture/smb2: add smb2_lease_v2_create_share() helper

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
11 years agos4:libcli/smb2: add support for SMB2 LEASES v2
Stefan Metzmacher [Wed, 31 Oct 2012 07:37:13 +0000 (08:37 +0100)]
s4:libcli/smb2: add support for SMB2 LEASES v2

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
11 years agolibcli/smb: add SMB2_LEASE_FLAG_* defines
Stefan Metzmacher [Wed, 31 Oct 2012 07:19:52 +0000 (08:19 +0100)]
libcli/smb: add SMB2_LEASE_FLAG_* defines

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
11 years agos4:torture/smb2: add NTCREATEX_SHARE_ACCESS_DELETE in smb2_generic_create_share()
Stefan Metzmacher [Thu, 1 Nov 2012 15:20:35 +0000 (16:20 +0100)]
s4:torture/smb2: add NTCREATEX_SHARE_ACCESS_DELETE in smb2_generic_create_share()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
11 years agos4:torture:smb2 delete temp memory context in test_durable_open_oplock_disconnect
Gregor Beck [Wed, 3 Apr 2013 07:27:26 +0000 (09:27 +0200)]
s4:torture:smb2 delete temp memory context in test_durable_open_oplock_disconnect

Signed-off-by: Gregor Beck <gbeck@sernet.de>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Thu Apr 18 15:10:31 CEST 2013 on sn-devel-104

11 years agos4:torture:smb2:durable_v2: remove an unused variable
Michael Adam [Thu, 17 Jan 2013 21:17:42 +0000 (22:17 +0100)]
s4:torture:smb2:durable_v2: remove an unused variable

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
11 years agos3:smbd: call scavenger_schedule_disconnected() from close normal file for durable...
Gregor Beck [Wed, 20 Mar 2013 09:01:43 +0000 (10:01 +0100)]
s3:smbd: call scavenger_schedule_disconnected() from close normal file for durable handles

Signed-off-by: Gregor Beck <gbeck@sernet.de>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
11 years agos3:smbd: add a scavenger process for disconnected durable handles
Gregor Beck [Thu, 7 Feb 2013 14:26:37 +0000 (15:26 +0100)]
s3:smbd: add a scavenger process for disconnected durable handles

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

Signed-off-by: Gregor Beck <gbeck@sernet.de>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
11 years agos3:locking: add function share_mode_cleanup_disconnected()
Gregor Beck [Wed, 13 Mar 2013 10:35:37 +0000 (11:35 +0100)]
s3:locking: add function share_mode_cleanup_disconnected()

For a given file, clean share mode entries for a given persistent file id.

Pair-Programmed-With: Michael Adam <obnox@samba.org>
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

Signed-off-by: Gregor Beck <gbeck@sernet.de>
Signed-off-by: Michael Adam <obnox@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agos3:locking: improve debug output of parse_share_modes()
Gregor Beck [Wed, 20 Mar 2013 09:22:06 +0000 (10:22 +0100)]
s3:locking: improve debug output of parse_share_modes()

Signed-off-by: Gregor Beck <gbeck@sernet.de>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
11 years agos3:locking: no need to make a file_id passed by value a constant
Gregor Beck [Tue, 12 Mar 2013 14:10:51 +0000 (15:10 +0100)]
s3:locking: no need to make a file_id passed by value a constant

Signed-off-by: Gregor Beck <gbeck@sernet.de>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
11 years agos3:locking:brlock: add function brl_cleanup_disconnected()
Gregor Beck [Wed, 13 Mar 2013 13:47:18 +0000 (14:47 +0100)]
s3:locking:brlock: add function brl_cleanup_disconnected()

For a given file, clean up brl entries belonging to a given persistent file id.

Signed-off-by: Gregor Beck <gbeck@sernet.de>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
11 years agos3:locking:brlock: explain the lockdb_clean semantic better in brl_reconnect_disconne...
Michael Adam [Fri, 12 Apr 2013 09:13:57 +0000 (11:13 +0200)]
s3:locking:brlock: explain the lockdb_clean semantic better in brl_reconnect_disconnected()

Signed-off-by: Michael Adam <obnox@samba.org>
Signed-off-by: Gregor Beck <gbeck@sernet.de>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
11 years agos3:locking:brlock: let validate_lock_entries keep entries for disconnected servers...
Gregor Beck [Tue, 5 Mar 2013 13:49:28 +0000 (14:49 +0100)]
s3:locking:brlock: let validate_lock_entries keep entries for disconnected servers in traverses

We should not remove locks of disconnected opens just like that.
When getting the byte range lock record for a newly connected file
handle, we still do the clean up, because in that situation,
disconnected entries are not valid any more.

Signed-off-by: Gregor Beck <gbeck@sernet.de>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
11 years agos3:locking:brlock: improve the comment for the brl self cleaning code
Michael Adam [Fri, 12 Apr 2013 09:05:29 +0000 (11:05 +0200)]
s3:locking:brlock: improve the comment for the brl self cleaning code

Signed-off-by: Michael Adam <obnox@samba.org>
Signed-off-by: Gregor Beck <gbeck@sernet.de>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
11 years agos3:locking:brlock: use serverids_exist to validate_lock_entries
Gregor Beck [Tue, 5 Mar 2013 13:02:10 +0000 (14:02 +0100)]
s3:locking:brlock: use serverids_exist to validate_lock_entries

...instead of checking each server-id separately which can
be expensive in a cluster.

Signed-off-by: Gregor Beck <gbeck@sernet.de>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
11 years agos3:smbXsrv_open: add function smbXsrv_open_cleanup()
Gregor Beck [Tue, 12 Mar 2013 13:36:32 +0000 (14:36 +0100)]
s3:smbXsrv_open: add function smbXsrv_open_cleanup()

Signed-off-by: Gregor Beck <gbeck@sernet.de>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
11 years agos3:smbXsrv_open: factor out smbXsrv_open_global_parse_record
Gregor Beck [Tue, 12 Mar 2013 12:43:30 +0000 (13:43 +0100)]
s3:smbXsrv_open: factor out smbXsrv_open_global_parse_record

Signed-off-by: Gregor Beck <gbeck@sernet.de>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
11 years agos3:net registry check: use tdb_data_string()
Gregor Beck [Thu, 28 Mar 2013 09:28:21 +0000 (10:28 +0100)]
s3:net registry check: use tdb_data_string()

Signed-off-by: Gregor Beck <gbeck@sernet.de>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
11 years agoutil_tdb: add function tdb_data_string()
Gregor Beck [Wed, 20 Mar 2013 08:56:54 +0000 (09:56 +0100)]
util_tdb: add function tdb_data_string()

Signed-off-by: Gregor Beck <gbeck@sernet.de>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
11 years agos3:winbindd: avoid usage of procid_self()
Stefan Metzmacher [Mon, 15 Apr 2013 09:28:47 +0000 (11:28 +0200)]
s3:winbindd: avoid usage of procid_self()

metze

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
11 years agos3:smbd:smb2: fix setting of scavenge timeout when reconnecting durable handles
Michael Adam [Thu, 18 Apr 2013 11:11:03 +0000 (13:11 +0200)]
s3:smbd:smb2: fix setting of scavenge timeout when reconnecting durable handles

The bug fixed with this commit led to reconnected durable handles
having a disconnect timeout of 0 msec. This fix re-establishes the
original timeout for the reconnected handle.

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Michael Adam <obnox@samba.org>
11 years agonetcmd/dns: fix typo
David Disseldorp [Thu, 18 Apr 2013 08:32:44 +0000 (10:32 +0200)]
netcmd/dns: fix typo

Fix provided by Tobias Florek.

Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Thu Apr 18 12:40:33 CEST 2013 on sn-devel-104

11 years agosmbd: Remove NTSTATUS based create_synthetic_smb_fname
Volker Lendecke [Mon, 15 Apr 2013 09:56:59 +0000 (11:56 +0200)]
smbd: Remove NTSTATUS based create_synthetic_smb_fname

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Apr 18 02:52:40 CEST 2013 on sn-devel-104

11 years agosmbd: Convert create_file_unixpath to synthetic_smb_fname
Volker Lendecke [Mon, 15 Apr 2013 09:55:53 +0000 (11:55 +0200)]
smbd: Convert create_file_unixpath to synthetic_smb_fname

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
11 years agosmbd: Convert is_visible_file to synthetic_smb_fname
Volker Lendecke [Mon, 15 Apr 2013 09:54:46 +0000 (11:54 +0200)]
smbd: Convert is_visible_file to synthetic_smb_fname

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
11 years agosmbd: Convert dptr_create to synthetic_smb_fname
Volker Lendecke [Mon, 15 Apr 2013 09:53:32 +0000 (11:53 +0200)]
smbd: Convert dptr_create to synthetic_smb_fname

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
11 years agosmbd: Convert print_spool_open to synthetic_smb_fname
Volker Lendecke [Mon, 15 Apr 2013 09:51:59 +0000 (11:51 +0200)]
smbd: Convert print_spool_open to synthetic_smb_fname

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
11 years agosmbd: Convert driver_unlink_internals to synthetic_smb_fname
Volker Lendecke [Mon, 15 Apr 2013 09:50:51 +0000 (11:50 +0200)]
smbd: Convert driver_unlink_internals to synthetic_smb_fname

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
11 years agovfstest: Convert cmd_set_nt_acl to synthetic_smb_fname
Volker Lendecke [Mon, 15 Apr 2013 09:49:54 +0000 (11:49 +0200)]
vfstest: Convert cmd_set_nt_acl to synthetic_smb_fname

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
11 years agovfstest: Convert cmd_utime to synthetic_smb_fname
Volker Lendecke [Mon, 15 Apr 2013 09:49:09 +0000 (11:49 +0200)]
vfstest: Convert cmd_utime to synthetic_smb_fname

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
11 years agovfstest: Convert cmd_lstat to synthetic_smb_fname
Volker Lendecke [Mon, 15 Apr 2013 09:48:05 +0000 (11:48 +0200)]
vfstest: Convert cmd_lstat to synthetic_smb_fname

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
11 years agovfstest: Convert cmd_stat to synthetic_smb_fname
Volker Lendecke [Mon, 15 Apr 2013 09:47:17 +0000 (11:47 +0200)]
vfstest: Convert cmd_stat to synthetic_smb_fname

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
11 years agovfstest: Convert cmd_rename to synthetic_smb_fname
Volker Lendecke [Mon, 15 Apr 2013 09:46:24 +0000 (11:46 +0200)]
vfstest: Convert cmd_rename to synthetic_smb_fname

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
11 years agovfstest: Convert cmd_pathfunc to synthetic_smb_fname
Volker Lendecke [Mon, 15 Apr 2013 09:44:35 +0000 (11:44 +0200)]
vfstest: Convert cmd_pathfunc to synthetic_smb_fname

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
11 years agovfstest: Convert cmd_open to synthetic_smb_fname
Volker Lendecke [Mon, 15 Apr 2013 09:43:38 +0000 (11:43 +0200)]
vfstest: Convert cmd_open to synthetic_smb_fname

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
11 years agovfs: Convert dirsort_opendir to synthetic_smb_fname
Volker Lendecke [Mon, 15 Apr 2013 09:42:38 +0000 (11:42 +0200)]
vfs: Convert dirsort_opendir to synthetic_smb_fname

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
11 years agovfs: Convert vfs_scannedonly to synthetic_smb_fname
Volker Lendecke [Mon, 15 Apr 2013 09:41:26 +0000 (11:41 +0200)]
vfs: Convert vfs_scannedonly to synthetic_smb_fname

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
11 years agosmbd: Convert set_create_timespec_ea to synthetic_smb_fname
Volker Lendecke [Mon, 15 Apr 2013 09:36:30 +0000 (11:36 +0200)]
smbd: Convert set_create_timespec_ea to synthetic_smb_fname

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
11 years agosmbd: Convert unix_mode to synthetic_smb_fname
Volker Lendecke [Mon, 15 Apr 2013 09:30:50 +0000 (11:30 +0200)]
smbd: Convert unix_mode to synthetic_smb_fname

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
11 years agosmbd: Convert rmdir_internals to synthetic_smb_fname
Volker Lendecke [Mon, 15 Apr 2013 09:28:47 +0000 (11:28 +0200)]
smbd: Convert rmdir_internals to synthetic_smb_fname

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
11 years agosmbd: Convert recursive_rmdir to synthetic_smb_fname
Volker Lendecke [Mon, 15 Apr 2013 09:27:35 +0000 (11:27 +0200)]
smbd: Convert recursive_rmdir to synthetic_smb_fname

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>