Stefan Metzmacher [Wed, 26 Nov 2008 22:09:06 +0000 (23:09 +0100)]
s3:selftest: test the streams_depot module as it passes make test
The streams_xattr module only passes sometimes on my laptop.
metze
Stefan Metzmacher [Wed, 26 Nov 2008 21:58:50 +0000 (22:58 +0100)]
s3:smbd: close the low level fd of the base_fsp, if the file was created
metze
Stefan Metzmacher [Wed, 26 Nov 2008 21:57:27 +0000 (22:57 +0100)]
s3:streams_xattr: fstat should do a stat on the base file
The behavior of stat and fstat should be the same.
metze
Stefan Metzmacher [Tue, 25 Nov 2008 20:09:20 +0000 (21:09 +0100)]
s3:streams_xattr: recheck fsp->fsp_name after a rename
metze
Stefan Metzmacher [Wed, 26 Nov 2008 19:55:33 +0000 (20:55 +0100)]
s3:smbd: give the correct error when trying to replace a stream
metze
Stefan Metzmacher [Wed, 26 Nov 2008 19:54:41 +0000 (20:54 +0100)]
s3:vfs: fix FCHMOD_ACL macros
metze
Stefan Metzmacher [Wed, 26 Nov 2008 12:58:30 +0000 (13:58 +0100)]
s3:streams_depot: add an option to disable the xattr checks
streams_depot:check_valid=no is useful when the filesystem
has no xattr support and files are only published via samba.
metze
Stefan Metzmacher [Wed, 26 Nov 2008 12:56:31 +0000 (13:56 +0100)]
s3:streams_depot: fix valgrind bug lp_parm_const_string() doesn't talloc the default value
metze
Stefan Metzmacher [Wed, 26 Nov 2008 11:40:06 +0000 (12:40 +0100)]
s3:streams_depot: add support for stream renames
metze
Stefan Metzmacher [Wed, 26 Nov 2008 11:39:07 +0000 (12:39 +0100)]
s3:streams_depot: map 'file::$DATA' to just 'file'
metze
Stefan Metzmacher [Tue, 25 Nov 2008 19:25:22 +0000 (20:25 +0100)]
s3:streams_xattr: add support for renaming streams
metze
Stefan Metzmacher [Wed, 26 Nov 2008 13:04:08 +0000 (14:04 +0100)]
s3:smbd: only try and fallback to open a directory if it's not a stream open
metze
Stefan Metzmacher [Tue, 25 Nov 2008 20:02:25 +0000 (21:02 +0100)]
s3:smbd: write times should be set on the base file instead of the stream name
metze
Stefan Metzmacher [Tue, 25 Nov 2008 19:09:28 +0000 (20:09 +0100)]
s3:smbd: return DELETE_PENDING on path based operations on streams, when the main file was deleted.
metze
Stefan Metzmacher [Tue, 25 Nov 2008 19:04:28 +0000 (20:04 +0100)]
s3:smbd: construct the correct newname for stream renames
The Windows Explorer creates temporary streams and renames
them later via SFILEINFO_RENAME_INFO. The newname comes
in as ":Stream:$DATA".
metze
Stefan Metzmacher [Mon, 24 Nov 2008 18:36:52 +0000 (19:36 +0100)]
s3:smbd: wildcard characters are allowed in stream names
We only check the filename of the basefile now.
metze
Stefan Metzmacher [Mon, 24 Nov 2008 16:13:34 +0000 (17:13 +0100)]
s3:smbd: correctly verify stream names to pass RAW-STREAMS
metze
Stefan Metzmacher [Mon, 24 Nov 2008 18:34:50 +0000 (19:34 +0100)]
s3:smbd: '|' isn't allowed in windows filenames
metze
Andreas Schneider [Wed, 26 Nov 2008 21:19:03 +0000 (13:19 -0800)]
Fix circular dependency error with autoconf 2.6.3.
Signed-off-by: Andreas Schneider <anschneider@suse.de>
Jeremy Allison [Tue, 25 Nov 2008 23:55:46 +0000 (15:55 -0800)]
Fix bug #5914 - Build failure: redefinition of struct name_list
Jeremy.
Günther Deschner [Tue, 25 Nov 2008 11:19:35 +0000 (12:19 +0100)]
s3-samr: fix _samr_LookupNames return code.
Guenther
(cherry picked from commit
dc7c2d63b3ce142959aa863f000fa9140de99eb0)
Michael Adam [Tue, 25 Nov 2008 14:23:31 +0000 (15:23 +0100)]
zfsacl: return is not a function.
Michael
Nils Goroll [Mon, 17 Nov 2008 00:06:28 +0000 (01:06 +0100)]
zfsacl: Prevent calling POSIX ACL vfs methods on zfs share.
This is a proposed fix for Bugs #5135 and #5446.
Signed-off-by: Michael Adam <obnox@samba.org>
Dan Sledz [Mon, 17 Nov 2008 01:40:03 +0000 (17:40 -0800)]
[PATCH] Allow SYSLOG_FACILITY to be modified with a new configure option called --with-syslog-facility
Jeremy Allison [Mon, 24 Nov 2008 23:29:17 +0000 (15:29 -0800)]
Fix bug #5873 - ACL inheritance cannot be broken. This regresses #4308, but that will have to
be fixed another way.
Jeremy.
Mathias Dietz [Wed, 12 Nov 2008 13:32:45 +0000 (14:32 +0100)]
Search for gpfs functions in both libgpfs_gpl.so an libgpfs.so
As of GPFS 3.2.1 PTF8 libgpfs will be available as GPL, so we don't need the
special libgpfs_gpl lib anymore. For backwards compatibility with pre-PTF8 GPFS
installations, still look there.
(cherry picked from commit
61468186cece7370576a2d13992f9a523067e4be)
Signed-off-by: Michael Adam <obnox@samba.org>
Stefan Metzmacher [Mon, 24 Nov 2008 14:07:56 +0000 (15:07 +0100)]
libads/ldap.c: return an error instead of crashing when no realm is given
The bug was triggered by "net ads info -S 127.8.7.6" (where 127.8.7.6 doesn't exist)
and "disable netbios = yes".
metze
Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
e2a60d2e1fd7455f08e73f8d1c513ca240c0f0af)
Jeremy Allison [Sat, 22 Nov 2008 06:44:23 +0000 (22:44 -0800)]
Revert
c76e4791d3ae4f180fba209c29bd3774c00858cf - "Fix the logic bug that caused us to run into kernel oplocks on an open for a stream inside a file with stream_xattr module. On opening the base_fsp we must break existing oplocks." as it broke make test.
Jeremy.
Jeremy Allison [Sat, 22 Nov 2008 02:21:34 +0000 (18:21 -0800)]
Merge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
Jeremy Allison [Sat, 22 Nov 2008 02:19:13 +0000 (18:19 -0800)]
Fix the logic bug that caused us to run into kernel oplocks on an open for a stream inside a file with stream_xattr module. On opening the base_fsp we must break existing oplocks.
Jeremy.
Dan Sledz [Sat, 15 Nov 2008 02:41:17 +0000 (18:41 -0800)]
[PATCH] FreeBSD configure check for backtrace_symbols
On FreeBSD backtrace_symbols is defined in libexecinfo.so.1. Look for it
there as well.
Jeremy Allison [Sat, 22 Nov 2008 00:04:31 +0000 (16:04 -0800)]
Use fxattr calls whenever possible (trying to work around the strange Linux kernel oplock bug).
Jeremy.
Michael Adam [Sun, 21 Sep 2008 00:07:43 +0000 (02:07 +0200)]
winbindd_group: don't list the domain twice when expanding internal aliases
Before this, "getent group builtin\\administrators" expanded
domain group members in the form DOMAIN\domain\user.
Michael
Michael Adam [Sun, 21 Sep 2008 00:06:44 +0000 (02:06 +0200)]
winbindd_group: sanely handle NULL domain in add_member().
Michael
Michael Adam [Mon, 22 Sep 2008 08:39:37 +0000 (10:39 +0200)]
winbindd_ads: honour "winbind use default domain" in lookup_groupmem().
This fixes the output of "getent group" when "winbind use default domain = yes"
with security = ads.
Michael
Michael Adam [Sat, 20 Sep 2008 23:20:32 +0000 (01:20 +0200)]
winbindd_rpc: add domain prefix to username in lookup_groupmem().
This makes the output of "getent group" of a domain group show the
domain prefix with "security = domain".
Michael
Michael Adam [Mon, 22 Sep 2008 08:37:11 +0000 (10:37 +0200)]
winbindd_util: add fill_domain_username_talloc().
A talloc version of fill_domain_username().
Michael
Michael Adam [Mon, 22 Sep 2008 12:51:51 +0000 (14:51 +0200)]
winbindd: fix a comment typo
Michael
Michael Adam [Mon, 22 Sep 2008 08:34:57 +0000 (10:34 +0200)]
winbind_util: fix an implicit cast compile warning.
Michael
Michael Adam [Fri, 21 Nov 2008 22:28:08 +0000 (23:28 +0100)]
winbindd: make all winbind rpc-methods static.
Now that the methods are no longer needed in winbindd_ads,
we can make them static again.
Michael
Michael Adam [Fri, 21 Nov 2008 01:24:06 +0000 (02:24 +0100)]
winbindd_ads: use the reconnect methods instead of the rpc methods directly
Some of the ads methods just point to the rpc methods.
This makes winbindd_ads use the reconnect methods instead of
calling the rpc methods directly in order to prevent
negative cache entries for e.g. name_to_sid, when the dc
has closed the connection without sending a reset.
Michael
Michael Adam [Thu, 20 Nov 2008 22:26:35 +0000 (23:26 +0100)]
winbindd_ads: prevent negative GM/ cache entries due to broken connections
The ads lookup_groupmem() function calls lda_lookupsids to resolve sids
to names. This is tried only once. So in case the connection was broken,
e.g. closed by the server (without a reset packet), there will be an empty
GM/ cache entry for the requested group which will prevent proper working
of access checks among other checks for the expiry period.
This patch works around this problem by retrying once if the lsa_lookupsids
call fails, re-establishing the dc-connection, as we already do in many other
places (e.g. the winbindd retry methods for the rpc layer).
Michael
Jeremy Allison [Fri, 21 Nov 2008 20:32:11 +0000 (12:32 -0800)]
Second part of the fix for bug #5903 - vfs_streams_xattr breaks contents of the file
Jeremy.
Jeremy Allison [Fri, 21 Nov 2008 19:06:33 +0000 (11:06 -0800)]
Ensure we always reply in reply_printopen().
Jeremy.
Jeremy Allison [Fri, 21 Nov 2008 18:46:31 +0000 (10:46 -0800)]
First part of fix for bug #5903 - vfs_streams_xattr breaks contents of the file.
Restructures parts of open code so that fsp must be allocated before calling
open_file_ntcreate(_internal). Also fix up file ref-counting inside files.c.
Jeremy.
Yasuma Takeda [Thu, 20 Nov 2008 19:36:51 +0000 (11:36 -0800)]
Fix bug #5909 - MS-DFS does not work on Vista, if link name includes multibyte character.
Jeremy Allison [Thu, 20 Nov 2008 18:55:23 +0000 (10:55 -0800)]
Second part of fix for bug #5891 - smbd crashed when viewing the eventlog exported by "eventlog list". Don't leak memory on error paths.
Jeremy.
Michael Adam [Thu, 20 Nov 2008 15:31:44 +0000 (16:31 +0100)]
eventlog: don't crash in sync_eventlog_params().
When freeing the talloc ctx at the end of the routine,
it must be a talloc ctx created inside. talloc_tos() needs
to be valid after the function finishes, since callers
(may) have data attached to it.
Michael
Signed-off-by: Günther Deschner <gd@samba.org>
(cherry picked from commit
113c5d28edabdd17a2507e68aad612aa21c758f3)
Jeremy Allison [Thu, 20 Nov 2008 00:48:53 +0000 (16:48 -0800)]
This code mixes up int and uint32 when pulling out of a TDB. This is very bad. Fixing... May fix bug #5891, not sure.
Jeremy.
Jeremy Allison [Wed, 19 Nov 2008 19:31:05 +0000 (11:31 -0800)]
Fix error in commit for bugfix "Fix bug #5904 - libnss_wins causes SIGABRT while servicing getaddrinfo() request."
Jeremy.
Jeremy Allison [Wed, 19 Nov 2008 19:23:11 +0000 (11:23 -0800)]
Fix bug #5904 - libnss_wins causes SIGABRT while servicing getaddrinfo() request.
Jeremy.
Steven Danneman [Sat, 15 Nov 2008 21:07:15 +0000 (13:07 -0800)]
Fix extended DN parse error when AD object does not have a SID.
Some AD objects, like Exchange Public Folders, can be members of Security
Groups but do not have a SID attribute. This patch adds more granular return
errors to ads_get_sid_from_extended_dn(). Callers can now determine if a parse
error occured because of bad input, or the DN was valid but contained no SID.
I updated all callers to ignore SIDless objects when appropriate.
Also did some cleanup to the out paths of lookup_usergroups_memberof()
Steven Danneman [Sat, 15 Nov 2008 03:16:12 +0000 (19:16 -0800)]
Whitespace and >80 column cleanups.
Günther Deschner [Tue, 18 Nov 2008 22:10:22 +0000 (23:10 +0100)]
Fix Bug #5898. ("net rpc shutdown" fails).
Guenther
Dina Fine [Tue, 18 Nov 2008 20:44:19 +0000 (12:44 -0800)]
Fix bug #5908 - Samba 3.0.32 - internal change notify on share directory fails"
Kai Blin [Tue, 18 Nov 2008 15:31:34 +0000 (16:31 +0100)]
libsmb: Fix up pointer passed to cli_send_trans in cli_link_internal
Seems like this one fell victim to the pstring removal. The other callers seem
to be fine, even though removing the casts would make the code less confusing.
Jeremy Allison [Tue, 18 Nov 2008 18:58:48 +0000 (10:58 -0800)]
Re-structure Volker's patch to "Fix trans2findfirst for the large directory optimization". Makes the change clearer.
Jeremy.
Volker Lendecke [Tue, 18 Nov 2008 16:03:38 +0000 (17:03 +0100)]
Fix trans2findfirst for the large directory optimization
With
case sensitive = yes
preserve case = no
short preserve case = no
default case = upper
a "dir FOO.txt" would not find "FOO.TXT" because FOO.txt ends up unconverted in
the mask for mask_match.
Jeremy, please check!
Volker
(cherry picked from commit
0dbcc308e30b121268cdfcdd70c50c4ed38ab433)
Davide Sfriso [Mon, 17 Nov 2008 23:40:43 +0000 (15:40 -0800)]
Fix bug #5906 when running winbindd on a Samba PDC. Winbindd crash on 'getent group'.
Jeremy Allison [Mon, 17 Nov 2008 22:05:55 +0000 (14:05 -0800)]
When clearing out vuid cache remember to set entries = 0.
Jeremy.
Jeremy Allison [Mon, 17 Nov 2008 21:46:35 +0000 (13:46 -0800)]
Fix bug #5900 reported by monyo@samba.gr.jp - vfs_readonly.so does not work.
Jeremy.
Karolin Seeger [Mon, 17 Nov 2008 14:23:34 +0000 (15:23 +0100)]
s3 create-tarball.sh: Remove dashes in git commands.
Newer git versions (e.g. 1.6.0.2) do not provide the 'git-' commands
any longer.
Karolin
(cherry picked from commit
0cba859f12177aaf3ef2d96663f0a51f61c24d56)
(cherry picked from commit
3d64e67de2b50f7b781aa3f5ad13ec8e866d4333)
(cherry picked from commit
aa41a80969bd413d5922c602c7309bd8c05f3181)
Carsten Dumke [Thu, 13 Nov 2008 18:05:00 +0000 (12:05 -0600)]
net: Fix documentation of net rap printq info
The man-page (see net(8)) and the usage-info (call "net help rap printq") of
'net rap printq' do contain an option "list" but in net_rap.c
the option is named "info".
Rename the option "list" in the documentation (man-pages + usage) to "info" to
match the code.
Signed-off-by: Kai Blin <kai@samba.org>
TAKAHASHI Motonobu [Sun, 16 Nov 2008 12:17:16 +0000 (13:17 +0100)]
Fix bug 5901: Default for streams_depot location
Günther Deschner [Tue, 15 Jul 2008 21:05:13 +0000 (23:05 +0200)]
fix build warning.
Guenther
(This used to be commit
507660706901a79544d436046127947e4baa7e52)
(cherry picked from commit
1939177582867fb54a416f3ea979ebd8d4335885)
Volker Lendecke [Fri, 14 Nov 2008 12:42:54 +0000 (13:42 +0100)]
Make memcache_add_talloc NULL out the source pointer
This is an orthogonality measure to make clear this pointer now belongs to the
cache.
Volker Lendecke [Thu, 13 Nov 2008 22:50:19 +0000 (23:50 +0100)]
Actually finish memcache_add_talloc
This fixes a memleak found by Martin Zielinski <mz@seh.de>. Thanks for
looking closely!
Volker
Volker Lendecke [Sat, 14 Jun 2008 08:59:11 +0000 (10:59 +0200)]
Use the correct cups-devel test for HAVE_IPRINT also
(cherry picked from commit
a42d7e1146e7469062ead2c8f22f549a48154e03)
Volker Lendecke [Sat, 14 Jun 2008 08:31:11 +0000 (10:31 +0200)]
Correctly check for presence of cups-devel
On SuSE at least cups-config belongs to cups-libs which does not contain the
headers which are in cups-devel.
(cherry picked from commit
2408d2493f7c6e0beee58febd547516bbeb0929d)
Günther Deschner [Fri, 14 Nov 2008 18:49:11 +0000 (19:49 +0100)]
winbind: fix build warning.
Guenther
Günther Deschner [Fri, 14 Nov 2008 16:53:29 +0000 (17:53 +0100)]
make some more parts of security.idl public and re-run make idl.
Guenther
Günther Deschner [Fri, 14 Nov 2008 15:12:34 +0000 (16:12 +0100)]
re-run make idl.
Guenther
(cherry picked from commit
19568f4e4e94266a7792e6dce8eaa5086f435fc3)
Stefan Metzmacher [Fri, 7 Nov 2008 09:49:59 +0000 (10:49 +0100)]
security.idl: sometimes ACEs have some padding at the end
metze
(cherry picked from commit
2dc120377baec2c8b7c9b6fe40d15218588c97fd)
Volker Lendecke [Fri, 14 Nov 2008 12:13:40 +0000 (13:13 +0100)]
Rename some variables in getpwnam_alloc() for clarity
Volker Lendecke [Fri, 14 Nov 2008 11:49:18 +0000 (12:49 +0100)]
sys_pwnam doesn't return talloced memory, so don't mix up the returned struct.
Günther Deschner [Thu, 13 Nov 2008 20:11:12 +0000 (21:11 +0100)]
re-run make idl.
Guenther
(cherry picked from commit
86deff8d6e6b8e094b15a4e5392098d9b23e5ff5)
Günther Deschner [Thu, 13 Nov 2008 20:11:31 +0000 (21:11 +0100)]
Fix PNP_GetHwProfInfo() (fixes Bug: #5888).
Guenther
(cherry picked from commit
111ec984729fe2c47e173dab82f438bcacf42d1c)
Jeremy Allison [Thu, 13 Nov 2008 03:28:04 +0000 (19:28 -0800)]
Merge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into samba-3-2-test
Jeremy Allison [Thu, 13 Nov 2008 03:26:58 +0000 (19:26 -0800)]
Pretty print out SD's on get/set.
Jeremy.
Jeremy Allison [Wed, 12 Nov 2008 22:03:54 +0000 (14:03 -0800)]
Fix memory leak in error path, spotted by Martin Zielinski <mz@seh.de>.
Jeremy.
Jeremy Allison [Tue, 11 Nov 2008 22:38:36 +0000 (14:38 -0800)]
Fix bug 5891] : smbd crashed when viewing the eventlog exported by "eventlog list"
Don't mix TALLOC and SAFE_FREE().
Jeremy.
Jeremy Allison [Tue, 11 Nov 2008 22:20:53 +0000 (14:20 -0800)]
Fix bug 5889. "delete veto files = no" seems to break.
Jeremy.
Michael Adam [Mon, 10 Nov 2008 14:01:18 +0000 (15:01 +0100)]
build: prevent make errors for picky makes when $(EXTRA_ALL_TARGETS) is empty
picky make implementations don't like lines with only tabs in rules or dependencie
Michael
Martin Schwenke [Fri, 7 Nov 2008 01:20:59 +0000 (12:20 +1100)]
Add @CIFSUPCALL_PROGS@ to "all" target so cifs.upcall gets built at
compile time rather than install time. This stops problems where
packaging scripts pass CFLAGS to "make" but not "make install".
Signed-off-by: Martin Schwenke <martin@meltin.net>
Signed-off-by: Michael Adam <obnox@samba.org>
Kai Blin [Fri, 7 Nov 2008 08:50:33 +0000 (09:50 +0100)]
ntlm_auth: Put huge NTLMv2 blobs into extra_data on CRAP auth
This fixes bug #5865
Jeff Layton [Thu, 6 Nov 2008 20:15:57 +0000 (15:15 -0500)]
mount.cifs: use lock/unlock_mtab scheme from util-linux-ng mount prog
The util-linux-ng sources have a good, but rather complex scheme for
locking the mtab before updating it. Mount helpers need to follow the
same scheme. Advisory locking only works if everyone is using the same
locking scheme.
Copy the routines we need from util-linux-ng into a separate source file
and then have mount.cifs and umount.cifs link in this object.
The long term goal is to have these routines in a separate helper
library (libmount). Mount helpers can then dynamically link in that lib.
Until that happens, this should serve as a suitable stopgap solution.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Jeremy Allison [Thu, 6 Nov 2008 14:40:35 +0000 (06:40 -0800)]
Fix bug #5825 - Account locking out doesnt work with an LDAP backend.Based on a problem found by Boyang. Only the pdb_nds backend implements login attempts so this was broken for tdbsam and ldap.
Jeremy.
Jeremy Allison [Thu, 6 Nov 2008 03:11:53 +0000 (19:11 -0800)]
Add reference to bug #4308 to remind me to add regression test to smbtorture.
Jeremy.
Joe Smith [Tue, 4 Nov 2008 19:31:04 +0000 (20:31 +0100)]
Fixed typo in source/utils/net_rap.c
Jeremy Allison [Tue, 4 Nov 2008 12:34:30 +0000 (04:34 -0800)]
Merge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
Volker Lendecke [Tue, 4 Nov 2008 12:33:36 +0000 (04:33 -0800)]
Ignore 3.0 style invalid group mappings during upgrade to ldb
Volker Lendecke [Mon, 3 Nov 2008 16:09:40 +0000 (17:09 +0100)]
Fix bug triggered by the RAW-SAMBA3OPLOCKLOGOFF test
Michael Adam [Sun, 2 Nov 2008 22:02:02 +0000 (23:02 +0100)]
winbindd: speed up fill_grent_mem (i.e. winbindd_getgrent) a lot.
With large groups, getgrent ran into timeouts because after each
single user that was added to the expanded group list, the list
was sorted and made unique.
Now the list is sorted just once after all members have been added.
Michael
Volker Lendecke [Sun, 2 Nov 2008 09:28:00 +0000 (10:28 +0100)]
Fix bug 5860: safe_strcpy gives a nasty error message for overlong strings
Thanks to Robert Dahlem <Robert.Dahlem@gmx.net> for reporting this!
Andrew Tridgell [Thu, 30 Oct 2008 19:32:06 +0000 (12:32 -0700)]
use glibc sys/inotify.h header
when we first added the inotify code glibc didn't have the inotify
functions yet. Now that it does we can use the official header and
avoid the asm/unistd.h syscall workaround
Günther Deschner [Mon, 25 Aug 2008 09:36:56 +0000 (11:36 +0200)]
auth: Fix build warning.
Guenther
(cherry picked from commit
4661ef625a6522d6f859b83e3e3702f01d0b952f)
(cherry picked from commit
60649a74cdf2594bc89c301025f86d23caba91c2)
Jeremy Allison [Thu, 30 Oct 2008 00:07:54 +0000 (17:07 -0700)]
Fix CID: 456 - resource leak on function exit.
Jeremy.
Jeremy Allison [Wed, 29 Oct 2008 23:43:29 +0000 (16:43 -0700)]
Fix CID 606 - failed to return -1 after socket() fail.
Jeremy.
Jeremy Allison [Wed, 29 Oct 2008 23:28:04 +0000 (16:28 -0700)]
Fix CID 574 - tidies up the code expression.
Jeremy.
Jeremy Allison [Wed, 29 Oct 2008 23:02:16 +0000 (16:02 -0700)]
Coverity fix CID: 592 - null deref (can't happen but doesn't hurt to be sure).
Jeremy.