From 207ee6f164f6b7385e81d6c598734506c12a2937 Mon Sep 17 00:00:00 2001 From: Matthieu Patou Date: Thu, 13 Dec 2012 02:18:34 -0800 Subject: [PATCH] ldb: use strncmp instead of strcmp when comparing the val part val part of a DN's component is DATA_BLOB and nothing insure that it will be finished by a '\0' Reviewed-by: Stefan Metzmacher --- lib/ldb/common/ldb_dn.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/ldb/common/ldb_dn.c b/lib/ldb/common/ldb_dn.c index d63a27cbd415..7e1be2fbb5eb 100644 --- a/lib/ldb/common/ldb_dn.c +++ b/lib/ldb/common/ldb_dn.c @@ -1224,7 +1224,7 @@ static int ldb_dn_compare_base_internal(struct ldb_dn *base, struct ldb_dn *dn, if (b_vlen != dn_vlen) { return b_vlen - dn_vlen; } - ret = strcmp(b_vdata, dn_vdata); + ret = strncmp(b_vdata, dn_vdata, b_vlen); if (ret != 0) return ret; n_base--; @@ -1333,7 +1333,7 @@ int ldb_dn_compare(struct ldb_dn *dn0, struct ldb_dn *dn1) if (dn0_vlen != dn1_vlen) { return dn0_vlen - dn1_vlen; } - ret = strcmp(dn0_vdata, dn1_vdata); + ret = strncmp(dn0_vdata, dn1_vdata, dn0_vlen); if (ret != 0) { return ret; } -- 2.34.1