From 8fc213fcd4c5a6ddaa0d44965bcd0ca1afbbbc84 Mon Sep 17 00:00:00 2001 From: Stefan Metzmacher Date: Mon, 24 Nov 2008 15:07:56 +0100 Subject: [PATCH] libads/ldap.c: return an error instead of crashing when no realm is given The bug was triggered by "net ads info -S 127.8.7.6" (where 127.8.7.6 doesn't exist) and "disable netbios = yes". metze Signed-off-by: Michael Adam (cherry picked from commit e2a60d2e1fd7455f08e73f8d1c513ca240c0f0af) --- source/libads/ldap.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/source/libads/ldap.c b/source/libads/ldap.c index fa27415b3b11..a83477394304 100644 --- a/source/libads/ldap.c +++ b/source/libads/ldap.c @@ -301,11 +301,11 @@ static NTSTATUS ads_find_dc(ADS_STRUCT *ads) if ( use_own_domain ) c_realm = lp_workgroup(); } + } - if ( !c_realm || !*c_realm ) { - DEBUG(0,("ads_find_dc: no realm or workgroup! Don't know what to do\n")); - return NT_STATUS_INVALID_PARAMETER; /* rather need MISSING_PARAMETER ... */ - } + if ( !c_realm || !*c_realm ) { + DEBUG(0,("ads_find_dc: no realm or workgroup! Don't know what to do\n")); + return NT_STATUS_INVALID_PARAMETER; /* rather need MISSING_PARAMETER ... */ } realm = c_realm; -- 2.34.1