FIXUP:  WIP: verification_trailer

FIXUP: sec_vt_command bitmask

sec_vt_bitmask

FIXUP: give names to sec_vt_command's

header field for sec_vt_command_length

give names to sec_vt_command's

add bitmask for sec_vt_command

WIP: verification_trailer

Move Auth padding to the right tree

add WERR_INVALID_STATE

add WERR_TIMEOUT

packet-smb2: pass smb2_info via private_data

sq FSCTL_PIPE_WAIT

sq epan/dissectors/packet-smb2.c no check_col => fsctl_pipe_wait

WIP: fsctl_pipe_wait

WIP: FSCTL_PIPE_WAIT

Revert "smb-direct fragmentation"

This reverts commit 7559f043b05f60abdec72c49bb1adb48ae2ee584.

smb-direct fragmentation

MIT krb5-1.6 HACK patch

Apply this patch to krb5-1.6.x and build it
with a special prefix that only wireshark will use!

Then start wireshark with a script like this:

-----
metze@SERNOX:~/devel/wireshark/wireshark.git$ cat ~/bin/mxwrap.wireshark.krb5

export LD_LIBRARY_PATH="/home/metze/prefix/mit-krb5-1-6/lib/:$LD_LIBRARY_PATH"
exec /home/metze/devel/prefix/wireshark/bin/wireshark $@
gdb --args /home/metze/devel/prefix/wireshark/bin/wireshark $@
------

The LD_PRELOAD only works if the krb5 library version your system one,
then you just need to replace "libk5crypto.so", otherwise wireshark
needs to all of the custom libraries.

metze

fix for netmon 3.x captures

metze

TODO: packet-smb2: setup decryption keys for kerberos session setups

packet-kerberos: remember in what frame a key was learned

asn1/kerberos: remember in what frame a key was learned

packet-smb: register a dissector on top of smb_direct

Signed-off-by: Stefan Metzmacher <metze@samba.org>

packet-smb2: register a dissector on top of smb_direct

Signed-off-by: Stefan Metzmacher <metze@samba.org>

packet-iwarp-mpa: give more information if the ULPDU length doesn't match

Try to dissect even it the size is not as expected.
Windows doesn't use alignment for smb-direct.

Signed-off-by: Stefan Metzmacher <metze@samba.org>

packet-smb-direct.c: add initial implementation

Signed-off-by: Stefan Metzmacher <metze@samba.org>

packet-iwarp-ddp-rdmap: make it possible to register "iwarp_ddp_rdmap" payload dissectors

Signed-off-by: Stefan Metzmacher <metze@samba.org>

TODO needed??? packet-ntlmssp: fix possible segfault and set blob->length so the max value

Add a HACK patch for building a patched kerberos library

Signed-off-by: Matthieu Patou <mat@matws.net>

packet-smb2: dissect SMBDirect Buffer Descriptors

Signed-off-by: Stefan Metzmacher <metze@samba.org>

packet-smb2: fix lease epoch fields

Bug: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9703

Change-Id: I1955360adaee53846f084434c59180d715e19fcd
Signed-off-by: Stefan Metzmacher <metze@samba.org>

smb2: Lease Epoch is only 16 bit

See [MS-SMB2] 2.2.14.2.12

Bug: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9703

Change-Id: Ia9c9c658bd5020e0dad84fc74617fed60ce7df06
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

smb2: Fix a typo

Bug: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9703

Change-Id: I8ebb20a48e1131fcf14ee55e5e1822a8dcd713d2
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

Revert "In get_unicode_or_ascii_string(), check if the length is odd/even, not the offset.  Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5778 - Volume label field ... is not displayed correctly ..."

This is wrong it breaks all sort of things. The "Volume label field"
is a special case, which can be fixed by using nopad=TRUE.

Change-Id: I3cd3f30ff0076d5e31a735391b175fd68e5fa142
Signed-off-by: Stefan Metzmacher <metze@samba.org>

packet-smb.c: real fix for https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5778

Change-Id: I33308c44791b487844f23db07d152897380d7cf1
Signed-off-by: Stefan Metzmacher <metze@samba.org>

Comment out a lot more hf[] entries and related.
(Found by checkhf).

Note: There's quite a large amount of hf[] entries which are
      commented out. I wonder if there are "top-level" entries
      missing from the "parse-tree" arrays ?

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54990 f5534014-38df-0310-8fa8-9805f1628bb7

Comment out unused hf[] entries and related found by checkhf.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54989 f5534014-38df-0310-8fa8-9805f1628bb7

Re-arrange #if 0/#endif related to an hf[] entry so that checkhf doesn't complain.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54988 f5534014-38df-0310-8fa8-9805f1628bb7

From Marko Hrastovec via
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9697

Architectural support for multiple version of the same Asterix categories.
Includes implementation of CAT064 v.0.17.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54987 f5534014-38df-0310-8fa8-9805f1628bb7

Make it easier to try GTK 3.6

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54986 f5534014-38df-0310-8fa8-9805f1628bb7

Convert the quick setup chapter to AsciiDoc and start converting its
content to Git.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54985 f5534014-38df-0310-8fa8-9805f1628bb7

Fix hf[] entries with refs to range_string arrays
 to add missing BASE_RANGE_STRING and to use RVALS instead of VALS.

Fixes crashes in 'tshark -G values' and presumably also fixes
 crashes when used in a dissection.

Introduced in SVN #54449.

(I suspect that ' convert_proto_tree_add_text.pl' may need some work
 to handle range_strings).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54984 f5534014-38df-0310-8fa8-9805f1628bb7

Fix: value string specified as a BASE_VAL64_STRING in
 an hf[] entry but defined as a 'value_string' intead of
 as a 'val64_string'.

Caused 'tshark -G values' to crash
 (and presumably would also cause a crash when the value-string
  is referenced in a dissection):

Introduced in svn #54728

(Note: There's still another 'tshark -G values' crash to to found & fixed)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54983 f5534014-38df-0310-8fa8-9805f1628bb7

(Trivial) Fix spellling in a comment.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54982 f5534014-38df-0310-8fa8-9805f1628bb7

From Pavel Moravec via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9612

Fix possibly-uninitialized variable caught by valgrind fuzzing in AMQP.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54981 f5534014-38df-0310-8fa8-9805f1628bb7

Add missing cast.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54980 f5534014-38df-0310-8fa8-9805f1628bb7

Revert part of previous change

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54979 f5534014-38df-0310-8fa8-9805f1628bb7

Send news of SecurityModeFailure to PDCP dissector, which will attempt to roll back to previous setting

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54978 f5534014-38df-0310-8fa8-9805f1628bb7

Do not handle BER bitstring as ASCII string, because this will fail
when the first bit is set.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54977 f5534014-38df-0310-8fa8-9805f1628bb7

Add back the fix from revision 54693.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54976 f5534014-38df-0310-8fa8-9805f1628bb7

Added back x509af_get_last_algorithm_id() removed in revision 54647 to
restore usage in cms and pkcs12.  They never got a valid value in
actx->external.direct_reference because they use another actx in this case.

This will add back the global variable in x509af, but this is needed
until we manage to pass the value in another way.

See comments in bug 9573.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54975 f5534014-38df-0310-8fa8-9805f1628bb7

Try to fix the path selector argument.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54974 f5534014-38df-0310-8fa8-9805f1628bb7

Fix a section name conflict.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54973 f5534014-38df-0310-8fa8-9805f1628bb7

Restore an inadvertently deleted file.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54972 f5534014-38df-0310-8fa8-9805f1628bb7

Migrate the build environment introduction to AsciiDoc.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54971 f5534014-38df-0310-8fa8-9805f1628bb7

Convert the preface to AsciiDoc with minor edits.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54970 f5534014-38df-0310-8fa8-9805f1628bb7

GPLv2 -> GPLv2+

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54969 f5534014-38df-0310-8fa8-9805f1628bb7

lupdate / lrelease ui/qt/Qtshark.pro

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54968 f5534014-38df-0310-8fa8-9805f1628bb7

Fix indent (Use 4spaces) and modelines info

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54967 f5534014-38df-0310-8fa8-9805f1628bb7

Drop support of Visual Studio 2005

* Remove _MSC_VER < 1500 check
* Cleanup config.nmake

See http://www.wireshark.org/lists/wireshark-dev/201305/msg00159.html

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54965 f5534014-38df-0310-8fa8-9805f1628bb7

Fix indent (Use 4 spaces) and add modelines

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54964 f5534014-38df-0310-8fa8-9805f1628bb7

Fix encoding arg for RSVP dissector (with fix-encodings-args tools

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54963 f5534014-38df-0310-8fa8-9805f1628bb7

(Trivial) update a comment

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54962 f5534014-38df-0310-8fa8-9805f1628bb7

TABs -> spaces
add editor modelines

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54961 f5534014-38df-0310-8fa8-9805f1628bb7

BASE_NONE -> STR_ASCII

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54960 f5534014-38df-0310-8fa8-9805f1628bb7

the sametime dissector stores the result of tvb_get_string() into hf
 variables that can handle only 7bit ascii strings
replace this with tvb_get_string_enc()

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54959 f5534014-38df-0310-8fa8-9805f1628bb7

Comment out the "diff" section for now. We'll have to update it for "git
diff" at some point.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54958 f5534014-38df-0310-8fa8-9805f1628bb7

Uncomment anchors.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54957 f5534014-38df-0310-8fa8-9805f1628bb7

Fix Windows build.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54956 f5534014-38df-0310-8fa8-9805f1628bb7

Fix xpath selector. Clean up whitespace.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54955 f5534014-38df-0310-8fa8-9805f1628bb7

Migrate more SVN content to Git+Gerrit.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54954 f5534014-38df-0310-8fa8-9805f1628bb7

Migrate some of the SVN-specific content to Git.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54953 f5534014-38df-0310-8fa8-9805f1628bb7

Try to get CMake to build the Developer Guide again. I don't have
dblatex installed so the release notes fail to build but the WSDG
targets appear to work.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54952 f5534014-38df-0310-8fa8-9805f1628bb7

The wimax plugin primarily uses tvb_get_ptr buffer accesses instead of the
safe accessor functions, and it's all done via scary bit-twiddling macros to
boot.

Create the macros TVB_NIB_WORD and TVB_NIB_NIBBLE that (should) behave just
like the raw-pointer NIB_WORD and NIB_NIBBLE macros, except using the safe tvb
functions instead.

Replace two instances with the safe versions, which fixes an out-of-bounds
access caught by my valgrind fuzzer. If this doesn't break anything then we
should probably do a wholesale replacement at some point, but I'm not feeling
that adventurous at the moment.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54951 f5534014-38df-0310-8fa8-9805f1628bb7

Mark a few function parameters as unused....

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54950 f5534014-38df-0310-8fa8-9805f1628bb7

Rework and simplify the code to follow the principle of "dissect as
 much as possible" rather than dissecting nothing if the length of a
 set of fields (e.g., a "command") seems wrong or if an exception
 occurs fetching data before previous fields have been displayed.
In general: just fetch/dissect from start to end: If there is missing
   data, a Wireshark exception will eventually occur;

Add lwm subtrees under the lwm protocol tree (*not* as protocols
 under the top (outermost) tree.

Fix a bug which caused an exception to be reported as:
 "[Packet size limited during capture: LwMesh truncated]"
 rather than as the correct: "[Malformed...]"

col_...() and expert...() functions shouldn't be called under 'if(tree)';

Register the heuristic dissector using "IEEE802154_PROTOABBREV_WPAN"
 (like certain other dissectors) rather than using "wpan";

missmatch --> mismatch

Fix some long lines.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54949 f5534014-38df-0310-8fa8-9805f1628bb7

Add packet-mbim.h to Makefile.common

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54948 f5534014-38df-0310-8fa8-9805f1628bb7

Make "all" the default target again.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54947 f5534014-38df-0310-8fa8-9805f1628bb7

Fix AsciiDoc WSDG build on Windows.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54946 f5534014-38df-0310-8fa8-9805f1628bb7

Start migrating the Developer's Guide to AsciiDoc. So far only one
chapter (WSDG_chapter_sources) has been converted.

Conversion was done using the script in
https://code.wireshark.org/review/#/c/9/ along with manual cleanup.
Changes are mostly limited formatting.

It's helpful to have a copy of the pre-conversion guide for comparison.
I've placed a chunked copy online at
http://www.wireshark.org/~gerald/wsdg_html_2014_01/ .

Tested under Autotools. Nmake and CMake will likely break. I'll take a
look shortly. If only we had documention adding a feature branch to
Gerrit and using it to test different platforms...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54945 f5534014-38df-0310-8fa8-9805f1628bb7

Add ability to register new UUID and CIDs

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54944 f5534014-38df-0310-8fa8-9805f1628bb7

Remove some old obsolete text in the proto_tree_add_text() description.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54943 f5534014-38df-0310-8fa8-9805f1628bb7

Fix dissection of 8PSK Power Capability IE

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54942 f5534014-38df-0310-8fa8-9805f1628bb7

Give valgrind fuzzing a bit more time. Otherwise we have some large (~80MB)
captures in the menagerie which time out even under normal circumstances.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54941 f5534014-38df-0310-8fa8-9805f1628bb7

Check for a zero offset in the "get status" reply *before* adding the
offset in the tvbuff of the beginning of the packet to it.  Otherwise,
it will never be zero, and the tests will always think the field pointed
to by the offset is present.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54938 f5534014-38df-0310-8fa8-9805f1628bb7

Looks like the asciidoc stuff is wip and breaks cmake builds.
Comment it out for now.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54937 f5534014-38df-0310-8fa8-9805f1628bb7

Prepare for conversion of Guide chapters to AsciiDoc.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54936 f5534014-38df-0310-8fa8-9805f1628bb7

country and language are ISO-8859-1

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54935 f5534014-38df-0310-8fa8-9805f1628bb7

make the menu string filterable

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54934 f5534014-38df-0310-8fa8-9805f1628bb7

the menu string is a DVB string

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54933 f5534014-38df-0310-8fa8-9805f1628bb7

From me for https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9519 RSVP dissector does not decode Session Object (1) C-type (13) message

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54932 f5534014-38df-0310-8fa8-9805f1628bb7

Remove Update.c (and nio-ie5.[ch])

Never use... and replace by (Win)Sparkle

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54931 f5534014-38df-0310-8fa8-9805f1628bb7

Given that we allow the 'outfile file' to be stdout, then presumably all
 text messages (including informational) should go to stderr.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54930 f5534014-38df-0310-8fa8-9805f1628bb7

printf(...) --> fprintf(stderr,...)  (in a commented out line of code)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54929 f5534014-38df-0310-8fa8-9805f1628bb7

Remove duplicate #include.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54928 f5534014-38df-0310-8fa8-9805f1628bb7

Please GCC 4.3.2 that complains about a wrong 'variable may be used uninitialized in this function' error

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54927 f5534014-38df-0310-8fa8-9805f1628bb7

Use tvb_get_string_enc() rather than tvb_get_string().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54926 f5534014-38df-0310-8fa8-9805f1628bb7

Use tvb_get_string_enc() rather than tvb_get_string().  RFC 5352 says,
in section 6.1 "Registration.Request Primitive":

The Pool Handle parameter contains a NULL terminated ASCII
string of fixed length.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54925 f5534014-38df-0310-8fa8-9805f1628bb7

Use tvb_get_string_enc() rather than tvb_get_string().

Update URL of spec.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@54924 f5534014-38df-0310-8fa8-9805f1628bb7