printing: traverse_read the printer list for share updates
authorDavid Disseldorp <ddiss@samba.org>
Wed, 9 Jul 2014 22:18:10 +0000 (00:18 +0200)
committerAndreas Schneider <asn@cryptomilk.org>
Fri, 8 Aug 2014 12:10:38 +0000 (14:10 +0200)
commit1e83435eac2cef03fccb4cf69ef5e0bfbd710410
treee5b6e0d66d31cd223f1dda28d768b7c12a65c1be
parent9c5470be1e69af78c0c681fbb9a2d113039556f3
printing: traverse_read the printer list for share updates

The printcap update procedure involves the background printer process
obtaining the printcap information from the printing backend, writing
this to printer_list.tdb, and then notifying all smbd processes of the
new list. The processes then all attempt to simultaneously traverse
printer_list.tdb, in order to update their local share lists.

With a large number of printers, and a large number of per-client smbd
processes, this traversal results in significant lock contention, mostly
due to the fact that the traversal is unnecessarily done with an
exclusive (write) lock on the printer_list.tdb database.

This commit changes the share update code path to perform a read-only
traversal.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=10652

Reported-by: Alex K <korobkin+samba@gmail.com>
Reported-by: Franz Pförtsch <franz.pfoertsch@brose.com>
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
source3/printing/load.c
source3/printing/pcap.c
source3/printing/pcap.h
source3/printing/printer_list.c
source3/printing/printer_list.h