ctdb:recoverd: fix endless banning due to non-frozen DBs.
authorMichael Adam <obnox@samba.org>
Tue, 31 May 2016 23:19:43 +0000 (01:19 +0200)
committerMichael Adam <obnox@samba.org>
Wed, 1 Jun 2016 01:49:46 +0000 (03:49 +0200)
commitda4e8d4f49e6a5177dcc26dc9107861ef5c3c564
treebe0bf743eb36187793fb72d0853faa2edf297a8f
parent5e889e235694ace398e7b2d0ace477ee6abd00cd
ctdb:recoverd: fix endless banning due to non-frozen DBs.

When the banned node got marked RECOVERY_ACTIVE, but
freezing the DBs failed (e.g. if banning happened
while recovery was set to active but dbs not banned),
then the freezing will never be tried again, and the
node will keep banning itself indefinitely, until
ctdbd is restarted.

This is a regression from 4.3, introduced with

b4357a79d916b1f8ade8fa78563fbef0ce670aa9

and

d8f3b490bbb691c9916eed0df5b980c1aef23c85

This change lets the main loop in the banned case keep
trying to freeze the dbs, hence avoiding the endless loop.
Note that we currently have no means to tell in the
recovery daemon whether the DBs are frozen, so we
send the freeze control each time..

Signed-off-by: Michael Adam <obnox@samba.org>
ctdb/server/ctdb_recoverd.c