From: Robin Hack <hack.robin@gmail.com>
Date: Mon, 16 Nov 2015 22:38:51 +0000 (+0100)
Subject: nwrap: Small code shift in nwrap_ed_inventarize_add_to_existing()
X-Git-Url: http://git.samba.org/?p=obnox%2Fsamba%2Fsamba-obnox.git;a=commitdiff_plain;h=16b71aecab5233138dd609fffbc9296abe3628c5

nwrap: Small code shift in nwrap_ed_inventarize_add_to_existing()

Allocate memory only when necessary.

Signed-off-by: Robin Hack <hack.robin@gmail.com>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
---

diff --git a/lib/nss_wrapper/nss_wrapper.c b/lib/nss_wrapper/nss_wrapper.c
index a8cbc222ac7..d204ea60a8f 100644
--- a/lib/nss_wrapper/nss_wrapper.c
+++ b/lib/nss_wrapper/nss_wrapper.c
@@ -2610,21 +2610,20 @@ static bool nwrap_ed_inventarize_add_to_existing(struct nwrap_entdata *const ed,
 		return false;
 	}
 
-	el_new = nwrap_entlist_init(ed);
-	if (el_new == NULL) {
-		return false;
-	}
 
 	for (cursor = el; cursor->next != NULL; cursor = cursor->next)
 	{
 		if (cursor->ed == ed) {
-			free(el_new);
 			return false;
 		}
 	}
 
 	if (cursor->ed == ed) {
-		free(el_new);
+		return false;
+	}
+
+	el_new = nwrap_entlist_init(ed);
+	if (el_new == NULL) {
 		return false;
 	}